89 lines
3.0 KiB
Go
89 lines
3.0 KiB
Go
package logging
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestHTTPLogsRawBoundaryBytesAndPreservesBodies(t *testing.T) {
|
|
for _, debug := range []bool{false, true} {
|
|
t.Run(map[bool]string{false: "normal", true: "debug"}[debug], func(t *testing.T) {
|
|
out := installTestLogger(t, debug)
|
|
requestBody := `{ "task_id":"4", "api_key":"private-key", "params":{"speed":1.0}}`
|
|
responseBody := `{ "status":"ok", "content":"private-dialogue", "n":1e+02 }`
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
b, e := io.ReadAll(r.Body)
|
|
if e != nil || string(b) != requestBody {
|
|
t.Errorf("business body changed: %s %v", b, e)
|
|
}
|
|
if r.Header.Get("Authorization") != "Bearer private-header" {
|
|
t.Error("header changed")
|
|
}
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.Header().Set("Set-Cookie", "private-cookie")
|
|
w.Write([]byte(responseBody))
|
|
}))
|
|
defer server.Close()
|
|
req, e := http.NewRequestWithContext(context.Background(), http.MethodPost, server.URL+"/task/4", strings.NewReader(requestBody))
|
|
if e != nil {
|
|
t.Fatal(e)
|
|
}
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer private-header")
|
|
res, e := HTTPClient(server.Client(), "dispatcher", "saas").Do(req)
|
|
if e != nil {
|
|
t.Fatal(e)
|
|
}
|
|
b, e := io.ReadAll(res.Body)
|
|
res.Body.Close()
|
|
if e != nil || string(b) != responseBody {
|
|
t.Fatal("response changed", e)
|
|
}
|
|
text := out.String()
|
|
for _, secret := range []string{"private-key", "private-dialogue", "private-header", "private-cookie"} {
|
|
if strings.Contains(text, secret) {
|
|
t.Fatalf("leak: %s", text)
|
|
}
|
|
}
|
|
for _, expected := range []string{"dispatcher->saas", "saas->dispatcher", "request_start", "response_received", "body_read", "duration_ms"} {
|
|
if !strings.Contains(text, expected) {
|
|
t.Fatalf("missing %s: %s", expected, text)
|
|
}
|
|
}
|
|
if strings.Contains(text, `\"n\":1e+02`) != debug {
|
|
t.Fatal("debug raw bytes or normal omission failed", text)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestHTTPBinaryIsNotLoggedAndSignedURLIsMasked(t *testing.T) {
|
|
out := installTestLogger(t, true)
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
io.Copy(io.Discard, r.Body)
|
|
w.Header().Set("Content-Type", "audio/wav")
|
|
w.Write([]byte("private-audio"))
|
|
}))
|
|
defer server.Close()
|
|
req, _ := http.NewRequest(http.MethodPut, server.URL+"/recording?signature=private-url", strings.NewReader("private-recording"))
|
|
req.Header.Set("Content-Type", "audio/wav")
|
|
res, e := HTTPClient(server.Client(), "agent", "oss").Do(req)
|
|
if e != nil {
|
|
t.Fatal(e)
|
|
}
|
|
io.Copy(io.Discard, res.Body)
|
|
res.Body.Close()
|
|
for _, secret := range []string{"private-url", "private-recording", "private-audio"} {
|
|
if strings.Contains(out.String(), secret) {
|
|
t.Fatal(out.String())
|
|
}
|
|
}
|
|
if !strings.Contains(out.String(), "binary_omitted") {
|
|
t.Fatal(out.String())
|
|
}
|
|
}
|