H-292: prove Captain Skill updates reach CAS (#54)

* H-292: prove Captain Skill updates reach CAS

* H-292: prove handler conflict comes from CAS

* H-292: reuse profile test password digest

---------

Co-authored-by: Rogee <rogee@ipao.vip>

backend/internal/handler/api/v1/captain_skill_handler_test.go

@@ -5,8 +5,10 @@ import (
 	"encoding/json"
 	"net/http"
 	"net/http/httptest"
+	"path/filepath"
 	"strconv"
 	"testing"
+	"time"
 
 	"github.com/gin-gonic/gin"
 	"github.com/stretchr/testify/assert"
@@ -25,8 +27,12 @@ import (
 func newCaptainSkillHandlerTestRouter(t *testing.T) (*gin.Engine, *gorm.DB, *model.CaptainAssistant) {
 	t.Helper()
 	gin.SetMode(gin.TestMode)
-	db, err := gorm.Open(sqlite.Open("file:"+t.Name()+"?mode=memory&cache=shared"), &gorm.Config{Logger: logger.Default.LogMode(logger.Silent)})
+	db, err := gorm.Open(sqlite.Open("file:"+filepath.Join(t.TempDir(), "captain-skill-handler.db")+"?_busy_timeout=5000&_journal_mode=WAL"), &gorm.Config{Logger: logger.Default.LogMode(logger.Silent)})
 	require.NoError(t, err)
+	sqlDB, err := db.DB()
+	require.NoError(t, err)
+	sqlDB.SetMaxOpenConns(2)
+	t.Cleanup(func() { require.NoError(t, sqlDB.Close()) })
 	require.NoError(t, db.AutoMigrate(&model.CaptainAssistant{}, &model.CaptainSkill{}, &model.CaptainSkillReference{}, &model.CaptainAssistantSkill{}))
 	assistant := &model.CaptainAssistant{AccountID: 1, Name: "Assistant", Status: model.AssistantStatusActive}
 	require.NoError(t, db.Create(assistant).Error)
@@ -145,3 +151,63 @@ func TestCaptainSkillHandlerValidationAndConflictStatuses(t *testing.T) {
 	w = captainSkillRequest(t, router, http.MethodDelete, base+"/skills/"+skillID, "administrator", nil)
 	assert.Equal(t, http.StatusNoContent, w.Code)
 }
+
+func TestCaptainSkillHandlerConcurrentUpdateCASConflict(t *testing.T) {
+	router, db, _ := newCaptainSkillHandlerTestRouter(t)
+	base := "/api/v1/accounts/1/captain/skills"
+	w := captainSkillRequest(t, router, http.MethodPost, base, "administrator", captainSkillBody("active"))
+	require.Equal(t, http.StatusOK, w.Code, w.Body.String())
+	var created map[string]any
+	require.NoError(t, json.Unmarshal(w.Body.Bytes(), &created))
+
+	ready := make(chan struct{}, 2)
+	release := make(chan struct{})
+	rowsAffected := make(chan int64, 2)
+	barrierName := "test:captain_skill_handler_cas_barrier"
+	rowsName := "test:captain_skill_handler_cas_rows"
+	require.NoError(t, db.Callback().Update().Before("gorm:update").Register(barrierName, func(tx *gorm.DB) {
+		if tx.Statement.Table == "captain_skills" {
+			ready <- struct{}{}
+			<-release
+		}
+	}))
+	require.NoError(t, db.Callback().Update().After("gorm:update").Register(rowsName, func(tx *gorm.DB) {
+		if tx.Statement.Table == "captain_skills" {
+			rowsAffected <- tx.RowsAffected
+		}
+	}))
+	defer func() {
+		require.NoError(t, db.Callback().Update().Remove(barrierName))
+		require.NoError(t, db.Callback().Update().Remove(rowsName))
+	}()
+
+	responses := make(chan *httptest.ResponseRecorder, 2)
+	for i := range 2 {
+		body := captainSkillBody("active")
+		body["skill"].(map[string]any)["description"] = "Concurrent update " + strconv.Itoa(i)
+		body["skill"].(map[string]any)["expected_version"] = created["version"]
+		go func() {
+			responses <- captainSkillRequest(t, router, http.MethodPut, base+"/"+strconv.Itoa(int(created["id"].(float64))), "administrator", body)
+		}()
+	}
+	for range 2 {
+		select {
+		case <-ready:
+		case <-time.After(5 * time.Second):
+			close(release)
+			t.Fatal("both HTTP updates did not reach the repository CAS")
+		}
+	}
+	close(release)
+
+	statuses := make([]int, 0, 2)
+	for range 2 {
+		response := <-responses
+		statuses = append(statuses, response.Code)
+		if response.Code == http.StatusConflict {
+			assert.Contains(t, response.Body.String(), repository.ErrCaptainSkillVersionConflict.Error())
+		}
+	}
+	assert.ElementsMatch(t, []int{http.StatusOK, http.StatusConflict}, statuses)
+	assert.ElementsMatch(t, []int64{1, 0}, []int64{<-rowsAffected, <-rowsAffected})
+}

backend/internal/handler/api/v1/profile_handler_test.go

@@ -150,14 +150,12 @@ func (s *ProfileHandlerTestSuite) buildRouter() *gin.Engine {
 
 func (s *ProfileHandlerTestSuite) SetupTest() {
 	s.db.Where("user_id = ?", s.userID).Delete(&model.UserSession{})
-	passwordDigest, err := crypto.HashPassword("oldpassword")
-	s.Require().NoError(err)
 	// Reset user to original state before each test
 	s.db.Model(&model.User{}).Where("id = ?", s.userID).Updates(map[string]interface{}{
 		"name":               "ProfileUser",
 		"email":              "profile@example.com",
-		"password":           passwordDigest,
-		"password_digest":    passwordDigest,
+		"password":           s.user.PasswordDigest,
+		"password_digest":    s.user.PasswordDigest,
 		"avatar_url":         "",
 		"available":          false,
 		"display_name":       "Profile Display",