rogee/gochat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(webhooks): replace parity stubs

Browse Source
This commit is contained in:
rogee
2026-06-07 13:18:25 +08:00
parent 7ea4bf9362
commit c28eb010c6
4 changed files with 75 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/CHATWOOT_PARITY_DEVELOPMENT_PLAN.md
+16 -14
View File
File diff suppressed because one or more lines are too long
docs/parity/placeholder_audit.md
+6 -6
View File
@@ -1,6 +1,6 @@
# Phase 6 Placeholder Audit
Updated: 2026-06-06T17:53:18Z
Updated: 2026-06-07
## Commands
@@ -13,11 +13,11 @@ scripts/parity_frontend_smoke.sh --check
## Result
`chatwootParityStub` appears only in `internal/router/router.go`: 20 call sites plus the helper definition.
`chatwootParityStub` has been removed from product code. The exact scan returns no matches.
The broader placeholder scan still has no reused-frontend critical account/contact/conversation/message/inbox/widget/public handler placeholder. Non-stub matches are test doubles, expected validation errors such as unsupported file/search/bulk-action operations, excluded SSO/SAML placeholder notes, or provider-specific nil-handler fallbacks.
The broader placeholder scan still has no reused-frontend critical account/contact/conversation/message/inbox/widget/public handler placeholder. Non-stub matches are test doubles, expected validation errors such as unsupported file/search/bulk-action operations, excluded SSO/SAML placeholder notes, or explicit assertions that nil webhook fallbacks do not return placeholder bodies.
All call sites are nil-handler guards for public webhook registration paths:
The previously remaining call sites were nil-handler guards for public webhook registration paths:
- Telegram webhook callback.
- WhatsApp verify and event callbacks.
@@ -28,11 +28,11 @@ All call sites are nil-handler guards for public webhook registration paths:
- Instagram verify and event callbacks.
- Shopify webhook callback.
No `chatwootParityStub` call site is registered on the reused dashboard account/contact/conversation/message/inbox API path, widget API path, public help-center path, public inbox/contact/conversation/message API path, or enterprise settings API path.
No `chatwootParityStub` call site remains on any reused dashboard account/contact/conversation/message/inbox API path, widget API path, public help-center path, public inbox/contact/conversation/message API path, enterprise settings API path, or webhook fallback path.
## Classification
The remaining stubs are defensive nil-handler fallbacks. In normal app bootstrap the matching provider handlers are wired and these branches do not define the route behavior. Provider-specific webhook behavior remains owned by the existing webhook/channel parity slices and future B12 or provider fixture failures.
The former defensive nil-handler fallbacks now return explicit `503 { error: "webhook provider unavailable", message: "webhook handler is not configured" }` responses instead of placeholder/not-implemented bodies. In normal app bootstrap the matching provider handlers are wired and these branches do not define the route behavior. Provider-specific webhook behavior remains owned by the existing webhook/channel parity slices and future B12 or provider fixture failures.
Phase 6 is therefore in Review for the inspected placeholder surface. Reopen it only if a fresh `rg` audit or reused frontend smoke identifies a frontend-reachable `chatwootParityStub`, `not implemented`, or placeholder success response in account/contact/conversation/message/inbox/widget/public critical paths.