* fix(captain): restore inbox takeover and KB citations * fix(captain): harden grounded citations and smoke seed --------- Co-authored-by: Rogee <rogee@ipao.vip>
115 lines
4.2 KiB
Go
115 lines
4.2 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"path/filepath"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/gochat/gochat/internal/model"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/logger"
|
|
)
|
|
|
|
func captainSeedTestDB(t *testing.T) *gorm.DB {
|
|
t.Helper()
|
|
dsn := filepath.Join(t.TempDir(), "captain-seed.db") + "?_busy_timeout=5000&_journal_mode=WAL"
|
|
db, err := gorm.Open(sqlite.Open(dsn), &gorm.Config{
|
|
DisableForeignKeyConstraintWhenMigrating: true,
|
|
Logger: logger.Default.LogMode(logger.Silent),
|
|
})
|
|
require.NoError(t, err)
|
|
require.NoError(t, db.AutoMigrate(&model.Account{}, &model.CaptainAssistant{}, &model.CaptainInbox{}))
|
|
return db
|
|
}
|
|
|
|
func TestSeedSmokeCaptainIsRepeatableAndConcurrent(t *testing.T) {
|
|
db := captainSeedTestDB(t)
|
|
ctx := context.Background()
|
|
account := &model.Account{Name: "Smoke account", Active: true}
|
|
require.NoError(t, db.Create(account).Error)
|
|
|
|
start := make(chan struct{})
|
|
errs := make(chan error, 2)
|
|
var wg sync.WaitGroup
|
|
for range 2 {
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
<-start
|
|
_, err := seedSmokeCaptain(ctx, db, account.ID, 10)
|
|
errs <- err
|
|
}()
|
|
}
|
|
close(start)
|
|
wg.Wait()
|
|
close(errs)
|
|
for err := range errs {
|
|
require.NoError(t, err)
|
|
}
|
|
first, err := seedSmokeCaptain(ctx, db, account.ID, 10)
|
|
require.NoError(t, err)
|
|
second, err := seedSmokeCaptain(ctx, db, account.ID, 10)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, first.ID, second.ID)
|
|
|
|
var assistants, bindings int64
|
|
require.NoError(t, db.Model(&model.CaptainAssistant{}).Where("account_id = ? AND name = ?", account.ID, "Smoke Captain").Count(&assistants).Error)
|
|
require.NoError(t, db.Model(&model.CaptainInbox{}).Where("inbox_id = ?", 10).Count(&bindings).Error)
|
|
assert.Equal(t, int64(1), assistants)
|
|
assert.Equal(t, int64(1), bindings)
|
|
|
|
var persisted model.CaptainAssistant
|
|
require.NoError(t, db.First(&persisted, first.ID).Error)
|
|
var config map[string]any
|
|
require.NoError(t, json.Unmarshal(persisted.Config, &config))
|
|
assert.Equal(t, true, config["feature_citation"])
|
|
}
|
|
|
|
func TestSeedSmokeCaptainConflictHasNoSideEffects(t *testing.T) {
|
|
db := captainSeedTestDB(t)
|
|
account := &model.Account{Name: "Smoke account", Active: true}
|
|
require.NoError(t, db.Create(account).Error)
|
|
other := &model.CaptainAssistant{AccountID: account.ID, Name: "Other Captain", Status: model.AssistantStatusActive, Config: json.RawMessage(`{"feature_citation":true}`)}
|
|
require.NoError(t, db.Create(other).Error)
|
|
require.NoError(t, db.Create(&model.CaptainInbox{AccountID: account.ID, AssistantID: other.ID, InboxID: 10}).Error)
|
|
smoke := &model.CaptainAssistant{AccountID: account.ID, Name: "Smoke Captain", Status: model.AssistantStatusActive, Config: json.RawMessage(`{"feature_citation":false,"sentinel":"keep"}`)}
|
|
require.NoError(t, db.Create(smoke).Error)
|
|
|
|
_, err := seedSmokeCaptain(context.Background(), db, account.ID, 10)
|
|
require.Error(t, err)
|
|
|
|
var persisted model.CaptainAssistant
|
|
require.NoError(t, db.First(&persisted, smoke.ID).Error)
|
|
var config map[string]any
|
|
require.NoError(t, json.Unmarshal(persisted.Config, &config))
|
|
assert.Equal(t, false, config["feature_citation"])
|
|
assert.Equal(t, "keep", config["sentinel"])
|
|
|
|
var bindings []model.CaptainInbox
|
|
require.NoError(t, db.Where("inbox_id = ?", 10).Find(&bindings).Error)
|
|
require.Len(t, bindings, 1)
|
|
assert.Equal(t, other.ID, bindings[0].AssistantID)
|
|
}
|
|
|
|
func TestSeedSmokeCaptainRechecksSameAssistantAfterConflict(t *testing.T) {
|
|
db := captainSeedTestDB(t)
|
|
account := &model.Account{Name: "Smoke account", Active: true}
|
|
require.NoError(t, db.Create(account).Error)
|
|
smoke := &model.CaptainAssistant{AccountID: account.ID, Name: "Smoke Captain", Status: model.AssistantStatusActive, Config: json.RawMessage(`{"feature_citation":false}`)}
|
|
require.NoError(t, db.Create(smoke).Error)
|
|
require.NoError(t, db.Create(&model.CaptainInbox{AccountID: account.ID, AssistantID: smoke.ID, InboxID: 10}).Error)
|
|
|
|
persisted, err := seedSmokeCaptain(context.Background(), db, account.ID, 10)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, smoke.ID, persisted.ID)
|
|
|
|
var config map[string]any
|
|
require.NoError(t, json.Unmarshal(persisted.Config, &config))
|
|
assert.Equal(t, true, config["feature_citation"])
|
|
}
|