From 20fabcd1d76f0b170f8647831f8e8859be589662 Mon Sep 17 00:00:00 2001 From: Drew Ritter Date: Mon, 23 Mar 2026 14:27:40 -0700 Subject: [PATCH] docs: update step references and add manual test results (PRI-823) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update codex-tools.md to reference Step 1 (was Step 1.5) after the finishing skill reorder. Add manual Codex App test results table to the design spec — 4/5 passed, 1 N/A (sandbox doesn't block git writes in Local threads). Co-Authored-By: Claude Opus 4.6 (1M context) --- .../2026-03-23-codex-app-compatibility-design.md | 12 ++++++++++++ skills/using-superpowers/references/codex-tools.md | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/docs/superpowers/specs/2026-03-23-codex-app-compatibility-design.md b/docs/superpowers/specs/2026-03-23-codex-app-compatibility-design.md index c3fecc04..fbd5e159 100644 --- a/docs/superpowers/specs/2026-03-23-codex-app-compatibility-design.md +++ b/docs/superpowers/specs/2026-03-23-codex-app-compatibility-design.md @@ -237,6 +237,18 @@ If a third skill needs the same detection pattern, extract it into a shared `ref 4. Full lifecycle — detection → commit → finishing detection → correct behavior → cleanup 5. **Sandbox fallback in Local thread** — Start a Codex App **Local thread** (workspace-write sandbox). Prompt: "Use the superpowers skill `using-git-worktrees` to set up an isolated workspace for implementing a small change." Pre-check: `git checkout -b test-sandbox-check` should fail with `Operation not permitted`. Expected: the skill detects `GIT_DIR == GIT_COMMON` (normal repo), attempts `git worktree add -b`, hits Seatbelt denial, falls back to Step 0 "already in workspace" behavior — runs setup, baseline tests, reports ready from current directory. Pass: agent recovers gracefully without cryptic error messages. Fail: agent prints raw Seatbelt error, retries, or gives up with confusing output. +### Manual Test Results (2026-03-23) + +| Test | Result | Notes | +|------|--------|-------| +| 1. Detection in Worktree thread (workspace-write) | PASS | GIT_DIR != GIT_COMMON, BRANCH empty | +| 2. Detection in Worktree thread (Full access) | PASS | Same detection; Full access allows `git checkout -b` | +| 3. Finishing skill handoff format | PASS (after fix) | Initially FAILED — Step 1.5 was unreachable because Step 1 (test verification) halted first. Fixed by reordering: environment detection is now Step 1, test verification is Step 2. Path A skips tests entirely. | +| 4. Full lifecycle | PASS | Detection → commit → handoff payload → no cleanup attempt | +| 5. Sandbox fallback in Local thread | N/A | Local thread workspace-write sandbox does not block `git checkout -b`; Seatbelt restriction not triggered in current Codex App version | + +**Fix applied:** `c5d93ac` — moved environment detection before test verification in `finishing-a-development-branch/SKILL.md`. Step numbering changed: old Step 1.5 → new Step 1, old Step 1 → new Step 2, all downstream steps renumbered. + ### Regression - Existing Claude Code skill-triggering tests still pass diff --git a/skills/using-superpowers/references/codex-tools.md b/skills/using-superpowers/references/codex-tools.md index 1f8514fb..539b2b1c 100644 --- a/skills/using-superpowers/references/codex-tools.md +++ b/skills/using-superpowers/references/codex-tools.md @@ -85,7 +85,7 @@ BRANCH=$(git branch --show-current) - `BRANCH` empty → detached HEAD (cannot branch/push/PR from sandbox) See `using-git-worktrees` Step 0 and `finishing-a-development-branch` -Step 1.5 for how each skill uses these signals. +Step 1 for how each skill uses these signals. ## Codex App Finishing