rogee/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-04-25 11:09:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review feedback on architecture guidance

Browse Source 
- Define DONE_WITH_CONCERNS handling in SDD controller flow
- Make implementer action explicit when file grows beyond plan intent
- Reword writing-plans file size reasoning (avoid tooling-artifact language)
- Add decomposition awareness to code quality reviewer prompt
This commit is contained in:
Jesse Vincent
2026-02-08 12:20:39 -08:00
parent 8d996aa829
commit 21c7284d54
4 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
skills/subagent-driven-development/code-quality-reviewer-prompt.md
View File

@@ -17,4 +17,9 @@ Task tool (superpowers:code-reviewer):
DESCRIPTION: [task summary]
```
**In addition to standard code quality concerns, the reviewer should check:**
- Does each file have one clear responsibility with a well-defined interface?
- Are units decomposed so they can be understood and tested independently?
- Is the implementation following the file structure from the plan?
**Code reviewer returns:** Strengths, Issues (Critical/Important/Minor), Assessment