mirror of
https://github.com/obra/superpowers.git
synced 2026-04-26 03:29:06 +08:00
fix: address review feedback on architecture guidance
- Define DONE_WITH_CONCERNS handling in SDD controller flow - Make implementer action explicit when file grows beyond plan intent - Reword writing-plans file size reasoning (avoid tooling-artifact language) - Add decomposition awareness to code quality reviewer prompt
This commit is contained in:
@@ -23,7 +23,7 @@ Assume they are a skilled developer, but know almost nothing about our toolset o
|
||||
Before defining tasks, map out which files will be created or modified and what each one is responsible for. This is where decomposition decisions get locked in.
|
||||
|
||||
- Design units with clear boundaries and well-defined interfaces. Each file should have one clear responsibility.
|
||||
- You work best with files you can read in a single pass. Large files cause silent truncation, context degradation, and unreliable edits. Prefer smaller, focused files over large ones that do too much.
|
||||
- You reason best about code you can hold in context at once, and your edits are more reliable when files are focused. Prefer smaller, focused files over large ones that do too much.
|
||||
- Files that change together should live together. Split by responsibility, not by technical layer.
|
||||
- In existing codebases, follow established patterns. If the codebase uses large files, don't unilaterally restructure - but if a file you're modifying has grown unwieldy, including a split in the plan is reasonable.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user