diff --git a/skills/brainstorming/scripts/server.cjs b/skills/brainstorming/scripts/server.cjs index 79661a99..78bf7c37 100644 --- a/skills/brainstorming/scripts/server.cjs +++ b/skills/brainstorming/scripts/server.cjs @@ -124,7 +124,7 @@ function wrapInFrame(content) { function getNewestScreen() { const files = fs.readdirSync(CONTENT_DIR) - .filter(f => f.endsWith('.html')) + .filter(f => !f.startsWith('.') && f.endsWith('.html')) .map(f => { const fp = path.join(CONTENT_DIR, f); return { path: fp, mtime: fs.statSync(fp).mtime.getTime() }; @@ -152,9 +152,9 @@ function handleRequest(req, res) { res.writeHead(200, { 'Content-Type': 'text/html; charset=utf-8' }); res.end(html); } else if (req.method === 'GET' && req.url.startsWith('/files/')) { - const fileName = req.url.slice(7); - const filePath = path.join(CONTENT_DIR, path.basename(fileName)); - if (!fs.existsSync(filePath)) { + const fileName = path.basename(req.url.slice(7)); + const filePath = path.join(CONTENT_DIR, fileName); + if (fileName.startsWith('.') || !fs.existsSync(filePath)) { res.writeHead(404); res.end('Not found'); return; @@ -276,14 +276,14 @@ function startServer() { // macOS fs.watch reports 'rename' for both new files and overwrites, // so we can't rely on eventType alone. const knownFiles = new Set( - fs.readdirSync(CONTENT_DIR).filter(f => f.endsWith('.html')) + fs.readdirSync(CONTENT_DIR).filter(f => !f.startsWith('.') && f.endsWith('.html')) ); const server = http.createServer(handleRequest); server.on('upgrade', handleUpgrade); const watcher = fs.watch(CONTENT_DIR, (eventType, filename) => { - if (!filename || !filename.endsWith('.html')) return; + if (!filename || filename.startsWith('.') || !filename.endsWith('.html')) return; if (debounceTimers.has(filename)) clearTimeout(debounceTimers.get(filename)); debounceTimers.set(filename, setTimeout(() => { diff --git a/tests/brainstorm-server/server.test.js b/tests/brainstorm-server/server.test.js index 2cccf095..52b3ffad 100644 --- a/tests/brainstorm-server/server.test.js +++ b/tests/brainstorm-server/server.test.js @@ -179,6 +179,25 @@ async function runTests() { assert(!res.body.includes('"not"'), 'Should not serve JSON'); }); + await test('ignores macOS resource-fork dotfiles (._*.html) when serving', async () => { + // On macOS/ExFAT/SMB, the OS writes ._name.html sidecar files holding + // binary metadata. They end with .html but must never be served as a screen. + fs.writeFileSync(path.join(CONTENT_DIR, 'real-screen.html'), '