From 3128a2c3cda2a24af458afb918ba4f8e58063d9e Mon Sep 17 00:00:00 2001 From: sarbojitrana Date: Tue, 17 Mar 2026 19:44:46 +0530 Subject: [PATCH] fix : resolve ESM/CommonJS module confict in brainstorming server --- skills/brainstorming/scripts/{server.js => server.cjs} | 0 skills/brainstorming/scripts/start-server.sh | 4 ++-- tests/brainstorm-server/server.test.js | 2 +- tests/brainstorm-server/ws-protocol.test.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) rename skills/brainstorming/scripts/{server.js => server.cjs} (100%) diff --git a/skills/brainstorming/scripts/server.js b/skills/brainstorming/scripts/server.cjs similarity index 100% rename from skills/brainstorming/scripts/server.js rename to skills/brainstorming/scripts/server.cjs diff --git a/skills/brainstorming/scripts/start-server.sh b/skills/brainstorming/scripts/start-server.sh index 5c36ee18..a0ef2997 100755 --- a/skills/brainstorming/scripts/start-server.sh +++ b/skills/brainstorming/scripts/start-server.sh @@ -115,13 +115,13 @@ esac # Foreground mode for environments that reap detached/background processes. if [[ "$FOREGROUND" == "true" ]]; then echo "$$" > "$PID_FILE" - env BRAINSTORM_DIR="$SCREEN_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.js + env BRAINSTORM_DIR="$SCREEN_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.cjs exit $? fi # Start server, capturing output to log file # Use nohup to survive shell exit; disown to remove from job table -nohup env BRAINSTORM_DIR="$SCREEN_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.js > "$LOG_FILE" 2>&1 & +nohup env BRAINSTORM_DIR="$SCREEN_DIR" BRAINSTORM_HOST="$BIND_HOST" BRAINSTORM_URL_HOST="$URL_HOST" BRAINSTORM_OWNER_PID="$OWNER_PID" node server.cjs > "$LOG_FILE" 2>&1 & SERVER_PID=$! disown "$SERVER_PID" 2>/dev/null echo "$SERVER_PID" > "$PID_FILE" diff --git a/tests/brainstorm-server/server.test.js b/tests/brainstorm-server/server.test.js index 35a4ca55..d1077a60 100644 --- a/tests/brainstorm-server/server.test.js +++ b/tests/brainstorm-server/server.test.js @@ -15,7 +15,7 @@ const fs = require('fs'); const path = require('path'); const assert = require('assert'); -const SERVER_PATH = path.join(__dirname, '../../skills/brainstorming/scripts/server.js'); +const SERVER_PATH = path.join(__dirname, '../../skills/brainstorming/scripts/server.cjs'); const TEST_PORT = 3334; const TEST_DIR = '/tmp/brainstorm-test'; diff --git a/tests/brainstorm-server/ws-protocol.test.js b/tests/brainstorm-server/ws-protocol.test.js index ca505fa6..4f2540d7 100644 --- a/tests/brainstorm-server/ws-protocol.test.js +++ b/tests/brainstorm-server/ws-protocol.test.js @@ -16,7 +16,7 @@ const crypto = require('crypto'); const path = require('path'); // The module under test — will be the new zero-dep server file -const SERVER_PATH = path.join(__dirname, '../../skills/brainstorming/scripts/server.js'); +const SERVER_PATH = path.join(__dirname, '../../skills/brainstorming/scripts/server.cjs'); let ws; try {