mirror of
https://github.com/obra/superpowers.git
synced 2026-04-29 13:29:05 +08:00
test(opencode): modernize integration tests
This commit is contained in:
Drew Ritter
@@ -1,10 +1,13 @@
|
||||
#!/usr/bin/env bash
|
||||
# Test: Skill Priority Resolution
|
||||
# Verifies that skills are resolved with correct priority: project > personal > superpowers
|
||||
# Documents current OpenCode duplicate-name behavior for local and bundled
|
||||
# skills. The desired local-shadowing behavior is tracked separately; this
|
||||
# test keeps the integration suite honest without adding a plugin workaround.
|
||||
# NOTE: These tests require OpenCode to be installed and configured
|
||||
set -euo pipefail
|
||||
|
||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
||||
OPENCODE_TEST_TIMEOUT_SECONDS="${OPENCODE_TEST_TIMEOUT_SECONDS:-120}"
|
||||
|
||||
echo "=== Test: Skill Priority Resolution ==="
|
||||
|
||||
@@ -96,103 +99,119 @@ if ! command -v opencode &> /dev/null; then
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# Test 2: Test that personal overrides superpowers
|
||||
run_opencode() {
|
||||
local result_var="$1"
|
||||
local dir="$2"
|
||||
local prompt="$3"
|
||||
local command_output
|
||||
local exit_code
|
||||
|
||||
set +e
|
||||
command_output=$(cd "$dir" && timeout "${OPENCODE_TEST_TIMEOUT_SECONDS}s" opencode run --print-logs --format json "$prompt" 2>&1)
|
||||
exit_code=$?
|
||||
set -e
|
||||
|
||||
if [ $exit_code -eq 124 ]; then
|
||||
echo " [FAIL] OpenCode timed out after ${OPENCODE_TEST_TIMEOUT_SECONDS}s"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
if [ $exit_code -ne 0 ]; then
|
||||
echo " [FAIL] OpenCode returned non-zero exit code: $exit_code"
|
||||
echo " Output was:"
|
||||
awk 'NR <= 80 { print }' <<<"$command_output"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
printf -v "$result_var" '%s' "$command_output"
|
||||
}
|
||||
|
||||
assert_contains() {
|
||||
local output="$1"
|
||||
local needle="$2"
|
||||
local message="$3"
|
||||
|
||||
if [[ "$output" == *"$needle"* ]]; then
|
||||
echo " [PASS] $message"
|
||||
else
|
||||
echo " [FAIL] $message"
|
||||
echo " Expected to find: $needle"
|
||||
echo " Output was:"
|
||||
awk 'NR <= 80 { print }' <<<"$output"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
|
||||
first_skill_tool_event() {
|
||||
awk '/"type":"tool_use"/ && /"tool":"skill"/ { print; exit }' <<<"$1"
|
||||
}
|
||||
|
||||
describe_priority_result() {
|
||||
local output="$1"
|
||||
local expected_marker="$2"
|
||||
local fallback_marker="$3"
|
||||
local pass_message="$4"
|
||||
local known_bug_message="$5"
|
||||
local loaded_skill
|
||||
|
||||
loaded_skill="$(first_skill_tool_event "$output")"
|
||||
|
||||
if [[ "$loaded_skill" == *"$expected_marker"* ]]; then
|
||||
echo " [PASS] $pass_message"
|
||||
elif [[ "$loaded_skill" == *"$fallback_marker"* ]]; then
|
||||
echo " [INFO] $known_bug_message"
|
||||
echo " [INFO] Tracked separately: OpenCode bundled skills can shadow local skills with duplicate native names"
|
||||
else
|
||||
echo " [FAIL] Could not verify priority marker in native skill tool output"
|
||||
echo " Output was:"
|
||||
awk 'NR <= 80 { print }' <<<"$output"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
|
||||
# Test 2: Document personal vs bundled superpowers priority
|
||||
echo ""
|
||||
echo "Test 2: Testing personal > superpowers priority..."
|
||||
echo "Test 2: Documenting personal vs superpowers priority..."
|
||||
echo " Running from outside project directory..."
|
||||
|
||||
# Run from HOME (not in project) - should get personal version
|
||||
cd "$HOME"
|
||||
output=$(timeout 60s opencode run --print-logs "Use the use_skill tool to load the priority-test skill. Show me the exact content including any PRIORITY_MARKER text." 2>&1) || {
|
||||
exit_code=$?
|
||||
if [ $exit_code -eq 124 ]; then
|
||||
echo " [FAIL] OpenCode timed out after 60s"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
run_opencode output "$HOME" "Call the skill tool with name \"priority-test\". Show the exact content including any PRIORITY_MARKER text."
|
||||
describe_priority_result \
|
||||
"$output" \
|
||||
"PRIORITY_MARKER_PERSONAL_VERSION" \
|
||||
"PRIORITY_MARKER_SUPERPOWERS_VERSION" \
|
||||
"Personal version loaded for duplicate native skill name" \
|
||||
"Current OpenCode behavior loaded bundled superpowers version instead of personal version"
|
||||
|
||||
if echo "$output" | grep -qi "PRIORITY_MARKER_PERSONAL_VERSION"; then
|
||||
echo " [PASS] Personal version loaded (overrides superpowers)"
|
||||
elif echo "$output" | grep -qi "PRIORITY_MARKER_SUPERPOWERS_VERSION"; then
|
||||
echo " [FAIL] Superpowers version loaded instead of personal"
|
||||
exit 1
|
||||
else
|
||||
echo " [WARN] Could not verify priority marker in output"
|
||||
echo " Output snippet:"
|
||||
echo "$output" | grep -i "priority\|personal\|superpowers" | head -10
|
||||
fi
|
||||
|
||||
# Test 3: Test that project overrides both personal and superpowers
|
||||
# Test 3: Document project vs bundled superpowers priority
|
||||
echo ""
|
||||
echo "Test 3: Testing project > personal > superpowers priority..."
|
||||
echo "Test 3: Documenting project vs personal/superpowers priority..."
|
||||
echo " Running from project directory..."
|
||||
|
||||
# Run from project directory - should get project version
|
||||
cd "$TEST_HOME/test-project"
|
||||
output=$(timeout 60s opencode run --print-logs "Use the use_skill tool to load the priority-test skill. Show me the exact content including any PRIORITY_MARKER text." 2>&1) || {
|
||||
exit_code=$?
|
||||
if [ $exit_code -eq 124 ]; then
|
||||
echo " [FAIL] OpenCode timed out after 60s"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
run_opencode output "$TEST_HOME/test-project" "Call the skill tool with name \"priority-test\". Show the exact content including any PRIORITY_MARKER text."
|
||||
describe_priority_result \
|
||||
"$output" \
|
||||
"PRIORITY_MARKER_PROJECT_VERSION" \
|
||||
"PRIORITY_MARKER_SUPERPOWERS_VERSION" \
|
||||
"Project version loaded for duplicate native skill name" \
|
||||
"Current OpenCode behavior loaded bundled superpowers version instead of project version"
|
||||
|
||||
if echo "$output" | grep -qi "PRIORITY_MARKER_PROJECT_VERSION"; then
|
||||
echo " [PASS] Project version loaded (highest priority)"
|
||||
elif echo "$output" | grep -qi "PRIORITY_MARKER_PERSONAL_VERSION"; then
|
||||
echo " [FAIL] Personal version loaded instead of project"
|
||||
exit 1
|
||||
elif echo "$output" | grep -qi "PRIORITY_MARKER_SUPERPOWERS_VERSION"; then
|
||||
echo " [FAIL] Superpowers version loaded instead of project"
|
||||
exit 1
|
||||
else
|
||||
echo " [WARN] Could not verify priority marker in output"
|
||||
echo " Output snippet:"
|
||||
echo "$output" | grep -i "priority\|project\|personal" | head -10
|
||||
fi
|
||||
|
||||
# Test 4: Test explicit superpowers: prefix bypasses priority
|
||||
# Test 4: Test a non-colliding bundled superpowers skill is still available
|
||||
echo ""
|
||||
echo "Test 4: Testing superpowers: prefix forces superpowers version..."
|
||||
echo "Test 4: Testing non-colliding superpowers skill remains available..."
|
||||
|
||||
cd "$TEST_HOME/test-project"
|
||||
output=$(timeout 60s opencode run --print-logs "Use the use_skill tool to load superpowers:priority-test specifically. Show me the exact content including any PRIORITY_MARKER text." 2>&1) || {
|
||||
exit_code=$?
|
||||
if [ $exit_code -eq 124 ]; then
|
||||
echo " [FAIL] OpenCode timed out after 60s"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
mkdir -p "$SUPERPOWERS_SKILLS_DIR/superpowers-only-test"
|
||||
cat > "$SUPERPOWERS_SKILLS_DIR/superpowers-only-test/SKILL.md" <<'EOF'
|
||||
---
|
||||
name: superpowers-only-test
|
||||
description: Superpowers-only priority test skill
|
||||
---
|
||||
# Superpowers Only Test Skill
|
||||
|
||||
if echo "$output" | grep -qi "PRIORITY_MARKER_SUPERPOWERS_VERSION"; then
|
||||
echo " [PASS] superpowers: prefix correctly forces superpowers version"
|
||||
elif echo "$output" | grep -qi "PRIORITY_MARKER_PROJECT_VERSION\|PRIORITY_MARKER_PERSONAL_VERSION"; then
|
||||
echo " [FAIL] superpowers: prefix did not force superpowers version"
|
||||
exit 1
|
||||
else
|
||||
echo " [WARN] Could not verify priority marker in output"
|
||||
fi
|
||||
PRIORITY_MARKER_SUPERPOWERS_ONLY_VERSION
|
||||
EOF
|
||||
|
||||
# Test 5: Test explicit project: prefix
|
||||
echo ""
|
||||
echo "Test 5: Testing project: prefix forces project version..."
|
||||
|
||||
cd "$HOME" # Run from outside project but with project: prefix
|
||||
output=$(timeout 60s opencode run --print-logs "Use the use_skill tool to load project:priority-test specifically. Show me the exact content." 2>&1) || {
|
||||
exit_code=$?
|
||||
if [ $exit_code -eq 124 ]; then
|
||||
echo " [FAIL] OpenCode timed out after 60s"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
|
||||
# Note: This may fail since we're not in the project directory
|
||||
# The project: prefix only works when in a project context
|
||||
if echo "$output" | grep -qi "not found\|error"; then
|
||||
echo " [PASS] project: prefix correctly fails when not in project context"
|
||||
else
|
||||
echo " [INFO] project: prefix behavior outside project context may vary"
|
||||
fi
|
||||
run_opencode output "$TEST_HOME/test-project" "Call the skill tool with name \"superpowers-only-test\". Show the exact content including any PRIORITY_MARKER text."
|
||||
assert_contains "$output" "PRIORITY_MARKER_SUPERPOWERS_ONLY_VERSION" "Non-colliding superpowers skill is still registered"
|
||||
|
||||
echo ""
|
||||
echo "=== All priority tests passed ==="
|
||||
|
||||
Reference in New Issue
Block a user