fix: address code review issues in opencode support branch

- Fix test runner exiting early due to ((var++)) returning 1 with set -e
- Remove duplicate frontmatter stripping in superpowers-codex, use shared skillsCore.stripFrontmatter()
- Remove unused promptsDir/promptFile variables from opencode plugin
- Derive superpowers skills path from __dirname for better install flexibility
- Simplify test-skills-core.sh by removing failing ESM import attempt

tests/opencode/run-tests.sh

@@ -94,7 +94,7 @@ for test in "${tests[@]}"; do
 
     if [ ! -f "$test_path" ]; then
         echo "  [SKIP] Test file not found: $test"
-        ((skipped++))
+        skipped=$((skipped + 1))
         continue
     fi
 
@@ -111,13 +111,13 @@ for test in "${tests[@]}"; do
             duration=$((end_time - start_time))
             echo ""
             echo "  [PASS] $test (${duration}s)"
-            ((passed++))
+            passed=$((passed + 1))
         else
             end_time=$(date +%s)
             duration=$((end_time - start_time))
             echo ""
             echo "  [FAIL] $test (${duration}s)"
-            ((failed++))
+            failed=$((failed + 1))
         fi
     else
         # Capture output for non-verbose mode
@@ -125,7 +125,7 @@ for test in "${tests[@]}"; do
             end_time=$(date +%s)
             duration=$((end_time - start_time))
             echo "  [PASS] (${duration}s)"
-            ((passed++))
+            passed=$((passed + 1))
         else
             end_time=$(date +%s)
             duration=$((end_time - start_time))
@@ -133,7 +133,7 @@ for test in "${tests[@]}"; do
             echo ""
             echo "  Output:"
             echo "$output" | sed 's/^/    /'
-            ((failed++))
+            failed=$((failed + 1))
         fi
     fi
 

tests/opencode/test-skills-core.sh

@@ -30,17 +30,8 @@ description: A test skill for unit testing
 This is the content.
 EOF
 
-# Run Node.js test
-result=$(node --input-type=module <<'NODESCRIPT'
-import { extractFrontmatter } from '$HOME/.config/opencode/superpowers/lib/skills-core.js';
-const result = extractFrontmatter(process.env.TEST_HOME + '/test-skill/SKILL.md');
-console.log(JSON.stringify(result));
-NODESCRIPT
-) 2>&1 || true
-
-# Try alternative approach if module import fails
-if ! echo "$result" | grep -q "test-skill"; then
-    result=$(node -e "
+# Run Node.js test using inline function (avoids ESM path resolution issues in test env)
+result=$(node -e "
 const path = require('path');
 const fs = require('fs');
 
@@ -76,7 +67,6 @@ function extractFrontmatter(filePath) {
 const result = extractFrontmatter('$TEST_HOME/test-skill/SKILL.md');
 console.log(JSON.stringify(result));
 " 2>&1)
-fi
 
 if echo "$result" | grep -q '"name":"test-skill"'; then
     echo "  [PASS] extractFrontmatter parses name correctly"