mirror of
https://github.com/obra/superpowers.git
synced 2026-08-05 05:38:45 +08:00
fix(sdd): one Ruling: token everywhere, exhaustive finish roll-up
The breaker's two ledger formats wrote lowercase 'ruling' (parked findings, load-bearing adjudications), so the Finish section's collect-every-`Ruling:`-line step missed exactly the rulings made under the most pressure. Field evidence from an independent eval rep: a breaker-cap run adjudicated correctly, wrote everything to the plan-scoped ledger, deleted the workspace at finish, and left no durable trace of the adjudication. Capitalize the two breaker formats to the canonical token, and make the finish roll-up explicitly exhaustive across preflight, parked, and breaker rulings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -374,13 +374,13 @@ dispatching. Adjudicate each open finding yourself — you hold the plan and
|
||||
the cross-task context the reviewer lacks:
|
||||
|
||||
- **The reviewer is wrong, or the point is contestable:** park it —
|
||||
`Task <N>: parked — <finding> — ruling: <why the code stands>`. The final
|
||||
`Task <N>: parked — <finding> — Ruling: <why the code stands>`. The final
|
||||
review sees both sides.
|
||||
- **Real, but nothing downstream builds on it:** park it the same way, with
|
||||
a ruling that says it's real and deferred.
|
||||
- **Real and load-bearing** — a later task builds on it, or it reveals a
|
||||
plan defect: rule on the smallest change that unblocks the dependent work,
|
||||
ledger it as `Task <N>: ruling — <finding> — <what you decided and why>`,
|
||||
ledger it as `Task <N>: Ruling: <finding> — <what you decided and why>`,
|
||||
and carry it into the next task's dispatch. Parking a structural failure
|
||||
silently lets every dependent task build on it. Stop only when the defect
|
||||
leaves every path forward a guess.
|
||||
@@ -431,9 +431,11 @@ finishing-a-development-branch presents the options.
|
||||
|
||||
## Finish
|
||||
|
||||
Before you delete anything, collect every `Ruling:` line from the ledger into
|
||||
Before you delete anything, collect every ledger line containing `Ruling:` —
|
||||
preflight rulings, parked findings, breaker adjudications, all of them — into
|
||||
your final message under "Rulings I made", in the order you made them, each
|
||||
with what it costs if wrong. That list is the only place the decisions you
|
||||
with what it costs if wrong. The list is exhaustive: if the ledger holds a
|
||||
ruling, the list holds it. That list is the only place the decisions you
|
||||
took on your human partner's behalf reach them — they read it and rework
|
||||
whatever you got wrong. A ruling that dies with the workspace was a decision
|
||||
made in secret.
|
||||
|
||||
Reference in New Issue
Block a user