mirror of
https://github.com/obra/superpowers.git
synced 2026-06-11 13:19:05 +08:00
Forbid controllers pre-judging reviewer findings
A live eval run of sdd-quality-reviewer-catches-planted-defect caught the SDD controller fabricating a plan constraint and instructing the quality reviewer not to flag the planted DRY violation. The duplication shipped. Constructing Reviewer Prompts now bans suppression directives alongside open-ended broadening directives.
This commit is contained in:
@@ -141,6 +141,10 @@ final whole-branch review. When you fill a reviewer template:
|
||||
if useful" without a concrete, task-specific reason
|
||||
- Do not ask a reviewer to re-run tests the implementer already ran on the
|
||||
same code — the implementer's report carries the test evidence
|
||||
- Do not pre-judge findings for the reviewer — never instruct a reviewer to
|
||||
ignore or not flag a specific issue. If you believe a finding would be a
|
||||
false positive, let the reviewer raise it and adjudicate it in the review
|
||||
loop.
|
||||
|
||||
## Prompt Templates
|
||||
|
||||
|
||||
Reference in New Issue
Block a user