rogee/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-04-24 18:49:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs: tighten reviewer workflow guidance

Browse Source
This commit is contained in:
Jesse Vincent
2026-03-15 14:38:16 -07:00
parent 3188953b0c
commit 9a0887169a
9 changed files with 91 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
skills/brainstorming/SKILL.md
View File

@@ -119,9 +119,12 @@ digraph brainstorming {
**Spec Review Loop:**
After writing the spec document:
1. Dispatch spec-document-reviewer subagent (see spec-document-reviewer-prompt.md)
2. If Issues Found: fix, re-dispatch, repeat until Approved
3. If loop exceeds 5 iterations, surface to human for guidance
1. Dispatch spec-document-reviewer subagent (see spec-document-reviewer-prompt.md) with precisely crafted review context — never your session history
2. Use a fresh reviewer with clean context. Never reuse or resume a prior reviewer.
3. If the harness supports reviewer-specific model, profile, or effort controls, use the lightest reviewer configuration that can still do the review competently
4. Use long waits for reviewer verdicts. If the harness distinguishes timeout from failure, timeout means `no verdict yet`, not review failure.
5. If `ISSUES FOUND`: fix, re-dispatch, repeat until `APPROVED`
6. If loop exceeds 5 iterations, surface to human for guidance
**User Review Gate:**
After the spec review loop passes, ask the user to review the written spec before proceeding:

12
skills/brainstorming/spec-document-reviewer-prompt.md
View File

@@ -10,6 +10,8 @@ Use this template when dispatching a spec document reviewer subagent.
Task tool (general-purpose):
description: "Review spec document"
prompt: |
REVIEW ONLY. DO NOT EDIT FILES. DO NOT COMMIT. DO NOT IMPLEMENT FIXES.
You are a spec document reviewer. Verify this spec is complete and ready for planning.
**Spec to review:** [SPEC_FILE_PATH]
@@ -36,15 +38,15 @@ Task tool (general-purpose):
## Output Format
## Spec Review
First line must be exactly: `APPROVED` or `ISSUES FOUND`
**Status:** ✅ Approved | ❌ Issues Found
## Issues (if any)
**Issues (if any):**
- [Section X]: [specific issue] - [why it matters]
**Recommendations (advisory):**
## Recommendations (advisory)
- [suggestions that don't block approval]
```
**Reviewer returns:** Status, Issues (if any), Recommendations
**Reviewer returns:** Verdict, Issues (if any), Recommendations