docs: tighten reviewer workflow guidance

This commit is contained in:
Jesse Vincent
2026-03-15 14:38:16 -07:00
parent 3188953b0c
commit 9a0887169a
9 changed files with 91 additions and 26 deletions

View File

@@ -116,11 +116,11 @@ After completing each chunk of the plan:
1. Dispatch plan-document-reviewer subagent (see plan-document-reviewer-prompt.md) with precisely crafted review context — never your session history. This keeps the reviewer focused on the plan, not your thought process.
- Provide: chunk content, path to spec document
2. If ❌ Issues Found:
2. If `ISSUES FOUND`:
- Fix the issues in the chunk
- Re-dispatch reviewer for that chunk
- Repeat until ✅ Approved
3. If ✅ Approved: proceed to next chunk (or execution handoff if last chunk)
- Repeat until `APPROVED`
3. If `APPROVED`: proceed to next chunk (or execution handoff if last chunk)
**Chunk boundaries:** Use `## Chunk N: <name>` headings to delimit chunks. Each chunk should be ≤1000 lines and logically self-contained.
@@ -128,6 +128,9 @@ After completing each chunk of the plan:
- Same agent that wrote the plan fixes it (preserves context)
- If loop exceeds 5 iterations, surface to human for guidance
- Reviewers are advisory - explain disagreements if you believe feedback is incorrect
- Plan reviewers follow the same isolation rules as code reviewers: fresh reviewer, clean context, no transcript history, no reuse
- If the harness supports reviewer-specific model, profile, or effort controls, use the lightest reviewer configuration that can still review the chunk competently
- Use long waits for reviewer verdicts; if the harness distinguishes timeout from failure, timeout means `no verdict yet`, not review failure
## Execution Handoff

View File

@@ -10,6 +10,8 @@ Use this template when dispatching a plan document reviewer subagent.
Task tool (general-purpose):
description: "Review plan chunk N"
prompt: |
REVIEW ONLY. DO NOT EDIT FILES. DO NOT COMMIT. DO NOT IMPLEMENT FIXES.
You are a plan document reviewer. Verify this plan chunk is complete and ready for implementation.
**Plan chunk to review:** [PLAN_FILE_PATH] - Chunk N only
@@ -38,15 +40,15 @@ Task tool (general-purpose):
## Output Format
## Plan Review - Chunk N
First line: `APPROVED` or `ISSUES FOUND`
**Status:** Approved | Issues Found
## Issues (if any)
**Issues (if any):**
- [Task X, Step Y]: [specific issue] - [why it matters]
**Recommendations (advisory):**
## Recommendations (advisory)
- [suggestions that don't block approval]
```
**Reviewer returns:** Status, Issues (if any), Recommendations
**Reviewer returns:** Verdict, Issues (if any), Recommendations