mirror of
https://github.com/obra/superpowers.git
synced 2026-07-23 18:54:07 +08:00
feat(codex): SDD dispatch routing, fork hygiene, and final-review wave termination
Codex SDD runs at frontier tiers spin out: subagents inherit the session's model and effort, review seats find real-but-endless defects every round, and the final whole-branch review has no reachable termination state. Field forensics across multiple real sessions traced the mechanism: spawn_agent's fork_turns defaults to "all" (full-context forks that also refuse model overrides), omitted model/effort params inherit the frontier parent, and dispatch rules loaded at session start do not survive context compaction — a compacted controller reverts to inheritance exactly when the session is longest and most expensive. Three coordinated changes: - codex-tools.md: every SDD spawn sets fork_turns "none" plus explicit model/reasoning_effort when the schema supports them (Codex 0.145+), with an inheritance warning for older builds; reviewer tier never exceeds implementer tier and fix rounds never get effort bumps. - task-brief/review-package print a dispatch tuple with their output (review-package grows --role for re-review/final-review), putting the routing values in front of the controller at the moment of dispatch — reprinted every round, so they survive compaction by construction. - SKILL.md: the final-review wave closing is policy, not a verdict — one fix dispatch, one scoped re-review, residuals adjudicated to the ledger; one-off review procedures never become standing; Model Selection defers to platform role tables where one exists. Validated live: a previously spun-out 14-task run (8h, 6 tasks, died mid-loop) re-executed to completion under these changes — bounded fix loops, single-cycle final review, ~20 consecutive correctly-routed dispatches across two compactions. Reviewer-tier matrix (125 cells) showed no calibration cost: clean-diff approvals and planted-defect recall are identical across tiers. Eval scenarios to follow before any upstream submission. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -20,6 +20,8 @@ if [ "${1:-}" = "--role" ]; then
|
||||
shift 2
|
||||
fi
|
||||
|
||||
# Model/effort values are mirrored in using-superpowers/references/codex-tools.md
|
||||
# (they track Codex's spawn_agent allowlist) — update both together.
|
||||
case "$role" in
|
||||
task-review) hint_role=task-reviewer; hint_effort=high ;;
|
||||
re-review) hint_role=scoped-re-reviewer; hint_effort=medium ;;
|
||||
|
||||
@@ -42,4 +42,6 @@ echo "wrote ${out}: $(wc -l < "$out" | tr -d ' ') lines"
|
||||
# The dispatch hint rides this output because the controller reads it
|
||||
# immediately before spawning the implementer; skill text loaded at session
|
||||
# start does not survive context compaction, but this line reprints per task.
|
||||
# Model/effort values are mirrored in using-superpowers/references/codex-tools.md
|
||||
# (they track Codex's spawn_agent allowlist) — update both together.
|
||||
echo "dispatch (codex spawn_agent): role=implementer fork_turns=none model=gpt-5.6-terra reasoning_effort=high"
|
||||
|
||||
Reference in New Issue
Block a user