rogee/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-06-12 21:59:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add review-package script; close fix-dispatch test gap

Browse Source 
scripts/review-package generates the reviewer's input deterministically:
commit list, stat summary, and net diff with -U10 context, written to a
file from an explicit BASE. Live runs showed controllers improvising
'git diff HEAD~1..HEAD', which silently truncates multi-commit tasks,
and svelte's five fix dispatches shipped without re-running any tests —
fix dispatches now explicitly carry the implementer's
re-run-and-report contract.
This commit is contained in:
Jesse Vincent
2026-06-10 08:51:16 -07:00
parent 2434ef7f35
commit d4dbf44162
3 changed files with 60 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
skills/subagent-driven-development/task-reviewer-prompt.md
View File

@@ -30,9 +30,10 @@ Subagent (general-purpose):
**Head:** [HEAD_SHA]
**Diff file:** [DIFF_FILE]
Read the diff file once — that single Read is your view of the change.
Do not re-run git commands or re-read the files it already shows. If
the diff file is missing, fetch the diff yourself:
Read the diff file once — it contains the commit list, a stat summary,
and the full diff with surrounding context, and it is your view of the
change. Do not re-run git commands or re-read the files it already
shows. If the diff file is missing, fetch the diff yourself:
`git diff --stat [BASE_SHA]..[HEAD_SHA]` and `git diff [BASE_SHA]..[HEAD_SHA]`.
Only read files in this diff. Do not crawl the broader codebase. Inspect
code outside the diff only to evaluate a concrete risk you can name — and
@@ -152,9 +153,9 @@ Subagent (general-purpose):
- `[DESCRIPTION]` — what the implementer reports they built
- `[BASE_SHA]` — commit before this task
- `[HEAD_SHA]` — current commit
- `[DIFF_FILE]` — REQUIRED: the path the controller wrote the diff to
(`git diff BASE..HEAD > /tmp/sdd-task-N.diff`, redirected so it never
enters the controller's context)
- `[DIFF_FILE]` — REQUIRED: the path the controller wrote the review
package to (`scripts/review-package BASE HEAD /tmp/sdd-task-N.diff`,
redirected so it never enters the controller's context)
**Reviewer returns:** Spec Compliance verdict (✅/❌/⚠️), Strengths, Issues
(Critical/Important/Minor), Task quality verdict