rogee/superpowers
1
0
Fork 0
mirror of https://github.com/obra/superpowers.git synced 2026-06-11 21:29:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Align windows-lifecycle test with current brainstorm server layout

Browse Source 
The test had drifted behind three server implementation changes and no
longer ran against the actual server:

- Server entrypoint renamed from server.js to server.cjs; the test still
  invoked node on server.js and failed with MODULE_NOT_FOUND.
- Server state moved to a state/ subdirectory (state/server-info,
  state/server.pid); the test still waited on .server-info and wrote
  .server.pid at the session root.
- Owner-PID startup validation now keeps the server running when the
  owner PID is dead at startup: it logs owner-pid-invalid, disables
  owner monitoring, and falls back to the idle timeout. The test still
  expected the server to self-terminate within 60s of a dead-at-startup
  owner.

Update file/path references to match the current server, and rewrite
the dead-at-startup test to assert the current behavior: server
survives, log contains owner-pid-invalid, log does not contain a
spurious "owner process exited" line.

Verified locally: 9 passed, 0 failed, 3 skipped (Windows-only).
This commit is contained in:
Jesse Vincent
2026-05-23 16:36:45 -07:00
parent e1d3f71e0d
commit eef50b96f0
1 changed files with 40 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests/brainstorm-server/windows-lifecycle.test.sh
View File

@@ -1,9 +1,11 @@
#!/usr/bin/env bash #!/usr/bin/env bash
# Windows lifecycle tests for the brainstorm server. # Windows lifecycle tests for the brainstorm server.
# #
# Verifies that the brainstorm server survives the 60-second lifecycle # Verifies brainstorm server lifecycle behavior, including:
# check on Windows, where OWNER_PID monitoring is disabled because the # - Windows/MSYS2 foreground mode and empty OWNER_PID handling
# MSYS2 PID namespace is invisible to Node.js. # - Server survival past the 60-second lifecycle check window
# - Dead-at-startup OWNER_PID validation (logged, monitoring disabled)
# - Clean stop-server.sh shutdown
# #
# Requirements: # Requirements:
# - Node.js in PATH # - Node.js in PATH
@@ -20,7 +22,7 @@ SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
REPO_ROOT="${SUPERPOWERS_ROOT:-$(cd "$SCRIPT_DIR/../.." && pwd)}" REPO_ROOT="${SUPERPOWERS_ROOT:-$(cd "$SCRIPT_DIR/../.." && pwd)}"
START_SCRIPT="$REPO_ROOT/skills/brainstorming/scripts/start-server.sh" START_SCRIPT="$REPO_ROOT/skills/brainstorming/scripts/start-server.sh"
STOP_SCRIPT="$REPO_ROOT/skills/brainstorming/scripts/stop-server.sh" STOP_SCRIPT="$REPO_ROOT/skills/brainstorming/scripts/stop-server.sh"
SERVER_JS="$REPO_ROOT/skills/brainstorming/scripts/server.js" SERVER_SCRIPT="$REPO_ROOT/skills/brainstorming/scripts/server.cjs"
TEST_DIR="${TMPDIR:-/tmp}/brainstorm-win-test-$$" TEST_DIR="${TMPDIR:-/tmp}/brainstorm-win-test-$$"
@@ -64,7 +66,7 @@ skip() {
wait_for_server_info() { wait_for_server_info() {
local dir="$1" local dir="$1"
for _ in $(seq 1 50); do for _ in $(seq 1 50); do
if [[ -f "$dir/.server-info" ]]; then if [[ -f "$dir/state/server-info" ]]; then
return 0 return 0
fi fi
sleep 0.1 sleep 0.1
@@ -73,9 +75,9 @@ wait_for_server_info() {
} }
get_port_from_info() { get_port_from_info() {
# Read the port from .server-info. Use grep/sed instead of Node.js # Read the port from state/server-info. Use grep/sed instead of Node.js
# to avoid MSYS2-to-Windows path translation issues. # to avoid MSYS2-to-Windows path translation issues.
grep -o '"port":[0-9]*' "$1/.server-info" | head -1 | sed 's/"port"://' grep -o '"port":[0-9]*' "$1/state/server-info" | head -1 | sed 's/"port"://'
} }
http_check() { http_check() {
@@ -214,11 +216,11 @@ BRAINSTORM_HOST="127.0.0.1" \
BRAINSTORM_URL_HOST="localhost" \ BRAINSTORM_URL_HOST="localhost" \
BRAINSTORM_OWNER_PID="" \ BRAINSTORM_OWNER_PID="" \
BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \ BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \
node "$SERVER_JS" > "$TEST_DIR/survival/.server.log" 2>&1 & node "$SERVER_SCRIPT" > "$TEST_DIR/survival/.server.log" 2>&1 &
SERVER_PID=$! SERVER_PID=$!
if ! wait_for_server_info "$TEST_DIR/survival"; then if ! wait_for_server_info "$TEST_DIR/survival"; then
fail "Server starts successfully" "Server did not write .server-info within 5 seconds" fail "Server starts successfully" "Server did not write state/server-info within 5 seconds"
kill "$SERVER_PID" 2>/dev/null || true kill "$SERVER_PID" 2>/dev/null || true
SERVER_PID="" SERVER_PID=""
else else
@@ -254,10 +256,15 @@ else
SERVER_PID="" SERVER_PID=""
fi fi
# ========== Test 5: Bad OWNER_PID causes shutdown (control) ========== # ========== Test 5: Dead-at-startup OWNER_PID is logged but does not kill the server ==========
#
# The server validates BRAINSTORM_OWNER_PID at startup. If it's already dead,
# the PID resolution was wrong (common on WSL, Tailscale SSH, cross-user
# scenarios). The server logs 'owner-pid-invalid', disables owner monitoring,
# and continues running. The idle timeout becomes the only shutdown trigger.
echo "" echo ""
echo "--- Control: Bad OWNER_PID causes shutdown ---" echo "--- Dead-at-startup OWNER_PID: server survives, logs owner-pid-invalid ---"
mkdir -p "$TEST_DIR/control" mkdir -p "$TEST_DIR/control"
@@ -272,33 +279,41 @@ BRAINSTORM_HOST="127.0.0.1" \
BRAINSTORM_URL_HOST="localhost" \ BRAINSTORM_URL_HOST="localhost" \
BRAINSTORM_OWNER_PID="$BAD_PID" \ BRAINSTORM_OWNER_PID="$BAD_PID" \
BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \ BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \
node "$SERVER_JS" > "$TEST_DIR/control/.server.log" 2>&1 & node "$SERVER_SCRIPT" > "$TEST_DIR/control/.server.log" 2>&1 &
CONTROL_PID=$! CONTROL_PID=$!
if ! wait_for_server_info "$TEST_DIR/control"; then if ! wait_for_server_info "$TEST_DIR/control"; then
fail "Control server starts" "Server did not write .server-info within 5 seconds" fail "Control server starts" "Server did not write state/server-info within 5 seconds"
kill "$CONTROL_PID" 2>/dev/null || true kill "$CONTROL_PID" 2>/dev/null || true
CONTROL_PID="" CONTROL_PID=""
else else
pass "Control server starts with bad OWNER_PID=$BAD_PID" pass "Control server starts with dead-at-startup OWNER_PID=$BAD_PID"
echo " Waiting ~75s for lifecycle check to kill server..." echo " Waiting ~75s to verify server survives past lifecycle check..."
sleep 75 sleep 75
if kill -0 "$CONTROL_PID" 2>/dev/null; then if kill -0 "$CONTROL_PID" 2>/dev/null; then
fail "Control server self-terminates with bad OWNER_PID" \ pass "Server survives with dead-at-startup OWNER_PID (owner monitoring disabled)"
"Server is still alive (expected it to die)"
kill "$CONTROL_PID" 2>/dev/null || true
else else
pass "Control server self-terminates with bad OWNER_PID" fail "Server survives with dead-at-startup OWNER_PID" \
"Server died unexpectedly. Log tail: $(tail -5 "$TEST_DIR/control/.server.log" 2>/dev/null)"
fi
if grep -q "owner-pid-invalid" "$TEST_DIR/control/.server.log" 2>/dev/null; then
pass "Server logs 'owner-pid-invalid' for dead-at-startup PID"
else
fail "Server logs 'owner-pid-invalid' for dead-at-startup PID" \
"Log tail: $(tail -5 "$TEST_DIR/control/.server.log" 2>/dev/null)"
fi fi
if grep -q "owner process exited" "$TEST_DIR/control/.server.log" 2>/dev/null; then if grep -q "owner process exited" "$TEST_DIR/control/.server.log" 2>/dev/null; then
pass "Control server logs 'owner process exited'" fail "No spurious 'owner process exited' log" \
"Found 'owner process exited' but owner monitoring should be disabled"
else else
fail "Control server logs 'owner process exited'" \ pass "No spurious 'owner process exited' log"
"Log tail: $(tail -5 "$TEST_DIR/control/.server.log" 2>/dev/null)"
fi fi
kill "$CONTROL_PID" 2>/dev/null || true
fi fi
wait "$CONTROL_PID" 2>/dev/null || true wait "$CONTROL_PID" 2>/dev/null || true
@@ -309,16 +324,16 @@ CONTROL_PID=""
echo "" echo ""
echo "--- Clean Shutdown ---" echo "--- Clean Shutdown ---"
mkdir -p "$TEST_DIR/stop-test" mkdir -p "$TEST_DIR/stop-test/state"
BRAINSTORM_DIR="$TEST_DIR/stop-test" \ BRAINSTORM_DIR="$TEST_DIR/stop-test" \
BRAINSTORM_HOST="127.0.0.1" \ BRAINSTORM_HOST="127.0.0.1" \
BRAINSTORM_URL_HOST="localhost" \ BRAINSTORM_URL_HOST="localhost" \
BRAINSTORM_OWNER_PID="" \ BRAINSTORM_OWNER_PID="" \
BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \ BRAINSTORM_PORT=$((49152 + RANDOM % 16383)) \
node "$SERVER_JS" > "$TEST_DIR/stop-test/.server.log" 2>&1 & node "$SERVER_SCRIPT" > "$TEST_DIR/stop-test/.server.log" 2>&1 &
STOP_TEST_PID=$! STOP_TEST_PID=$!
echo "$STOP_TEST_PID" > "$TEST_DIR/stop-test/.server.pid" echo "$STOP_TEST_PID" > "$TEST_DIR/stop-test/state/server.pid"
if ! wait_for_server_info "$TEST_DIR/stop-test"; then if ! wait_for_server_info "$TEST_DIR/stop-test"; then
fail "Stop-test server starts" "Server did not start" fail "Stop-test server starts" "Server did not start"