Compare commits

..

5 Commits

Author SHA1 Message Date
Drew Ritter
2d446f0610 fix: update stale references and restore silence safety net (PRI-974)
Post-inversion cleanup:

- executing-plans, subagent-driven-development: update Integration
  description from "Ensures isolated workspace" to "Detects workspace
  environment and offers worktree isolation on request"
- codex-tools.md: update step references (Step 0→1, Step 1→2)
- using-git-worktrees Step 2: restore "silence → ask once more" instead
  of "silence → work in place" to preserve safety net for confused users

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 17:21:51 -07:00
Drew Ritter
ce1341222c fix: invert worktree skill default to work-in-place, eliminating Step 0.5 (PRI-974)
Agents consistently skipped Step 0.5 (consent gate) because fractional
numbering signals "optional afterthought" and the prose-only step was
invisible to code-block anchoring. The fix inverts the structural
gravity: the default path now works in place, and worktree creation
is an off-ramp requiring explicit user request.

- Renumber to clean integers: Step 1 (detect) → 2 (offer) → 3 (create) → 4 (setup) → 5 (verify)
- Step 2 defaults to Step 4 (in-place); Step 3 only on explicit user ask
- Step 2 includes a code block so agents register it during execution
- Add "creating without being asked" to Common Mistakes
- Add anti-inference red flag: consent from task/plan/skill invocation doesn't count

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 10:18:16 -07:00
Drew Ritter
2079ee7f90 fix: promote consent to own Step 0.5 with structural enforcement (PRI-974)
Drill benchmark showed 0/4 consent compliance across both Claude Code
and Codex. Root cause: consent was buried inline in Step 0's conditional
branch. Agents anchor on the next bash command and skip prose.

Fix: promote consent to its own numbered section with imperative framing
("REQUIRED STOP", "Do NOT proceed without an answer") and exact output
template. Also adds explicit "no" path — users who want to work directly
on their current branch skip to Step 3 with no worktree creation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-07 16:48:51 -07:00
Drew Ritter
cebcda7d68 feat: add multi-repo worktree guidance (#710) 2026-04-07 10:48:28 -07:00
Drew Ritter
c1c5547ff9 fix: replace hardcoded /Users/jesse with generic placeholders (#858) 2026-04-07 10:48:28 -07:00
3 changed files with 25 additions and 27 deletions

View File

@@ -249,13 +249,11 @@ Report with branch state:
- On a branch: "Already in isolated workspace at `<path>` on branch `<name>`." - On a branch: "Already in isolated workspace at `<path>` on branch `<name>`."
- Detached HEAD: "Already in isolated workspace at `<path>` (detached HEAD, externally managed). Branch creation needed at finish time." - Detached HEAD: "Already in isolated workspace at `<path>` (detached HEAD, externally managed). Branch creation needed at finish time."
**If `GIT_DIR == GIT_COMMON` (or in a submodule):** You are in a normal repo checkout. **If `GIT_DIR == GIT_COMMON` (or in a submodule):** You are in a normal repo checkout. Ask for consent before creating a workspace:
Has the user already indicated their worktree preference in your instructions? If not, ask for consent before creating a worktree: > "Would you like me to set up an isolated worktree? This protects your current branch from changes. (y/n)"
> "Would you like me to set up an isolated worktree? It protects your current branch from changes." If yes, proceed to Step 1. If no, work in place — skip to Step 3 with no worktree.
Honor any existing declared preference without asking. If the user declines consent, work in place and skip to Step 3.
## Step 1: Create Isolated Workspace ## Step 1: Create Isolated Workspace
@@ -289,7 +287,7 @@ Follow this priority order:
``` ```
If found, use it (backward compatibility with legacy global path). If found, use it (backward compatibility with legacy global path).
3. **Check your instructions for a worktree directory preference.** If specified, use it without asking. 3. **Check your project's agent instruction file** (CLAUDE.md, GEMINI.md, AGENTS.md, .cursorrules, or equivalent) for a worktree directory preference. If specified, use it without asking.
4. **Default to `.worktrees/`.** 4. **Default to `.worktrees/`.**

View File

@@ -48,9 +48,7 @@ echo "Current branch: $BRANCH"
echo "Repository: $(basename "$(git rev-parse --show-toplevel)")" echo "Repository: $(basename "$(git rev-parse --show-toplevel)")"
``` ```
**Check the user's most recent message first.** If they already asked for a worktree, named the worktree skill, or asked for an isolated workspace in the message that invoked you, that IS the explicit ask — proceed directly to Step 3 without re-prompting. Tell the user their options, then **wait for a reply**:
Otherwise, tell the user their options and **wait for a reply**:
> "You're on `<branch>` in `<repo>`. I can set up an isolated worktree, or we can work directly here. What do you prefer?" > "You're on `<branch>` in `<repo>`. I can set up an isolated worktree, or we can work directly here. What do you prefer?"
@@ -68,13 +66,15 @@ The default is always Step 4. Step 3 requires an explicit "yes, create a worktre
You have two mechanisms. Try them in this order. You have two mechanisms. Try them in this order.
### 3a. Native Worktree Tools (preferred) ### 3a. Native Worktree Tools (preferred — STOP HERE if available)
Do you already have a way to create a worktree? It might be a tool with a name like `EnterWorktree`, `WorktreeCreate`, a `/worktree` command, or a `--worktree` flag. If you do, use it and skip to Step 4. Check your available tools — do you have `EnterWorktree`, `WorktreeCreate`, a `/worktree` command, or a `--worktree` flag? **If YES: use it now and skip to Step 4.**
Native tools handle directory placement, branch creation, and cleanup automatically. Using `git worktree add` when you have a native tool creates phantom state your harness can't see or manage. Native tools handle directory placement, branch creation, and cleanup automatically. Using `git worktree add` when you have a native tool creates phantom state your harness can't see or manage worktrees it didn't create, and cleanup becomes impossible.
Only proceed to Step 3b if you have no native worktree tool available. **Even if `.worktrees/` already exists, even under time pressure, even if `git worktree add` feels faster — use your native tool.** There are no exceptions.
**Only proceed to Step 3b if you have confirmed you have NO native worktree/isolation tool.**
### 3b. Git Worktree Fallback ### 3b. Git Worktree Fallback
@@ -82,25 +82,25 @@ Only proceed to Step 3b if you have no native worktree tool available.
#### Directory Selection #### Directory Selection
Follow this priority order. Explicit user preference always beats observed filesystem state. Follow this priority order:
1. **Check your instructions for a declared worktree directory preference.** If the user has already specified one, use it without asking. 1. **Check existing directories:**
2. **Check for an existing project-local worktree directory:**
```bash ```bash
ls -d .worktrees 2>/dev/null # Preferred (hidden) ls -d .worktrees 2>/dev/null # Preferred (hidden)
ls -d worktrees 2>/dev/null # Alternative ls -d worktrees 2>/dev/null # Alternative
``` ```
If found, use it. If both exist, `.worktrees` wins. If found, use that directory. If both exist, `.worktrees` wins.
3. **Check for an existing global directory:** 2. **Check for existing global directory:**
```bash ```bash
project=$(basename "$(git rev-parse --show-toplevel)") project=$(basename "$(git rev-parse --show-toplevel)")
ls -d ~/.config/superpowers/worktrees/$project 2>/dev/null ls -d ~/.config/superpowers/worktrees/$project 2>/dev/null
``` ```
If found, use it (backward compatibility with legacy global path). If found, use it (backward compatibility with legacy global path).
4. **If there is no other guidance available**, default to `.worktrees/` at the project root. 3. **Check your project's agent instruction file** (CLAUDE.md, GEMINI.md, AGENTS.md, .cursorrules, or equivalent) for a worktree directory preference. If specified, use it without asking.
4. **Default to `.worktrees/`.**
#### Safety Verification (project-local directories only) #### Safety Verification (project-local directories only)
@@ -129,7 +129,7 @@ git worktree add "$path" -b "$BRANCH_NAME"
cd "$path" cd "$path"
``` ```
**Sandbox fallback:** If `git worktree add` fails with a permission error (sandbox denial), tell the user the sandbox blocked worktree creation and you're working in the current directory instead. Then run setup and baseline tests in place. **Sandbox fallback:** If `git worktree add` fails with a permission error (sandbox denial), treat this as a restricted environment. Skip creation, run setup and baseline tests in the current directory, report accordingly.
## Step 4: Project Setup ## Step 4: Project Setup
@@ -199,7 +199,7 @@ Ready to implement <feature-name>
| Tests fail during baseline | Report failures + ask | | Tests fail during baseline | Report failures + ask |
| No package.json/Cargo.toml | Skip dependency install | | No package.json/Cargo.toml | Skip dependency install |
| User gives no worktree preference | Work in place (Step 2 default) | | User gives no worktree preference | Work in place (Step 2 default) |
| Plan touches multiple repos | Offer a matching worktree per repo, same branch name | | Plan touches multiple repos | Offer worktree per repo (same Step 1→2→3 flow, matching branch names) |
## Common Mistakes ## Common Mistakes
@@ -243,7 +243,7 @@ Ready to implement <feature-name>
- Create worktree without verifying it's ignored (project-local) - Create worktree without verifying it's ignored (project-local)
- Skip baseline test verification - Skip baseline test verification
- Proceed with failing tests without asking - Proceed with failing tests without asking
- Infer worktree consent from the task description or plan — only an explicit user request counts - Infer worktree consent from the task description, plan, or skill invocation — only an explicit user reply counts
**Always:** **Always:**
- Run Step 1 detection first - Run Step 1 detection first
@@ -258,9 +258,9 @@ Ready to implement <feature-name>
## Integration ## Integration
**Called by:** **Called by:**
- **subagent-driven-development** - Calls this to detect the workspace and optionally set up worktree isolation on request - **subagent-driven-development** - Ensures isolated workspace (creates one or verifies existing)
- **executing-plans** - Calls this to detect the workspace and optionally set up worktree isolation on request - **executing-plans** - Ensures isolated workspace (creates one or verifies existing)
- Any skill that may use worktree isolation - Any skill needing isolated workspace
**Pairs with:** **Pairs with:**
- **finishing-a-development-branch** - REQUIRED for cleanup after work complete - **finishing-a-development-branch** - REQUIRED for cleanup after work complete

View File

@@ -13,7 +13,7 @@ Assume they are a skilled developer, but know almost nothing about our toolset o
**Announce at start:** "I'm using the writing-plans skill to create the implementation plan." **Announce at start:** "I'm using the writing-plans skill to create the implementation plan."
**Context:** If working in an isolated worktree, it should have been created via the `superpowers:using-git-worktrees` skill at execution time. **Context:** If working in an isolated worktree, it should have been created via the using-git-worktrees skill at execution time.
**Save plans to:** `docs/superpowers/plans/YYYY-MM-DD-<feature-name>.md` **Save plans to:** `docs/superpowers/plans/YYYY-MM-DD-<feature-name>.md`
- (User preferences for plan location override this default) - (User preferences for plan location override this default)