mirror of
https://github.com/obra/superpowers.git
synced 2026-07-25 19:54:02 +08:00
Compare commits
4 Commits
docs/codex
...
exp/contro
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
20d56c8a0e | ||
|
|
3bd7388b7d | ||
|
|
2711c26358 | ||
|
|
3472c5aecb |
@@ -9,7 +9,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"source": "./",
|
"source": "./",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"displayName": "Superpowers",
|
"displayName": "Superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "An agentic skills framework and software development methodology.",
|
"description": "An agentic skills framework and software development methodology.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -1,38 +1,5 @@
|
|||||||
# Superpowers Release Notes
|
# Superpowers Release Notes
|
||||||
|
|
||||||
## v6.2.0 (2026-07-23)
|
|
||||||
|
|
||||||
### Subagent-Driven Development
|
|
||||||
|
|
||||||
Two structural changes to how SDD tracks progress and closes out review findings, both developed against live eval campaigns.
|
|
||||||
|
|
||||||
- **The workspace is now plan-scoped.** `.superpowers/sdd/` had no plan identity and no end-of-life: a follow-up plan in the same working tree could read the previous plan's ledger as its own progress (observed in the wild, with multiple contamination rounds and ad-hoc workarounds). `sdd-workspace` now requires the plan file and resolves a per-plan directory, `.superpowers/sdd/<plan-basename>/`; `task-brief` and `review-package` write into their plan's directory (`review-package` gains the plan file as its first argument); the ledger names its plan on its first line; and the workspace is deleted once the final review is clean — git history is the durable record. Baseline evals showed controllers already refused foreign ledgers, but at a cost of 6–13 tool calls of cross-plan git forensics per resume; plan-scoping makes the answer structural instead. (25/25 baseline and GREEN eval runs documented in `docs/specs/` and `docs/plans/`.)
|
|
||||||
- **The review-fix loop resumes the implementer.** The lifecycle restructure gives fix rounds resume-the-implementer semantics instead of fresh dispatches, adds a scoped re-review prompt (`re-review-prompt.md`) so the re-reviewer checks the fixes rather than re-reading the whole task, and installs a five-round circuit breaker with controller adjudication when it trips. SKILL.md reorganizes by lifecycle, and its Red Flags convert to the house rationalization-table form.
|
|
||||||
|
|
||||||
### Skills
|
|
||||||
|
|
||||||
A branch-wide compression campaign: recap sections, social proof, and benefits-selling prose aimed at a reader who has already invoked the skill are gone, with every load-bearing argument folded into a rationalization-table row or moved to its point of use. Each cut was micro-tested with subagent probes, and the one cut that measurably degraded behavior was reworked rather than shipped.
|
|
||||||
|
|
||||||
- **`testing-anti-patterns.md` is now `writing-good-tests.md`.** The TDD reference doc is rebuilt as a positive catalog — six rules that lead with the GOOD example — and absorbs a falsifiability discipline: name the production change that would fail the test, derive expectations independently of the code under test, and a closing mutation check. It closes two holes by name: the string-presence trap (grep-style tests on scripts, skills, and prompts counterfeit falsifiability — the observable is behavior, never text) and the change-detector trap (a constant assertion can fail and still protect nothing), each with a hard stop in the gate function. Trivial code and human prose earn no test; the trigger broadens from "adding mocks" to any test writing.
|
|
||||||
- **TDD's "Why Order Matters" rebuttals survive as rationalization rows.** Deleting the section outright measurably degraded test-first behavior under "just write it, tests after" pressure (control 8/10 → treatment 5/10, corroborated on Claude and Codex), so each prose rebuttal now lives in its Common Rationalizations row — the section is gone but the arguments fire where an agent hits them mid-rationalization.
|
|
||||||
- **`finishing-a-development-branch` no longer offers to discard your work.** The completion menu dates from when throwing away branches was routine; "Discard this work" next to "Merge" advertised destroying finished, passing work. Discard survives as an explicit-request-only path with the same typed-confirmation ritual. The same pass made PR creation forge-agnostic (your forge's CLI or the URL printed on push, not a blessed list of tools) and fixed a real bug: the worktree path was recomputed after cleanup had already changed directory, so provenance checks never matched and cleanup silently no-oped.
|
|
||||||
- **Recap and persuasion prose removed across the library.** `brainstorming`, `systematic-debugging`, `dispatching-parallel-agents`, `verification-before-completion`, `executing-plans`, `subagent-driven-development`, `requesting-code-review`, `receiving-code-review`, `using-git-worktrees`, `writing-plans`, and `writing-skills` all drop their Bottom Line / Key Principles / Real-World Impact / Advantages sections; `using-git-worktrees` and `finishing-a-development-branch` convert their guard sections to the house Excuse/Reality rationalization table.
|
|
||||||
|
|
||||||
### Windows
|
|
||||||
|
|
||||||
- **The SessionStart hook now dispatches via Git Bash.** The hook's command string starts with a quoted path, which broke both shells Claude Code might hand it to: PowerShell parsed the quoted string as an expression and died with a parser error (#1751), and cmd.exe's quote-stripping rule truncated the command when the profile path contained a metacharacter like `(` (#1918) — either way the bootstrap silently never loaded. The hook now declares `shell: "bash"`, which Claude Code ≥ 2.1.81 resolves to Git for Windows directly, and which surfaces an actionable install prompt when Git Bash is missing. Older Claude Code versions ignore the unknown key and behave as before. Verified end-to-end on Linux, Windows 11 with Git Bash under a hostile path, and Windows 11 without Git Bash.
|
|
||||||
|
|
||||||
### Harness Support
|
|
||||||
|
|
||||||
- **Gemini CLI support is restored.** The v6.1.0 removal (on the news that Google had EOLed the Gemini CLI) was premature; the install docs and the `gemini-tools.md` tool-mapping reference are back while permanent removal gets a proper evaluation. (#1959)
|
|
||||||
|
|
||||||
### Fixes
|
|
||||||
|
|
||||||
- **`find-polluter.sh` actually finds test files now.** `find .` emits `./`-prefixed paths, so the documented `-path "src/**/*.test.ts"` pattern matched nothing — and `wc -l` on empty input then reported "Found 1". Fixed the prefix mismatch (#2008, #2011), plus two follow-ups: a caller-supplied `./`-prefixed pattern no longer double-prefixes into a never-matching form, and `**/` is also matched collapsed so tests directly under the base directory (`src/top.test.ts` vs `src/**/*.test.ts`) aren't silently skipped. The script gains a deterministic test suite.
|
|
||||||
- **The Codex package script works beyond macOS.** Deterministic-metadata tar flags were bsdtar-only spellings, staged file modes depended on two umasks canceling out, and the test's timestamp assertion parsed bsdtar's column layout in a US timezone. GNU tar now gets equivalent flags producing byte-identical headers, modes are pinned canonical, and the test asserts mtime via `tarfile`.
|
|
||||||
- **SDD's skill test no longer flakes.** The file's worst case exceeded the runner's per-file ceiling (raised to 900s), and the assert helpers matched free-form model prose case-sensitively; matching is now case-insensitive and `assert_order` dumps output on failure so the next flake is diagnosable.
|
|
||||||
- **Docs and test cleanup after the v6.1.0 reference pruning.** Dead links to the deleted `claude-code-tools.md`/`copilot-tools.md` are replaced with the current architecture (#1969), a dangling `#subagent-support` anchor in the Antigravity reference is dropped (#2010), and the Antigravity/Pi mapping tests assert only the surviving harness-specific mappings — scoped to the table so they fail again if it's deleted.
|
|
||||||
|
|
||||||
## v6.1.1 (2026-07-02)
|
## v6.1.1 (2026-07-02)
|
||||||
|
|
||||||
### Codex
|
### Codex
|
||||||
|
|||||||
@@ -1,85 +0,0 @@
|
|||||||
# Releasing to the Codex portal
|
|
||||||
|
|
||||||
How to package a Superpowers release as the zip artifact OpenAI's Codex
|
|
||||||
plugin portal expects, and what to check before handing it over.
|
|
||||||
|
|
||||||
This is distinct from the older flow of syncing files into a fork of
|
|
||||||
`openai/plugins` and opening a PR, which
|
|
||||||
`scripts/sync-to-codex-plugin.sh` still implements — see the distribution
|
|
||||||
table in [porting-to-a-new-harness.md](porting-to-a-new-harness.md). The portal
|
|
||||||
artifact is a standalone, rootless archive: `.codex-plugin/`, `assets/`,
|
|
||||||
`skills/`, `README.md`, `LICENSE`, and `CODE_OF_CONDUCT.md` sit at the
|
|
||||||
archive root. Hooks, tests, docs, scripts, and other harnesses' manifests
|
|
||||||
are deliberately not shipped.
|
|
||||||
|
|
||||||
## Prerequisite: the OpenAI metadata source
|
|
||||||
|
|
||||||
Each packaged skill must carry `skills/<name>/agents/openai.yaml`. That
|
|
||||||
metadata is OpenAI-owned — it does not live in this repo — so the packaging
|
|
||||||
script seeds it from a prior official package. By default it looks for, in
|
|
||||||
order:
|
|
||||||
|
|
||||||
1. `../_tmp/sup-codex-packaging/superpowers/` (an unpacked package)
|
|
||||||
2. `../_tmp/sup-codex-packaging/superpowers.zip`
|
|
||||||
3. `../_tmp/sup-codex-packaging/superpowers.tar.gz`
|
|
||||||
|
|
||||||
or pass `--metadata-source <dir|.zip|.tar.gz>` explicitly.
|
|
||||||
|
|
||||||
If you have no prior package on disk, extract one from `openai/plugins`
|
|
||||||
(the upstream repo still carries the plugin, including the metadata):
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# from a clone with an `upstream` remote pointing at github.com/openai/plugins
|
|
||||||
git fetch upstream
|
|
||||||
mkdir -p ../_tmp/sup-codex-packaging/superpowers
|
|
||||||
git archive upstream/main -- plugins/superpowers |
|
|
||||||
tar -x --strip-components 2 -C ../_tmp/sup-codex-packaging/superpowers
|
|
||||||
```
|
|
||||||
|
|
||||||
**New skills fail the build.** The script requires one `openai.yaml` per
|
|
||||||
skill directory; otherwise it prints `Missing OpenAI agent metadata for
|
|
||||||
skill: <name>` for each gap and dies with `metadata source is incomplete`.
|
|
||||||
If a release adds a skill, there is no metadata for it yet;
|
|
||||||
you need an updated official package (or metadata added upstream in
|
|
||||||
`openai/plugins`) before you can package. Don't hand-invent the yaml.
|
|
||||||
|
|
||||||
## Build the archive
|
|
||||||
|
|
||||||
From a clean working tree, package the release tag:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
scripts/package-codex-plugin.sh --ref vX.X.X
|
|
||||||
```
|
|
||||||
|
|
||||||
The script reads the version from `.codex-plugin/plugin.json` (bumped by
|
|
||||||
`scripts/bump-version.sh`, so it matches the release tag), stages the tree
|
|
||||||
from the git ref — never from the working copy — and writes
|
|
||||||
`../_tmp/sup-codex-packaging/superpowers-VERSION.zip`, printing entry
|
|
||||||
count, skill count, and a SHA-256. Timestamps and file order are pinned so
|
|
||||||
rebuilding the same ref reproduces the same archive.
|
|
||||||
|
|
||||||
Useful flags: `--output PATH`, `--format zip|tar.gz`, `--allow-dirty`
|
|
||||||
(archive still comes from `--ref`), `--keep-stage` (inspect the staging
|
|
||||||
dir). `--help` has the full list.
|
|
||||||
|
|
||||||
## Verify
|
|
||||||
|
|
||||||
The script already refuses archives containing source-only paths and
|
|
||||||
mismatched metadata counts. Sanity-check the result anyway:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
unzip -Z1 ../_tmp/sup-codex-packaging/superpowers-X.X.X.zip | head
|
|
||||||
unzip -Z1 ../_tmp/sup-codex-packaging/superpowers-X.X.X.zip | grep -c 'agents/openai.yaml'
|
|
||||||
unzip -p ../_tmp/sup-codex-packaging/superpowers-X.X.X.zip .codex-plugin/plugin.json | jq -r .version
|
|
||||||
```
|
|
||||||
|
|
||||||
Expect: rootless top-level entries (`.codex-plugin/`, `assets/`,
|
|
||||||
`skills/`), one `openai.yaml` per skill, and the release version.
|
|
||||||
|
|
||||||
The script itself is covered by `tests/codex/test-package-codex-plugin.sh`.
|
|
||||||
|
|
||||||
## Upload
|
|
||||||
|
|
||||||
Upload the zip through OpenAI's Codex plugin portal. This is a manual step
|
|
||||||
outside this repo; record the SHA-256 the script printed so the uploaded
|
|
||||||
artifact can be matched to the build.
|
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"contextFileName": "GEMINI.md"
|
"contextFileName": "GEMINI.md"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"main": ".opencode/plugins/superpowers.js",
|
"main": ".opencode/plugins/superpowers.js",
|
||||||
|
|||||||
@@ -133,6 +133,10 @@ a ledger file, not only in todos.
|
|||||||
plan's progress: leave it in place and start your own, fresh.
|
plan's progress: leave it in place and start your own, fresh.
|
||||||
- Create the ledger with its identity as the first line:
|
- Create the ledger with its identity as the first line:
|
||||||
`# SDD ledger — plan: <plan file path>`.
|
`# SDD ledger — plan: <plan file path>`.
|
||||||
|
- During that same Setup read, copy the plan's Global Constraints section
|
||||||
|
verbatim into `<workspace>/constraints.md`. The global-constraints block
|
||||||
|
you hand reviewers pastes from that file — the plan itself stays closed
|
||||||
|
after Setup, even across compaction.
|
||||||
- The ledger is your recovery map: the commits it names exist in git even
|
- The ledger is your recovery map: the commits it names exist in git even
|
||||||
when your context no longer remembers creating them. After compaction,
|
when your context no longer remembers creating them. After compaction,
|
||||||
trust the ledger and `git log` over your own recollection.
|
trust the ledger and `git log` over your own recollection.
|
||||||
@@ -140,7 +144,11 @@ a ledger file, not only in todos.
|
|||||||
that happens, recover from `git log`.
|
that happens, recover from `git log`.
|
||||||
|
|
||||||
Read the plan once, note its context and Global Constraints, and create a
|
Read the plan once, note its context and Global Constraints, and create a
|
||||||
todo per task.
|
todo per task. That is the plan's one full read for the whole session:
|
||||||
|
after Setup, the ledger and `scripts/task-brief` extracts are your working
|
||||||
|
memory — re-reading the plan or spec late in the run (to "double-check"
|
||||||
|
completion, to rebuild the final-review dispatch) re-buys context you
|
||||||
|
already paid for and is forbidden.
|
||||||
|
|
||||||
Before dispatching Task 1, scan the plan once for conflicts:
|
Before dispatching Task 1, scan the plan once for conflicts:
|
||||||
|
|
||||||
@@ -195,7 +203,10 @@ that implementer. Single-file mechanical fixes also take the cheapest tier.
|
|||||||
|
|
||||||
Everything you paste into a dispatch prompt — and everything a subagent
|
Everything you paste into a dispatch prompt — and everything a subagent
|
||||||
prints back — stays resident in your context for the rest of the session
|
prints back — stays resident in your context for the rest of the session
|
||||||
and is re-read on every later turn. Hand artifacts over as files.
|
and is re-read on every later turn. Hand artifacts over as files. The same
|
||||||
|
tax applies to your own words: checkpoint in one short line, keep
|
||||||
|
bookkeeping in the ledger file, and never paste back into the conversation
|
||||||
|
what a file already holds.
|
||||||
|
|
||||||
### 1. Dispatch the implementer
|
### 1. Dispatch the implementer
|
||||||
|
|
||||||
@@ -399,7 +410,10 @@ on the most capable available model (see Model Selection), using
|
|||||||
superpowers:requesting-code-review's
|
superpowers:requesting-code-review's
|
||||||
[code-reviewer.md](../requesting-code-review/code-reviewer.md). Point it at
|
[code-reviewer.md](../requesting-code-review/code-reviewer.md). Point it at
|
||||||
the ledger's deferred-minor and parked lines so it can triage which must be
|
the ledger's deferred-minor and parked lines so it can triage which must be
|
||||||
fixed before merge.
|
fixed before merge. Build that dispatch from the ledger alone — the
|
||||||
|
completion lines, parked rulings, and deferred minors are the whole-run
|
||||||
|
summary; do not re-read the plan, the spec, or per-task reports to
|
||||||
|
reconstruct what the ledger already states.
|
||||||
|
|
||||||
If the final whole-branch review returns findings, dispatch ONE fix subagent
|
If the final whole-branch review returns findings, dispatch ONE fix subagent
|
||||||
with the complete findings list — not one fixer per finding.
|
with the complete findings list — not one fixer per finding.
|
||||||
|
|||||||
@@ -18,18 +18,9 @@ echo "🔍 Searching for test that creates: $POLLUTION_CHECK"
|
|||||||
echo "Test pattern: $TEST_PATTERN"
|
echo "Test pattern: $TEST_PATTERN"
|
||||||
echo ""
|
echo ""
|
||||||
|
|
||||||
# Get list of test files (find . emits ./-prefixed paths, so accept the
|
# Get list of test files
|
||||||
# pattern written with or without a leading ./)
|
TEST_FILES=$(find . -path "$TEST_PATTERN" | sort)
|
||||||
TEST_PATTERN="${TEST_PATTERN#./}"
|
TOTAL=$(echo "$TEST_FILES" | wc -l | tr -d ' ')
|
||||||
# find -path can't match '**/' against zero directory levels, so a pattern
|
|
||||||
# like src/**/*.test.ts would skip src/top.test.ts; also try the pattern
|
|
||||||
# with '**/' collapsed to cover files directly under the base directory.
|
|
||||||
TEST_FILES=$(find . \( -path "./$TEST_PATTERN" -o -path "./${TEST_PATTERN//\*\*\//}" \) | sort -u)
|
|
||||||
if [ -z "$TEST_FILES" ]; then
|
|
||||||
TOTAL=0
|
|
||||||
else
|
|
||||||
TOTAL=$(printf '%s\n' "$TEST_FILES" | wc -l | tr -d ' ')
|
|
||||||
fi
|
|
||||||
|
|
||||||
echo "Found $TOTAL test files"
|
echo "Found $TOTAL test files"
|
||||||
echo ""
|
echo ""
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ Skills speak in actions ("dispatch a subagent", "create a todo", "read a file").
|
|||||||
|
|
||||||
| Action skills request | Antigravity CLI equivalent |
|
| Action skills request | Antigravity CLI equivalent |
|
||||||
|----------------------|----------------------|
|
|----------------------|----------------------|
|
||||||
| Dispatch a subagent (`Subagent (general-purpose):` template) | `invoke_subagent` with a built-in `TypeName` — `self` for full-capability work, `research` for read-only |
|
| Dispatch a subagent (`Subagent (general-purpose):` template) | `invoke_subagent` with a built-in `TypeName` — `self` for full-capability work, `research` for read-only (see [Subagent support](#subagent-support)) |
|
||||||
| Task tracking ("create a todo", "mark complete") | a **task artifact** — `write_to_file` with `IsArtifact: true` and `ArtifactType: "task"` (see [Task tracking](#task-tracking)). **Not** `manage_task`, which manages background processes. |
|
| Task tracking ("create a todo", "mark complete") | a **task artifact** — `write_to_file` with `IsArtifact: true` and `ArtifactType: "task"` (see [Task tracking](#task-tracking)). **Not** `manage_task`, which manages background processes. |
|
||||||
|
|
||||||
## Task tracking
|
## Task tracking
|
||||||
|
|||||||
@@ -71,7 +71,11 @@ independently testable deliverable.
|
|||||||
[The spec's project-wide requirements — version floors, dependency limits,
|
[The spec's project-wide requirements — version floors, dependency limits,
|
||||||
naming and copy rules, platform requirements — one line each, with exact
|
naming and copy rules, platform requirements — one line each, with exact
|
||||||
values copied verbatim from the spec. Every task's requirements implicitly
|
values copied verbatim from the spec. Every task's requirements implicitly
|
||||||
include this section.]
|
include this section. Three things may never enter it: cosmetic absolutes
|
||||||
|
on every commit (a fixed trailer or byline the work does not need), your
|
||||||
|
own identity or model name promoted into a rule, and environment
|
||||||
|
constraints (versions, platforms, paths) you have not verified against the
|
||||||
|
environment the plan will execute in.]
|
||||||
|
|
||||||
---
|
---
|
||||||
```
|
```
|
||||||
@@ -125,6 +129,8 @@ git commit -m "feat: add specific feature"
|
|||||||
```
|
```
|
||||||
````
|
````
|
||||||
|
|
||||||
|
Commit messages describe the change. Never mandate session boilerplate — trailers, bylines, model names — as a per-commit rule; what your session stamps on its commits is not a requirement of the work.
|
||||||
|
|
||||||
## No Placeholders
|
## No Placeholders
|
||||||
|
|
||||||
Every step must contain the actual content an engineer needs. These are **plan failures** — never write them:
|
Every step must contain the actual content an engineer needs. These are **plan failures** — never write them:
|
||||||
@@ -145,6 +151,8 @@ After writing the complete plan, look at the spec with fresh eyes and check the
|
|||||||
|
|
||||||
**3. Type consistency:** Do the types, method signatures, and property names you used in later tasks match what you defined in earlier tasks? A function called `clearLayers()` in Task 3 but `clearFullLayers()` in Task 7 is a bug.
|
**3. Type consistency:** Do the types, method signatures, and property names you used in later tasks match what you defined in earlier tasks? A function called `clearLayers()` in Task 3 but `clearFullLayers()` in Task 7 is a bug.
|
||||||
|
|
||||||
|
**4. Constraint hygiene:** Does any Global Constraint mandate a per-commit cosmetic absolute, name the authoring model or session, or assert an environment fact (version floor, platform, path) you did not verify? Cut or verify it.
|
||||||
|
|
||||||
If you find issues, fix them inline. No need to re-review — just fix and move on. If you find a spec requirement with no task, add the task.
|
If you find issues, fix them inline. No need to re-review — just fix and move on. If you find a spec requirement with no task, add the task.
|
||||||
|
|
||||||
## Execution Handoff
|
## Execution Handoff
|
||||||
|
|||||||
@@ -1,90 +0,0 @@
|
|||||||
#!/usr/bin/env bash
|
|
||||||
set -euo pipefail
|
|
||||||
|
|
||||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
||||||
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
|
|
||||||
SCRIPT_UNDER_TEST="$REPO_ROOT/skills/systematic-debugging/find-polluter.sh"
|
|
||||||
|
|
||||||
FAILURES=0
|
|
||||||
TEST_ROOT="$(mktemp -d)"
|
|
||||||
|
|
||||||
cleanup() {
|
|
||||||
rm -rf "$TEST_ROOT"
|
|
||||||
}
|
|
||||||
trap cleanup EXIT
|
|
||||||
|
|
||||||
pass() {
|
|
||||||
echo " [PASS] $1"
|
|
||||||
}
|
|
||||||
|
|
||||||
fail() {
|
|
||||||
echo " [FAIL] $1"
|
|
||||||
FAILURES=$((FAILURES + 1))
|
|
||||||
}
|
|
||||||
|
|
||||||
assert_contains() {
|
|
||||||
local haystack="$1"
|
|
||||||
local needle="$2"
|
|
||||||
local description="$3"
|
|
||||||
|
|
||||||
if printf '%s' "$haystack" | grep -Fq -- "$needle"; then
|
|
||||||
pass "$description"
|
|
||||||
else
|
|
||||||
fail "$description (expected output to contain: $needle)"
|
|
||||||
fi
|
|
||||||
}
|
|
||||||
|
|
||||||
# Toy project: one top-level test, one nested test. A stubbed `npm` on PATH
|
|
||||||
# creates the pollution marker whenever any test runs, so the first test file
|
|
||||||
# executed is always identified as the polluter.
|
|
||||||
setup_project() {
|
|
||||||
PROJECT="$TEST_ROOT/project"
|
|
||||||
rm -rf "$PROJECT"
|
|
||||||
mkdir -p "$PROJECT/src/feature" "$PROJECT/bin"
|
|
||||||
echo "test('top')" > "$PROJECT/src/top.test.ts"
|
|
||||||
echo "test('nested')" > "$PROJECT/src/feature/nested.test.ts"
|
|
||||||
cat > "$PROJECT/bin/npm" <<'EOF'
|
|
||||||
#!/usr/bin/env bash
|
|
||||||
touch pollution.marker
|
|
||||||
EOF
|
|
||||||
chmod +x "$PROJECT/bin/npm"
|
|
||||||
}
|
|
||||||
|
|
||||||
# run_polluter <pattern> — runs the script in the toy project with the stub
|
|
||||||
# npm first on PATH; captures combined output, never aborts on exit code.
|
|
||||||
run_polluter() {
|
|
||||||
local pattern="$1"
|
|
||||||
rm -f "$PROJECT/pollution.marker"
|
|
||||||
(
|
|
||||||
cd "$PROJECT"
|
|
||||||
PATH="$PROJECT/bin:$PATH" "$SCRIPT_UNDER_TEST" 'pollution.marker' "$pattern" 2>&1
|
|
||||||
) || true
|
|
||||||
}
|
|
||||||
|
|
||||||
echo "Test: documented pattern finds nested test files (issue #2008)"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "FOUND POLLUTER" "documented pattern runs tests and detects pollution"
|
|
||||||
|
|
||||||
echo "Test: documented pattern also finds top-level test files"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 2 test files" "src/**/*.test.ts matches src/top.test.ts and src/feature/nested.test.ts"
|
|
||||||
|
|
||||||
echo "Test: ./-prefixed pattern matches the same files"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter './src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 2 test files" "leading ./ on the pattern is accepted"
|
|
||||||
|
|
||||||
echo "Test: non-matching pattern reports an honest zero"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'nomatch/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 0 test files" "empty result counts as 0, not 1"
|
|
||||||
assert_contains "$OUTPUT" "No polluter found" "empty result exits via the clean path"
|
|
||||||
|
|
||||||
echo ""
|
|
||||||
if [ "$FAILURES" -gt 0 ]; then
|
|
||||||
echo "$FAILURES test(s) failed"
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
echo "All tests passed"
|
|
||||||
Reference in New Issue
Block a user