mirror of
https://github.com/obra/superpowers.git
synced 2026-07-07 02:09:04 +08:00
Compare commits
14 Commits
finishing-
...
codex/fix-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
019e6b6d08 | ||
|
|
8e19a0c3e6 | ||
|
|
6770bfbcc5 | ||
|
|
3a1d8fe8d7 | ||
|
|
b15ef6ebbe | ||
|
|
8554b7215c | ||
|
|
9c9b9bd7c8 | ||
|
|
98b080041d | ||
|
|
4000288dac | ||
|
|
6be431b772 | ||
|
|
1f0c76e0b0 | ||
|
|
321c8cd24c | ||
|
|
bfa3e4137a | ||
|
|
a17aaaef3a |
@@ -9,7 +9,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"source": "./",
|
"source": "./",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"displayName": "Superpowers",
|
"displayName": "Superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"description": "An agentic skills framework and software development methodology.",
|
"description": "An agentic skills framework and software development methodology.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -1,16 +1,5 @@
|
|||||||
# Superpowers Release Notes
|
# Superpowers Release Notes
|
||||||
|
|
||||||
## v6.1.1 (2026-07-02)
|
|
||||||
|
|
||||||
### Codex
|
|
||||||
|
|
||||||
- **Codex no longer re-registers the Claude SessionStart hook.** v6.1.0 removed the Codex hook config and its manifest `hooks` pointer, meaning to stop Codex from installing a SessionStart hook — but with no `hooks` field, Codex fell back to auto-discovering `hooks/hooks.json`, the Claude Code SessionStart hook that the marketplace ships from the repo root, and re-registered it along with its install-time trust prompt. The Codex manifest now declares an explicit empty hooks object (`hooks: {}`), which Codex reads as "no hooks" instead of reaching the auto-discovery fallback. An absent field, `[]`, and an empty inline list all collapse back to the fallback, so the value has to be exactly `{}`.
|
|
||||||
- **Removed orphaned Codex session-start dead code.** `hooks/session-start-codex` had no caller once the Codex hook config was deleted, so it and its redundant test cases are gone. The worked shell-hook example in `docs/porting-to-a-new-harness.md` moves from Codex — now native skill discovery with no session-start hook — to Cursor, a live shell-hook harness, and the stale `hooks-codex.json` pointer in `docs/windows/polyglot-hooks.md` is corrected. The Codex plugin category is also fixed to "Developer Tools".
|
|
||||||
|
|
||||||
### Packaging
|
|
||||||
|
|
||||||
- **New `package-codex-plugin.sh` for building the Codex portal package.** A maintainer script produces a deterministic Codex "portal" archive — `.zip` by default, `tar.gz` on request — that normalizes entry timestamps, preserves executable modes, verifies every packaged skill ships its OpenAI metadata, includes the app and composer icons, and refuses to run against a dirty worktree. The packaged manifest keeps the source `hooks: {}` object so a portal-installed plugin avoids the same SessionStart auto-discovery, and the script can rebuild a byte-identical archive from a saved metadata source. Covered by a new test suite.
|
|
||||||
|
|
||||||
## v6.1.0 (2026-06-30)
|
## v6.1.0 (2026-06-30)
|
||||||
|
|
||||||
### Lower Per-Session Token Cost
|
### Lower Per-Session Token Cost
|
||||||
|
|||||||
@@ -90,7 +90,7 @@ every session, with no per-session opt-in by your human partner.** This is the
|
|||||||
one non-negotiable capability. It can take any form:
|
one non-negotiable capability. It can take any form:
|
||||||
|
|
||||||
- a **hook/event system** that runs a shell command at session start and reads
|
- a **hook/event system** that runs a shell command at session start and reads
|
||||||
its stdout (Claude Code, Cursor, Copilot CLI), or
|
its stdout (Claude Code, Codex, Cursor, Copilot CLI), or
|
||||||
- an **in-process plugin/extension** with a session-start or message lifecycle
|
- an **in-process plugin/extension** with a session-start or message lifecycle
|
||||||
callback that can mutate the message array (OpenCode, pi), or
|
callback that can mutate the message array (OpenCode, pi), or
|
||||||
- an **instructions-file** convention where the harness loads a context file that
|
- an **instructions-file** convention where the harness loads a context file that
|
||||||
@@ -227,20 +227,18 @@ you may **not** do is bridge a gap by editing the user's global config.
|
|||||||
The harness has a hook system that runs a shell command at session start and
|
The harness has a hook system that runs a shell command at session start and
|
||||||
reads JSON from its stdout. The configured command runs `run-hook.cmd`, a
|
reads JSON from its stdout. The configured command runs `run-hook.cmd`, a
|
||||||
polyglot wrapper that just locates bash and dispatches the named script; the
|
polyglot wrapper that just locates bash and dispatches the named script; the
|
||||||
script (`hooks/session-start`, or a harness-specific variant) is what reads
|
script (`hooks/session-start`, or a harness-specific variant like
|
||||||
`using-superpowers/SKILL.md` and prints a JSON object whose **field name and
|
`hooks/session-start-codex`) is what reads `using-superpowers/SKILL.md` and
|
||||||
nesting differ per harness**.
|
prints a JSON object whose **field name and nesting differ per harness**.
|
||||||
|
|
||||||
- Reference: `hooks/session-start`, `hooks/run-hook.cmd`, and the per-harness
|
- Reference: `hooks/session-start` (and `hooks/session-start-codex`),
|
||||||
hook config `hooks/hooks.json` (Claude Code) and `hooks/hooks-cursor.json`
|
`hooks/run-hook.cmd`, and the per-harness hook config `hooks/hooks.json`
|
||||||
|
(Claude Code), `hooks/hooks-codex.json` (Codex), `hooks/hooks-cursor.json`
|
||||||
(Cursor).
|
(Cursor).
|
||||||
- Manifests: `.cursor-plugin/plugin.json` is the Shape A manifest example that
|
- Manifests: `.codex-plugin/plugin.json`, `.cursor-plugin/plugin.json` point the
|
||||||
points the harness at `./skills/` and the right `hooks-*.json`. Claude Code's
|
harness at `./skills/` and the right `hooks-*.json`. (Claude Code's
|
||||||
`.claude-plugin/plugin.json` sets neither field — it auto-discovers `skills/`
|
`.claude-plugin/plugin.json` sets neither field — it auto-discovers `skills/`
|
||||||
and `hooks/hooks.json` by convention. Do **not** copy Codex's
|
and `hooks/hooks.json` by convention.)
|
||||||
`.codex-plugin/plugin.json` for Shape A: it declares an empty `hooks` object
|
|
||||||
specifically to suppress Codex's `hooks/hooks.json` auto-discovery, because
|
|
||||||
Codex surfaces skills natively and runs no session-start hook.
|
|
||||||
|
|
||||||
> **A hook *system* is not a session-start *event*.** A harness can have a
|
> **A hook *system* is not a session-start *event*.** A harness can have a
|
||||||
> `hooks.json` mechanism — and even contain the literal string `SessionStart` in
|
> `hooks.json` mechanism — and even contain the literal string `SessionStart` in
|
||||||
@@ -289,7 +287,7 @@ part of the installed extension** — never substitute "edit the user's global
|
|||||||
|
|
||||||
| If the harness… | Use shape | Copy from |
|
| If the harness… | Use shape | Copy from |
|
||||||
|---|---|---|
|
|---|---|---|
|
||||||
| runs a shell command at session start and reads its stdout | A (shell-hook) | Cursor (`hooks/session-start` + `hooks/hooks-cursor.json` + `.cursor-plugin/`) |
|
| runs a shell command at session start and reads its stdout | A (shell-hook) | Codex (`hooks/session-start-codex` + `hooks/hooks-codex.json` + `.codex-plugin/`) |
|
||||||
| is a JS/TS plugin host with session/message lifecycle callbacks | B (in-process) | OpenCode (`.opencode/`) — or pi (`.pi/`) if it has no native skill tool |
|
| is a JS/TS plugin host with session/message lifecycle callbacks | B (in-process) | OpenCode (`.opencode/`) — or pi (`.pi/`) if it has no native skill tool |
|
||||||
| ships an extension-declared context file it always loads | C (instructions-file) | Gemini (`gemini-extension.json` + `GEMINI.md` + `references/gemini-tools.md`) |
|
| ships an extension-declared context file it always loads | C (instructions-file) | Gemini (`gemini-extension.json` + `GEMINI.md` + `references/gemini-tools.md`) |
|
||||||
| has a plugin install command and a manifest `contextFileName` (or equivalent) the installer keeps | C via the plugin installer | Antigravity (`.antigravity-plugin/` — `agy plugin install` ships a generated context file; verify the installer preserves it — Part 6) |
|
| has a plugin install command and a manifest `contextFileName` (or equivalent) the installer keeps | C via the plugin installer | Antigravity (`.antigravity-plugin/` — `agy plugin install` ships a generated context file; verify the installer preserves it — Part 6) |
|
||||||
@@ -311,7 +309,7 @@ patterns below are summaries; the code is the spec.
|
|||||||
Create whatever the harness uses to recognize the plugin. Match the existing
|
Create whatever the harness uses to recognize the plugin. Match the existing
|
||||||
ones in spirit:
|
ones in spirit:
|
||||||
|
|
||||||
- **Shape A:** a `*-plugin/plugin.json` (see `.cursor-plugin/plugin.json`) with
|
- **Shape A:** a `*-plugin/plugin.json` (see `.codex-plugin/plugin.json`) with
|
||||||
`name`, `version`, `description`, author/license/keywords, `"skills":
|
`name`, `version`, `description`, author/license/keywords, `"skills":
|
||||||
"./skills/"`, and `"hooks": "./hooks/hooks-<harness>.json"`. Plus the
|
"./skills/"`, and `"hooks": "./hooks/hooks-<harness>.json"`. Plus the
|
||||||
`hooks-<harness>.json` itself, registering a session-start hook whose command
|
`hooks-<harness>.json` itself, registering a session-start hook whose command
|
||||||
@@ -377,24 +375,25 @@ both double-injects). Find the
|
|||||||
exact field, nesting, and event-matcher values your harness expects. Then
|
exact field, nesting, and event-matcher values your harness expects. Then
|
||||||
decide: add a fourth branch to `hooks/session-start`, or — if the harness needs
|
decide: add a fourth branch to `hooks/session-start`, or — if the harness needs
|
||||||
a different bootstrap message or env contract — add a dedicated
|
a different bootstrap message or env contract — add a dedicated
|
||||||
`hooks/session-start-<harness>` script. If you add a branch
|
`hooks/session-start-<harness>` script, the way Codex did. If you add a branch
|
||||||
and your harness *also* sets an env var an earlier branch keys on (some harnesses
|
and your harness *also* sets an env var an earlier branch keys on (some harnesses
|
||||||
set `CLAUDE_PLUGIN_ROOT` too), order your branch before the one that would
|
set `CLAUDE_PLUGIN_ROOT` too), order your branch before the one that would
|
||||||
otherwise shadow it. Match the harness's
|
otherwise shadow it. Match the harness's
|
||||||
own event-matcher strings (Claude Code uses `startup|clear|compact`, Cursor
|
own event-matcher strings (Claude Code uses `startup|clear|compact`, Codex
|
||||||
`sessionStart`); wrong matchers mean the hook silently never fires.
|
`startup|resume|clear`, Cursor `sessionStart`); wrong matchers mean the hook
|
||||||
|
silently never fires.
|
||||||
|
|
||||||
The **hook-config schema itself varies per harness** — don't assume the
|
The **hook-config schema itself varies per harness** — don't assume the
|
||||||
Claude Code shape is universal. Compare `hooks/hooks.json` and
|
Claude/Codex shape is universal. Compare `hooks/hooks.json`,
|
||||||
`hooks/hooks-cursor.json`: Cursor's uses
|
`hooks/hooks-codex.json`, and `hooks/hooks-cursor.json`: Cursor's uses
|
||||||
`"version": 1`, a lowercase `sessionStart` key, a relative
|
`"version": 1`, a lowercase `sessionStart` key, a relative
|
||||||
`./hooks/run-hook.cmd` command, and omits the `matcher`/`type`/`async` fields
|
`./hooks/run-hook.cmd` command, and omits the `matcher`/`type`/`async` fields the
|
||||||
Claude Code uses. Match your `hooks-<harness>.json` to whichever existing file is
|
others use. Match your `hooks-<harness>.json` to whichever existing file is
|
||||||
closest, not to a single canonical template.
|
closest, not to a single canonical template.
|
||||||
|
|
||||||
The hook **command string references a harness-provided plugin-root variable**,
|
The hook **command string references a harness-provided plugin-root variable**,
|
||||||
and its name differs per harness: `hooks.json` uses `${CLAUDE_PLUGIN_ROOT}`,
|
and its name differs per harness: `hooks.json` uses `${CLAUDE_PLUGIN_ROOT}`,
|
||||||
`hooks-cursor.json` uses a relative path. Use
|
`hooks-codex.json` uses `${PLUGIN_ROOT}`, Cursor uses a relative path. Use
|
||||||
whatever your harness exports. (The `session-start` script re-derives the root
|
whatever your harness exports. (The `session-start` script re-derives the root
|
||||||
itself via `dirname`, so the script body doesn't depend on this — but the
|
itself via `dirname`, so the script body doesn't depend on this — but the
|
||||||
command in the manifest does.)
|
command in the manifest does.)
|
||||||
@@ -785,7 +784,7 @@ Use this as the live index; when in doubt, read the files, not this table.
|
|||||||
| Harness | Entry point | Bootstrap mechanism | Tool mapping | Tests | Distribution |
|
| Harness | Entry point | Bootstrap mechanism | Tool mapping | Tests | Distribution |
|
||||||
|---|---|---|---|---|---|
|
|---|---|---|---|---|---|
|
||||||
| Claude Code | `.claude-plugin/plugin.json` + `hooks/hooks.json` | shell hook → `hooks/session-start` (`hookSpecificOutput.additionalContext`) | native `Skill` tool; `references/claude-code-tools.md` | `tests/hooks/` | marketplace |
|
| Claude Code | `.claude-plugin/plugin.json` + `hooks/hooks.json` | shell hook → `hooks/session-start` (`hookSpecificOutput.additionalContext`) | native `Skill` tool; `references/claude-code-tools.md` | `tests/hooks/` | marketplace |
|
||||||
| Codex | `.codex-plugin/plugin.json` (declares empty `hooks`) | native skill discovery (no session-start hook) | `references/codex-tools.md` | `tests/codex/`, `tests/codex-plugin-sync/` | fork sync (`scripts/sync-to-codex-plugin.sh`) |
|
| Codex | `.codex-plugin/plugin.json` + `hooks/hooks-codex.json` | shell hook → `hooks/session-start-codex` | `references/codex-tools.md` | `tests/codex-plugin-sync/`, `tests/hooks/` | fork sync (`scripts/sync-to-codex-plugin.sh`) |
|
||||||
| Cursor | `.cursor-plugin/plugin.json` + `hooks/hooks-cursor.json` | shell hook → `hooks/session-start` (`additional_context`) | `references/claude-code-tools.md` | `tests/hooks/` | hand-authored |
|
| Cursor | `.cursor-plugin/plugin.json` + `hooks/hooks-cursor.json` | shell hook → `hooks/session-start` (`additional_context`) | `references/claude-code-tools.md` | `tests/hooks/` | hand-authored |
|
||||||
| Copilot CLI | (shares Claude Code hook path; `COPILOT_CLI` env) | shell hook → `hooks/session-start` (`additionalContext`) | `references/copilot-tools.md` | `tests/hooks/` | — |
|
| Copilot CLI | (shares Claude Code hook path; `COPILOT_CLI` env) | shell hook → `hooks/session-start` (`additionalContext`) | `references/copilot-tools.md` | `tests/hooks/` | — |
|
||||||
| Gemini CLI | `gemini-extension.json` + `GEMINI.md` | instructions file `@`-includes bootstrap + mapping | `references/gemini-tools.md` | — | `gemini extensions install` |
|
| Gemini CLI | `gemini-extension.json` + `GEMINI.md` | instructions file `@`-includes bootstrap + mapping | `references/gemini-tools.md` | — | `gemini extensions install` |
|
||||||
@@ -800,10 +799,10 @@ Use this as the live index; when in doubt, read the files, not this table.
|
|||||||
- **Wrong JSON field → silent failure or double injection.** Shape A only.
|
- **Wrong JSON field → silent failure or double injection.** Shape A only.
|
||||||
Confirm the exact field/nesting; Claude Code reads two fields without dedup.
|
Confirm the exact field/nesting; Claude Code reads two fields without dedup.
|
||||||
- **Hook-config schema varies per harness.** Shape A. Cursor's `hooks-cursor.json`
|
- **Hook-config schema varies per harness.** Shape A. Cursor's `hooks-cursor.json`
|
||||||
looks nothing like the Claude Code one (`version`, lowercase `sessionStart`,
|
looks nothing like the Claude/Codex one (`version`, lowercase `sessionStart`,
|
||||||
relative command, no `matcher`/`type`/`async`). Match the closest existing file.
|
relative command, no `matcher`/`type`/`async`). Match the closest existing file.
|
||||||
- **Plugin-root env var differs per harness.** Shape A. The hook command uses
|
- **Plugin-root env var differs per harness.** Shape A. The hook command uses
|
||||||
`${CLAUDE_PLUGIN_ROOT}` (Claude) or a relative path
|
`${CLAUDE_PLUGIN_ROOT}` (Claude), `${PLUGIN_ROOT}` (Codex), or a relative path
|
||||||
(Cursor). Use what your harness exports; the script re-derives the root itself.
|
(Cursor). Use what your harness exports; the script re-derives the root itself.
|
||||||
- **System-message injection.** Shape B injects a *user* message on purpose
|
- **System-message injection.** Shape B injects a *user* message on purpose
|
||||||
(#750, #894). Don't "fix" it to a system message.
|
(#750, #894). Don't "fix" it to a system message.
|
||||||
|
|||||||
@@ -140,7 +140,7 @@ Check that the script filename is **extensionless** in `hooks.json`. A command l
|
|||||||
|
|
||||||
### Hook doesn't fire at all
|
### Hook doesn't fire at all
|
||||||
|
|
||||||
Verify the `matcher` in `hooks.json` matches the event type your harness emits. Claude Code uses `startup|clear|compact`; Cursor uses `sessionStart`. Check `hooks-cursor.json` for the Cursor variant.
|
Verify the `matcher` in `hooks.json` matches the event type your harness emits. Claude Code uses `startup|clear|compact`; Codex uses `startup|resume|clear`. Check `hooks-codex.json` for the Codex variant.
|
||||||
|
|
||||||
## Related Issues
|
## Related Issues
|
||||||
|
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"contextFileName": "GEMINI.md"
|
"contextFileName": "GEMINI.md"
|
||||||
}
|
}
|
||||||
|
|||||||
26
hooks/session-start-codex
Executable file
26
hooks/session-start-codex
Executable file
@@ -0,0 +1,26 @@
|
|||||||
|
#!/usr/bin/env bash
|
||||||
|
# Codex SessionStart hook for superpowers plugin
|
||||||
|
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
||||||
|
PLUGIN_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
|
||||||
|
|
||||||
|
using_superpowers_content=$(cat "${PLUGIN_ROOT}/skills/using-superpowers/SKILL.md" 2>&1 || echo "Error reading using-superpowers skill")
|
||||||
|
|
||||||
|
escape_for_json() {
|
||||||
|
local s="$1"
|
||||||
|
s="${s//\\/\\\\}"
|
||||||
|
s="${s//\"/\\\"}"
|
||||||
|
s="${s//$'\n'/\\n}"
|
||||||
|
s="${s//$'\r'/\\r}"
|
||||||
|
s="${s//$'\t'/\\t}"
|
||||||
|
printf '%s' "$s"
|
||||||
|
}
|
||||||
|
|
||||||
|
using_superpowers_escaped=$(escape_for_json "$using_superpowers_content")
|
||||||
|
session_context="<EXTREMELY_IMPORTANT>\nYou have superpowers.\n\n**Below is the full content of your 'superpowers:using-superpowers' skill - your introduction to using skills. For all other skills, follow the Codex skill-loading instructions in that skill:**\n\n${using_superpowers_escaped}\n</EXTREMELY_IMPORTANT>"
|
||||||
|
|
||||||
|
printf '{\n "hookSpecificOutput": {\n "hookEventName": "SessionStart",\n "additionalContext": "%s"\n }\n}\n' "$session_context" | cat
|
||||||
|
|
||||||
|
exit 0
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.1.1",
|
"version": "6.1.0",
|
||||||
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"main": ".opencode/plugins/superpowers.js",
|
"main": ".opencode/plugins/superpowers.js",
|
||||||
|
|||||||
@@ -242,6 +242,10 @@ git -C "$REPO_ROOT" archive --format=tar "$REF" -- \
|
|||||||
VERSION="$(jq -r '.version // empty' "$STAGE/.codex-plugin/plugin.json")"
|
VERSION="$(jq -r '.version // empty' "$STAGE/.codex-plugin/plugin.json")"
|
||||||
[[ -n "$VERSION" ]] || die "could not read version from .codex-plugin/plugin.json"
|
[[ -n "$VERSION" ]] || die "could not read version from .codex-plugin/plugin.json"
|
||||||
|
|
||||||
|
if jq -e 'has("hooks")' "$STAGE/.codex-plugin/plugin.json" >/dev/null; then
|
||||||
|
die "Codex manifest must not declare hooks for the portal package"
|
||||||
|
fi
|
||||||
|
|
||||||
if [[ -z "$OUTPUT" ]]; then
|
if [[ -z "$OUTPUT" ]]; then
|
||||||
case "$FORMAT" in
|
case "$FORMAT" in
|
||||||
zip)
|
zip)
|
||||||
|
|||||||
@@ -1,58 +1,71 @@
|
|||||||
---
|
---
|
||||||
name: finishing-a-development-branch
|
name: finishing-a-development-branch
|
||||||
description: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work
|
description: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work - guides completion of development work by presenting structured options for merge, PR, or cleanup
|
||||||
---
|
---
|
||||||
|
|
||||||
# Finishing a Development Branch
|
# Finishing a Development Branch
|
||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
|
Guide completion of development work by presenting clear options and handling chosen workflow.
|
||||||
|
|
||||||
**Core principle:** Verify tests → Detect environment → Present options → Execute choice → Clean up.
|
**Core principle:** Verify tests → Detect environment → Present options → Execute choice → Clean up.
|
||||||
|
|
||||||
**Announce at start:** "I'm using the finishing-a-development-branch skill to complete this work."
|
**Announce at start:** "I'm using the finishing-a-development-branch skill to complete this work."
|
||||||
|
|
||||||
## Step 1: Verify Tests
|
## The Process
|
||||||
|
|
||||||
Run the project's full test suite (`npm test` / `cargo test` / `pytest` / `go test ./...`).
|
### Step 1: Verify Tests
|
||||||
|
|
||||||
**If tests fail**, report the failures and stop — the menu comes after a green suite:
|
**Before presenting options, verify tests pass:**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Run project's test suite
|
||||||
|
npm test / cargo test / pytest / go test ./...
|
||||||
|
```
|
||||||
|
|
||||||
|
**If tests fail:**
|
||||||
```
|
```
|
||||||
Tests failing (<N> failures). Must fix before completing:
|
Tests failing (<N> failures). Must fix before completing:
|
||||||
|
|
||||||
[Show failures]
|
[Show failures]
|
||||||
|
|
||||||
|
Cannot proceed with merge/PR until tests pass.
|
||||||
```
|
```
|
||||||
|
|
||||||
**If tests pass:** continue to Step 2.
|
Stop. Don't proceed to Step 2.
|
||||||
|
|
||||||
## Step 2: Detect Environment
|
**If tests pass:** Continue to Step 2.
|
||||||
|
|
||||||
|
### Step 2: Detect Environment
|
||||||
|
|
||||||
|
**Determine workspace state before presenting options:**
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
|
GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
|
||||||
GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
|
GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
|
||||||
# Capture now, while still inside the workspace — Step 5 changes directory
|
|
||||||
# before cleanup (Step 6) needs this value
|
|
||||||
WORKTREE_PATH=$(git rev-parse --show-toplevel)
|
|
||||||
```
|
```
|
||||||
|
|
||||||
This determines which menu to show and how cleanup works:
|
This determines which menu to show and how cleanup works:
|
||||||
|
|
||||||
| State | Menu | Cleanup |
|
| State | Menu | Cleanup |
|
||||||
|-------|------|---------|
|
|-------|------|---------|
|
||||||
| `GIT_DIR == GIT_COMMON` (normal repo) | Standard 3 options | No worktree to clean up |
|
| `GIT_DIR == GIT_COMMON` (normal repo) | Standard 4 options | No worktree to clean up |
|
||||||
| `GIT_DIR != GIT_COMMON`, named branch | Standard 3 options | Provenance-based (see Step 6) |
|
| `GIT_DIR != GIT_COMMON`, named branch | Standard 4 options | Provenance-based (see Step 6) |
|
||||||
| `GIT_DIR != GIT_COMMON`, detached HEAD | Reduced 2 options (no merge) | Externally managed — leave in place |
|
| `GIT_DIR != GIT_COMMON`, detached HEAD | Reduced 3 options (no merge) | No cleanup (externally managed) |
|
||||||
|
|
||||||
## Step 3: Determine Base Branch
|
### Step 3: Determine Base Branch
|
||||||
|
|
||||||
The base branch is whatever this work forked from — usually named in the
|
```bash
|
||||||
plan, the conversation, or the branch's upstream. If it is not already
|
# Try common base branches
|
||||||
known, ask: "This branch split from <your best guess> - is that correct?"
|
git merge-base HEAD main 2>/dev/null || git merge-base HEAD master 2>/dev/null
|
||||||
Confirm before merging: merging into the wrong base is expensive to undo.
|
```
|
||||||
|
|
||||||
## Step 4: Present Options
|
Or ask: "This branch split from main - is that correct?"
|
||||||
|
|
||||||
**Normal repo and named-branch worktree — present exactly these 3 options:**
|
### Step 4: Present Options
|
||||||
|
|
||||||
|
**Normal repo and named-branch worktree — present exactly these 4 options:**
|
||||||
|
|
||||||
```
|
```
|
||||||
Implementation complete. What would you like to do?
|
Implementation complete. What would you like to do?
|
||||||
@@ -60,30 +73,28 @@ Implementation complete. What would you like to do?
|
|||||||
1. Merge back to <base-branch> locally
|
1. Merge back to <base-branch> locally
|
||||||
2. Push and create a Pull Request
|
2. Push and create a Pull Request
|
||||||
3. Keep the branch as-is (I'll handle it later)
|
3. Keep the branch as-is (I'll handle it later)
|
||||||
|
4. Discard this work
|
||||||
|
|
||||||
Which option?
|
Which option?
|
||||||
```
|
```
|
||||||
|
|
||||||
**Detached HEAD — present exactly these 2 options:**
|
**Detached HEAD — present exactly these 3 options:**
|
||||||
|
|
||||||
```
|
```
|
||||||
Implementation complete. You're on a detached HEAD (externally managed workspace).
|
Implementation complete. You're on a detached HEAD (externally managed workspace).
|
||||||
|
|
||||||
1. Push as new branch and create a Pull Request
|
1. Push as new branch and create a Pull Request
|
||||||
2. Keep as-is (I'll handle it later)
|
2. Keep as-is (I'll handle it later)
|
||||||
|
3. Discard this work
|
||||||
|
|
||||||
Which option?
|
Which option?
|
||||||
```
|
```
|
||||||
|
|
||||||
Present the menu exactly as written — concise, with every option coming
|
**Don't add explanation** - keep options concise.
|
||||||
from the list above. Discarding the work happens only in response to your
|
|
||||||
human partner explicitly asking for it (see "If your human partner asks to
|
|
||||||
discard the work" below). Wait for their answer; the integration decision
|
|
||||||
is theirs.
|
|
||||||
|
|
||||||
## Step 5: Execute Choice
|
### Step 5: Execute Choice
|
||||||
|
|
||||||
### Option 1: Merge Locally
|
#### Option 1: Merge Locally
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Get main repo root for CWD safety
|
# Get main repo root for CWD safety
|
||||||
@@ -97,43 +108,34 @@ git merge <feature-branch>
|
|||||||
|
|
||||||
# Verify tests on merged result
|
# Verify tests on merged result
|
||||||
<test command>
|
<test command>
|
||||||
|
|
||||||
|
# Only after merge succeeds: cleanup worktree (Step 6), then delete branch
|
||||||
```
|
```
|
||||||
|
|
||||||
If tests fail on the merged result: stop, leave the worktree and branch in
|
Then: Cleanup worktree (Step 6), then delete branch:
|
||||||
place, and investigate — nothing has been pushed, so the merge is local
|
|
||||||
and recoverable.
|
|
||||||
|
|
||||||
Once the merged result is green: clean up the worktree (Step 6), then
|
|
||||||
delete the branch:
|
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
git branch -d <feature-branch>
|
git branch -d <feature-branch>
|
||||||
```
|
```
|
||||||
|
|
||||||
### Option 2: Push and Create PR
|
#### Option 2: Push and Create PR
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
|
# Push branch
|
||||||
git push -u origin <feature-branch>
|
git push -u origin <feature-branch>
|
||||||
# From a detached HEAD, name the new branch on the remote:
|
|
||||||
# git push origin HEAD:refs/heads/<new-branch>
|
|
||||||
```
|
```
|
||||||
|
|
||||||
Then create the pull/merge request against <base-branch> with the forge's
|
**Do NOT clean up worktree** — user needs it alive to iterate on PR feedback.
|
||||||
tooling — its CLI if one is available, or the creation URL most forges
|
|
||||||
print when you push — following the repo's PR template and conventions if
|
|
||||||
present, and report the URL to your human partner.
|
|
||||||
|
|
||||||
Keep the worktree — your human partner iterates on PR feedback there.
|
#### Option 3: Keep As-Is
|
||||||
|
|
||||||
### Option 3: Keep As-Is
|
|
||||||
|
|
||||||
Report: "Keeping branch <name>. Worktree preserved at <path>."
|
Report: "Keeping branch <name>. Worktree preserved at <path>."
|
||||||
|
|
||||||
### If your human partner asks to discard the work
|
**Don't cleanup worktree.**
|
||||||
|
|
||||||
This path exists only as a response to an explicit request to throw the
|
#### Option 4: Discard
|
||||||
work away. Confirm first:
|
|
||||||
|
|
||||||
|
**Confirm first:**
|
||||||
```
|
```
|
||||||
This will permanently delete:
|
This will permanently delete:
|
||||||
- Branch <name>
|
- Branch <name>
|
||||||
@@ -143,39 +145,41 @@ This will permanently delete:
|
|||||||
Type 'discard' to confirm.
|
Type 'discard' to confirm.
|
||||||
```
|
```
|
||||||
|
|
||||||
Wait for that exact confirmation. When it arrives:
|
Wait for exact confirmation.
|
||||||
|
|
||||||
|
If confirmed:
|
||||||
```bash
|
```bash
|
||||||
MAIN_ROOT=$(git -C "$(git rev-parse --git-common-dir)/.." rev-parse --show-toplevel)
|
MAIN_ROOT=$(git -C "$(git rev-parse --git-common-dir)/.." rev-parse --show-toplevel)
|
||||||
cd "$MAIN_ROOT"
|
cd "$MAIN_ROOT"
|
||||||
```
|
```
|
||||||
|
|
||||||
Then clean up the worktree (Step 6) and force-delete the branch:
|
Then: Cleanup worktree (Step 6), then force-delete branch:
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
git branch -D <feature-branch>
|
git branch -D <feature-branch>
|
||||||
```
|
```
|
||||||
|
|
||||||
## Step 6: Cleanup Workspace
|
### Step 6: Cleanup Workspace
|
||||||
|
|
||||||
**Runs for Option 1 and confirmed discards.** Options 2 and 3 always
|
**Only runs for Options 1 and 4.** Options 2 and 3 always preserve the worktree.
|
||||||
preserve the worktree. Both callers have already changed directory to the
|
|
||||||
main repo root — worktree removal must run from outside the worktree —
|
```bash
|
||||||
and use the `GIT_DIR`/`GIT_COMMON`/`WORKTREE_PATH` values captured in
|
GIT_DIR=$(cd "$(git rev-parse --git-dir)" 2>/dev/null && pwd -P)
|
||||||
Step 2, from before that directory change.
|
GIT_COMMON=$(cd "$(git rev-parse --git-common-dir)" 2>/dev/null && pwd -P)
|
||||||
|
WORKTREE_PATH=$(git rev-parse --show-toplevel)
|
||||||
|
```
|
||||||
|
|
||||||
**If `GIT_DIR == GIT_COMMON`:** Normal repo, no worktree to clean up. Done.
|
**If `GIT_DIR == GIT_COMMON`:** Normal repo, no worktree to clean up. Done.
|
||||||
|
|
||||||
**If `WORKTREE_PATH` is under `.worktrees/` or `worktrees/`:** Superpowers
|
**If worktree path is under `.worktrees/` or `worktrees/`:** Superpowers created this worktree — we own cleanup.
|
||||||
created this worktree — we own cleanup:
|
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
|
MAIN_ROOT=$(git -C "$(git rev-parse --git-common-dir)/.." rev-parse --show-toplevel)
|
||||||
|
cd "$MAIN_ROOT"
|
||||||
git worktree remove "$WORKTREE_PATH"
|
git worktree remove "$WORKTREE_PATH"
|
||||||
git worktree prune # Self-healing: clean up any stale registrations
|
git worktree prune # Self-healing: clean up any stale registrations
|
||||||
```
|
```
|
||||||
|
|
||||||
**Otherwise:** The host environment owns this workspace — leave it in
|
**Otherwise:** The host environment (harness) owns this workspace. Do NOT remove it. If your platform provides a workspace-exit tool, use it. Otherwise, leave the workspace in place.
|
||||||
place. If your platform provides a workspace-exit tool, use it.
|
|
||||||
|
|
||||||
## Quick Reference
|
## Quick Reference
|
||||||
|
|
||||||
@@ -184,18 +188,54 @@ place. If your platform provides a workspace-exit tool, use it.
|
|||||||
| 1. Merge locally | yes | - | - | yes |
|
| 1. Merge locally | yes | - | - | yes |
|
||||||
| 2. Create PR | - | yes | yes | - |
|
| 2. Create PR | - | yes | yes | - |
|
||||||
| 3. Keep as-is | - | - | yes | - |
|
| 3. Keep as-is | - | - | yes | - |
|
||||||
| Discard (explicit request only) | - | - | - | yes (force) |
|
| 4. Discard | - | - | - | yes (force) |
|
||||||
|
|
||||||
## Common Rationalizations
|
## Common Mistakes
|
||||||
|
|
||||||
| Excuse | Reality |
|
**Skipping test verification**
|
||||||
|--------|---------|
|
- **Problem:** Merge broken code, create failing PR
|
||||||
| "Tests passed earlier this session" | Run the suite on the tree you are about to integrate. A green run only proves the tree it ran on. |
|
- **Fix:** Always verify tests before offering options
|
||||||
| "They obviously want it merged" | Integration is your human partner's decision. Present the menu and wait. |
|
|
||||||
| "They seem done with this feature — I'll offer to discard it" | The menu is complete as written. Discard happens only when your human partner asks for it in so many words. |
|
**Open-ended questions**
|
||||||
| "'Yeah, get rid of it' counts as confirmation" | Only the typed word `discard` authorizes deletion. |
|
- **Problem:** "What should I do next?" is ambiguous
|
||||||
| "The PR is up, so the worktree is clutter now" | PR feedback gets fixed in that worktree. It stays until the work lands. |
|
- **Fix:** Present exactly 4 structured options (or 3 for detached HEAD)
|
||||||
| "This other worktree looks stale — I'll clean it too" | Clean up only worktrees under `.worktrees/` or `worktrees/`. Everything else belongs to the host. |
|
|
||||||
| "The merged-result failure is probably flaky" | A failing merged result stops everything. Branch and worktree stay put while you investigate. |
|
**Cleaning up worktree for Option 2**
|
||||||
| "The base branch is obviously main" | Confirm the fork point or ask. Merging into the wrong base is expensive to undo. |
|
- **Problem:** Remove worktree user needs for PR iteration
|
||||||
| "The push was rejected — force-push will fix it" | A rejected push means the remote moved. Investigate; force-push only on your human partner's explicit request. |
|
- **Fix:** Only cleanup for Options 1 and 4
|
||||||
|
|
||||||
|
**Deleting branch before removing worktree**
|
||||||
|
- **Problem:** `git branch -d` fails because worktree still references the branch
|
||||||
|
- **Fix:** Merge first, remove worktree, then delete branch
|
||||||
|
|
||||||
|
**Running git worktree remove from inside the worktree**
|
||||||
|
- **Problem:** Command fails silently when CWD is inside the worktree being removed
|
||||||
|
- **Fix:** Always `cd` to main repo root before `git worktree remove`
|
||||||
|
|
||||||
|
**Cleaning up harness-owned worktrees**
|
||||||
|
- **Problem:** Removing a worktree the harness created causes phantom state
|
||||||
|
- **Fix:** Only clean up worktrees under `.worktrees/` or `worktrees/`
|
||||||
|
|
||||||
|
**No confirmation for discard**
|
||||||
|
- **Problem:** Accidentally delete work
|
||||||
|
- **Fix:** Require typed "discard" confirmation
|
||||||
|
|
||||||
|
## Red Flags
|
||||||
|
|
||||||
|
**Never:**
|
||||||
|
- Proceed with failing tests
|
||||||
|
- Merge without verifying tests on result
|
||||||
|
- Delete work without confirmation
|
||||||
|
- Force-push without explicit request
|
||||||
|
- Remove a worktree before confirming merge success
|
||||||
|
- Clean up worktrees you didn't create (provenance check)
|
||||||
|
- Run `git worktree remove` from inside the worktree
|
||||||
|
|
||||||
|
**Always:**
|
||||||
|
- Verify tests before offering options
|
||||||
|
- Detect environment before presenting menu
|
||||||
|
- Present exactly 4 options (or 3 for detached HEAD)
|
||||||
|
- Get typed confirmation for Option 4
|
||||||
|
- Clean up worktree for Options 1 & 4 only
|
||||||
|
- `cd` to main repo root before worktree removal
|
||||||
|
- Run `git worktree prune` after removal
|
||||||
|
|||||||
@@ -140,9 +140,6 @@ extracted="$TEST_ROOT/extracted"
|
|||||||
tar_extracted="$TEST_ROOT/tar-extracted"
|
tar_extracted="$TEST_ROOT/tar-extracted"
|
||||||
write_metadata_fixture "$metadata_source"
|
write_metadata_fixture "$metadata_source"
|
||||||
|
|
||||||
source_hooks="$(python3 -c 'import json; print(json.load(open("'"$REPO_ROOT"'/.codex-plugin/plugin.json")).get("hooks"))')"
|
|
||||||
assert_equals "$source_hooks" "{}" "source Codex manifest suppresses local hook auto-discovery"
|
|
||||||
|
|
||||||
if output="$("$SCRIPT_UNDER_TEST" --allow-dirty --metadata-source "$metadata_source" --output "$archive" 2>&1)"; then
|
if output="$("$SCRIPT_UNDER_TEST" --allow-dirty --metadata-source "$metadata_source" --output "$archive" 2>&1)"; then
|
||||||
pass "package script exits successfully"
|
pass "package script exits successfully"
|
||||||
else
|
else
|
||||||
@@ -173,7 +170,7 @@ assert_contains "$archive_paths" "assets/superpowers-small.svg" "archive include
|
|||||||
|
|
||||||
manifest_summary="$(read_archive_file "$archive" .codex-plugin/plugin.json | python3 -c 'import json,sys; data=json.load(sys.stdin); print("\t".join([data["name"], data["version"], data["skills"], str(data.get("hooks"))]))')"
|
manifest_summary="$(read_archive_file "$archive" .codex-plugin/plugin.json | python3 -c 'import json,sys; data=json.load(sys.stdin); print("\t".join([data["name"], data["version"], data["skills"], str(data.get("hooks"))]))')"
|
||||||
expected_version="$(python3 -c 'import json; print(json.load(open("'"$REPO_ROOT"'/.codex-plugin/plugin.json"))["version"])')"
|
expected_version="$(python3 -c 'import json; print(json.load(open("'"$REPO_ROOT"'/.codex-plugin/plugin.json"))["version"])')"
|
||||||
assert_equals "$manifest_summary" "superpowers $expected_version ./skills/ $source_hooks" "archive manifest preserves source hooks"
|
assert_equals "$manifest_summary" "superpowers $expected_version ./skills/ None" "archive manifest is current and hook-free"
|
||||||
|
|
||||||
skill_count="$(find "$extracted/skills" -mindepth 1 -maxdepth 1 -type d | wc -l | tr -d ' ')"
|
skill_count="$(find "$extracted/skills" -mindepth 1 -maxdepth 1 -type d | wc -l | tr -d ' ')"
|
||||||
metadata_count="$(find "$extracted/skills" -path '*/agents/openai.yaml' -type f | wc -l | tr -d ' ')"
|
metadata_count="$(find "$extracted/skills" -path '*/agents/openai.yaml' -type f | wc -l | tr -d ' ')"
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ set -euo pipefail
|
|||||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
||||||
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
|
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
|
||||||
HOOK_UNDER_TEST="$REPO_ROOT/hooks/session-start"
|
HOOK_UNDER_TEST="$REPO_ROOT/hooks/session-start"
|
||||||
|
CODEX_HOOK_UNDER_TEST="$REPO_ROOT/hooks/session-start-codex"
|
||||||
WRAPPER_UNDER_TEST="$REPO_ROOT/hooks/run-hook.cmd"
|
WRAPPER_UNDER_TEST="$REPO_ROOT/hooks/run-hook.cmd"
|
||||||
|
|
||||||
FAILURES=0
|
FAILURES=0
|
||||||
@@ -153,15 +154,35 @@ assert_command_output \
|
|||||||
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
bash "$HOOK_UNDER_TEST"
|
bash "$HOOK_UNDER_TEST"
|
||||||
|
|
||||||
wrapper_home="$(make_home run-hook-wrapper)"
|
codex_home="$(make_home codex-plugin-hooks)"
|
||||||
|
codex_data="$TEST_ROOT/codex-plugin-hooks/data"
|
||||||
|
mkdir -p "$codex_data"
|
||||||
assert_command_output \
|
assert_command_output \
|
||||||
"run-hook.cmd wrapper dispatches to the named session-start script" \
|
"Codex plugin hooks use dedicated script and emit nested SessionStart additionalContext" \
|
||||||
"nested" \
|
"nested" \
|
||||||
"" \
|
"" \
|
||||||
"" \
|
"" \
|
||||||
"$wrapper_home" \
|
"$codex_home" \
|
||||||
|
PLUGIN_DATA="$codex_data" \
|
||||||
|
CLAUDE_PLUGIN_DATA="$codex_data" \
|
||||||
|
PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
bash "$WRAPPER_UNDER_TEST" session-start
|
bash "$CODEX_HOOK_UNDER_TEST"
|
||||||
|
|
||||||
|
codex_wrapper_home="$(make_home codex-wrapper)"
|
||||||
|
codex_wrapper_data="$TEST_ROOT/codex-wrapper/data"
|
||||||
|
mkdir -p "$codex_wrapper_data"
|
||||||
|
assert_command_output \
|
||||||
|
"Codex wrapper path dispatches to dedicated script" \
|
||||||
|
"nested" \
|
||||||
|
"" \
|
||||||
|
"" \
|
||||||
|
"$codex_wrapper_home" \
|
||||||
|
PLUGIN_DATA="$codex_wrapper_data" \
|
||||||
|
CLAUDE_PLUGIN_DATA="$codex_wrapper_data" \
|
||||||
|
PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
|
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
|
bash "$WRAPPER_UNDER_TEST" session-start-codex
|
||||||
|
|
||||||
cursor_home="$(make_home cursor)"
|
cursor_home="$(make_home cursor)"
|
||||||
assert_command_output \
|
assert_command_output \
|
||||||
@@ -196,6 +217,21 @@ assert_command_output \
|
|||||||
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
bash "$HOOK_UNDER_TEST"
|
bash "$HOOK_UNDER_TEST"
|
||||||
|
|
||||||
|
codex_legacy_home="$(make_home codex-legacy-warning-removed)"
|
||||||
|
codex_legacy_data="$TEST_ROOT/codex-legacy-warning-removed/data"
|
||||||
|
mkdir -p "$codex_legacy_home/.config/superpowers/skills" "$codex_legacy_data"
|
||||||
|
assert_command_output \
|
||||||
|
"Codex SessionStart omits obsolete legacy custom-skill warning" \
|
||||||
|
"nested" \
|
||||||
|
"" \
|
||||||
|
"Superpowers now uses"$'\037'"~/.config/superpowers/skills"$'\037'"~/.claude/skills"$'\037'"legacy" \
|
||||||
|
"$codex_legacy_home" \
|
||||||
|
PLUGIN_DATA="$codex_legacy_data" \
|
||||||
|
CLAUDE_PLUGIN_DATA="$codex_legacy_data" \
|
||||||
|
PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
|
CLAUDE_PLUGIN_ROOT="$REPO_ROOT" \
|
||||||
|
bash "$CODEX_HOOK_UNDER_TEST"
|
||||||
|
|
||||||
if [[ "$FAILURES" -gt 0 ]]; then
|
if [[ "$FAILURES" -gt 0 ]]; then
|
||||||
echo "STATUS: FAILED ($FAILURES failure(s))"
|
echo "STATUS: FAILED ($FAILURES failure(s))"
|
||||||
exit 1
|
exit 1
|
||||||
|
|||||||
Reference in New Issue
Block a user