mirror of
https://github.com/obra/superpowers.git
synced 2026-08-01 23:21:34 +08:00
Compare commits
8 Commits
fix/t1-sdd
...
exp/loop-e
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
374ea4f146 | ||
|
|
2e11d4c79a | ||
|
|
76c656a8b6 | ||
|
|
3f28d9c943 | ||
|
|
ef834a2949 | ||
|
|
f0ef65c126 | ||
|
|
70c9a9a26a | ||
|
|
aaa0a8f0f4 |
@@ -9,7 +9,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"source": "./",
|
"source": "./",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library for Claude Code: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
"description": "An agentic skills framework & software development methodology that works: planning, TDD, debugging, and collaboration workflows.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"displayName": "Superpowers",
|
"displayName": "Superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
"email": "jesse@fsck.com"
|
"email": "jesse@fsck.com"
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "An agentic skills framework and software development methodology.",
|
"description": "An agentic skills framework and software development methodology.",
|
||||||
"author": {
|
"author": {
|
||||||
"name": "Jesse Vincent",
|
"name": "Jesse Vincent",
|
||||||
|
|||||||
@@ -3,6 +3,12 @@
|
|||||||
Superpowers is a complete software development methodology for your coding agents, built on top of a set of composable skills and some initial instructions that make sure your agent uses them.
|
Superpowers is a complete software development methodology for your coding agents, built on top of a set of composable skills and some initial instructions that make sure your agent uses them.
|
||||||
|
|
||||||
|
|
||||||
|
## We're Hiring!
|
||||||
|
|
||||||
|
We're hiring someone to help out full time with Superpowers community and code work.
|
||||||
|
You can read about the job at https://primeradiant.com/jobs/superpowers-community-engineer/
|
||||||
|
If this sounds like someone you know, definitely send them our way.
|
||||||
|
|
||||||
## Quickstart
|
## Quickstart
|
||||||
|
|
||||||
Give your agent Superpowers: [Claude Code](#claude-code), [Antigravity](#antigravity), [Codex App](#codex-app), [Codex CLI](#codex-cli), [Cursor](#cursor), [Factory Droid](#factory-droid), [Gemini CLI](#gemini-cli), [GitHub Copilot CLI](#github-copilot-cli), [Kimi Code](#kimi-code), [OpenCode](#opencode), [Pi](#pi).
|
Give your agent Superpowers: [Claude Code](#claude-code), [Antigravity](#antigravity), [Codex App](#codex-app), [Codex CLI](#codex-cli), [Cursor](#cursor), [Factory Droid](#factory-droid), [Gemini CLI](#gemini-cli), [GitHub Copilot CLI](#github-copilot-cli), [Kimi Code](#kimi-code), [OpenCode](#opencode), [Pi](#pi).
|
||||||
|
|||||||
@@ -1,38 +1,5 @@
|
|||||||
# Superpowers Release Notes
|
# Superpowers Release Notes
|
||||||
|
|
||||||
## v6.2.0 (2026-07-23)
|
|
||||||
|
|
||||||
### Subagent-Driven Development
|
|
||||||
|
|
||||||
Two structural changes to how SDD tracks progress and closes out review findings, both developed against live eval campaigns.
|
|
||||||
|
|
||||||
- **The workspace is now plan-scoped.** `.superpowers/sdd/` had no plan identity and no end-of-life: a follow-up plan in the same working tree could read the previous plan's ledger as its own progress (observed in the wild, with multiple contamination rounds and ad-hoc workarounds). `sdd-workspace` now requires the plan file and resolves a per-plan directory, `.superpowers/sdd/<plan-basename>/`; `task-brief` and `review-package` write into their plan's directory (`review-package` gains the plan file as its first argument); the ledger names its plan on its first line; and the workspace is deleted once the final review is clean — git history is the durable record. Baseline evals showed controllers already refused foreign ledgers, but at a cost of 6–13 tool calls of cross-plan git forensics per resume; plan-scoping makes the answer structural instead. (25/25 baseline and GREEN eval runs documented in `docs/specs/` and `docs/plans/`.)
|
|
||||||
- **The review-fix loop resumes the implementer.** The lifecycle restructure gives fix rounds resume-the-implementer semantics instead of fresh dispatches, adds a scoped re-review prompt (`re-review-prompt.md`) so the re-reviewer checks the fixes rather than re-reading the whole task, and installs a five-round circuit breaker with controller adjudication when it trips. SKILL.md reorganizes by lifecycle, and its Red Flags convert to the house rationalization-table form.
|
|
||||||
|
|
||||||
### Skills
|
|
||||||
|
|
||||||
A branch-wide compression campaign: recap sections, social proof, and benefits-selling prose aimed at a reader who has already invoked the skill are gone, with every load-bearing argument folded into a rationalization-table row or moved to its point of use. Each cut was micro-tested with subagent probes, and the one cut that measurably degraded behavior was reworked rather than shipped.
|
|
||||||
|
|
||||||
- **`testing-anti-patterns.md` is now `writing-good-tests.md`.** The TDD reference doc is rebuilt as a positive catalog — six rules that lead with the GOOD example — and absorbs a falsifiability discipline: name the production change that would fail the test, derive expectations independently of the code under test, and a closing mutation check. It closes two holes by name: the string-presence trap (grep-style tests on scripts, skills, and prompts counterfeit falsifiability — the observable is behavior, never text) and the change-detector trap (a constant assertion can fail and still protect nothing), each with a hard stop in the gate function. Trivial code and human prose earn no test; the trigger broadens from "adding mocks" to any test writing.
|
|
||||||
- **TDD's "Why Order Matters" rebuttals survive as rationalization rows.** Deleting the section outright measurably degraded test-first behavior under "just write it, tests after" pressure (control 8/10 → treatment 5/10, corroborated on Claude and Codex), so each prose rebuttal now lives in its Common Rationalizations row — the section is gone but the arguments fire where an agent hits them mid-rationalization.
|
|
||||||
- **`finishing-a-development-branch` no longer offers to discard your work.** The completion menu dates from when throwing away branches was routine; "Discard this work" next to "Merge" advertised destroying finished, passing work. Discard survives as an explicit-request-only path with the same typed-confirmation ritual. The same pass made PR creation forge-agnostic (your forge's CLI or the URL printed on push, not a blessed list of tools) and fixed a real bug: the worktree path was recomputed after cleanup had already changed directory, so provenance checks never matched and cleanup silently no-oped.
|
|
||||||
- **Recap and persuasion prose removed across the library.** `brainstorming`, `systematic-debugging`, `dispatching-parallel-agents`, `verification-before-completion`, `executing-plans`, `subagent-driven-development`, `requesting-code-review`, `receiving-code-review`, `using-git-worktrees`, `writing-plans`, and `writing-skills` all drop their Bottom Line / Key Principles / Real-World Impact / Advantages sections; `using-git-worktrees` and `finishing-a-development-branch` convert their guard sections to the house Excuse/Reality rationalization table.
|
|
||||||
|
|
||||||
### Windows
|
|
||||||
|
|
||||||
- **The SessionStart hook now dispatches via Git Bash.** The hook's command string starts with a quoted path, which broke both shells Claude Code might hand it to: PowerShell parsed the quoted string as an expression and died with a parser error (#1751), and cmd.exe's quote-stripping rule truncated the command when the profile path contained a metacharacter like `(` (#1918) — either way the bootstrap silently never loaded. The hook now declares `shell: "bash"`, which Claude Code ≥ 2.1.81 resolves to Git for Windows directly, and which surfaces an actionable install prompt when Git Bash is missing. Older Claude Code versions ignore the unknown key and behave as before. Verified end-to-end on Linux, Windows 11 with Git Bash under a hostile path, and Windows 11 without Git Bash.
|
|
||||||
|
|
||||||
### Harness Support
|
|
||||||
|
|
||||||
- **Gemini CLI support is restored.** The v6.1.0 removal (on the news that Google had EOLed the Gemini CLI) was premature; the install docs and the `gemini-tools.md` tool-mapping reference are back while permanent removal gets a proper evaluation. (#1959)
|
|
||||||
|
|
||||||
### Fixes
|
|
||||||
|
|
||||||
- **`find-polluter.sh` actually finds test files now.** `find .` emits `./`-prefixed paths, so the documented `-path "src/**/*.test.ts"` pattern matched nothing — and `wc -l` on empty input then reported "Found 1". Fixed the prefix mismatch (#2008, #2011), plus two follow-ups: a caller-supplied `./`-prefixed pattern no longer double-prefixes into a never-matching form, and `**/` is also matched collapsed so tests directly under the base directory (`src/top.test.ts` vs `src/**/*.test.ts`) aren't silently skipped. The script gains a deterministic test suite.
|
|
||||||
- **The Codex package script works beyond macOS.** Deterministic-metadata tar flags were bsdtar-only spellings, staged file modes depended on two umasks canceling out, and the test's timestamp assertion parsed bsdtar's column layout in a US timezone. GNU tar now gets equivalent flags producing byte-identical headers, modes are pinned canonical, and the test asserts mtime via `tarfile`.
|
|
||||||
- **SDD's skill test no longer flakes.** The file's worst case exceeded the runner's per-file ceiling (raised to 900s), and the assert helpers matched free-form model prose case-sensitively; matching is now case-insensitive and `assert_order` dumps output on failure so the next flake is diagnosable.
|
|
||||||
- **Docs and test cleanup after the v6.1.0 reference pruning.** Dead links to the deleted `claude-code-tools.md`/`copilot-tools.md` are replaced with the current architecture (#1969), a dangling `#subagent-support` anchor in the Antigravity reference is dropped (#2010), and the Antigravity/Pi mapping tests assert only the surviving harness-specific mappings — scoped to the table so they fail again if it's deleted.
|
|
||||||
|
|
||||||
## v6.1.1 (2026-07-02)
|
## v6.1.1 (2026-07-02)
|
||||||
|
|
||||||
### Codex
|
### Codex
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
"description": "Core skills library: TDD, debugging, collaboration patterns, and proven techniques",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"contextFileName": "GEMINI.md"
|
"contextFileName": "GEMINI.md"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "superpowers",
|
"name": "superpowers",
|
||||||
"version": "6.2.0",
|
"version": "6.1.1",
|
||||||
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
"description": "Superpowers skills and runtime bootstrap for coding agents",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"main": ".opencode/plugins/superpowers.js",
|
"main": ".opencode/plugins/superpowers.js",
|
||||||
|
|||||||
@@ -34,15 +34,6 @@ Subagent (general-purpose):
|
|||||||
|
|
||||||
Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.
|
Your review is read-only on this checkout. Do not mutate the working tree, the index, HEAD, or branch state in any way. Use tools like `git show`, `git diff`, and `git log` to inspect history. If you need a working copy of a different revision, check it out into a separate temporary directory (e.g. `git worktree add /tmp/review-[SHA] [SHA]`) — never move HEAD on this checkout.
|
||||||
|
|
||||||
## You Do Not Dispatch Subagents
|
|
||||||
|
|
||||||
Do all of this review yourself. Never spawn a subagent to review part
|
|
||||||
of the diff, and never spawn another reviewer for a second opinion.
|
|
||||||
This process already provides every review seat the work gets; a
|
|
||||||
reviewer you spawn duplicates one of them at full cost, and its
|
|
||||||
verdict counts for nothing. If the diff feels too large for one
|
|
||||||
pass, review it in passes yourself and say so in your report.
|
|
||||||
|
|
||||||
## What to Check
|
## What to Check
|
||||||
|
|
||||||
**Plan alignment:**
|
**Plan alignment:**
|
||||||
|
|||||||
@@ -211,9 +211,15 @@ and fix-round diffs need it.
|
|||||||
first — it is your requirements, with the exact values to use verbatim";
|
first — it is your requirements, with the exact values to use verbatim";
|
||||||
(3) interfaces and decisions from earlier tasks that the brief cannot
|
(3) interfaces and decisions from earlier tasks that the brief cannot
|
||||||
know; (4) your resolution of any ambiguity you noticed in the brief;
|
know; (4) your resolution of any ambiguity you noticed in the brief;
|
||||||
(5) the report-file path and report contract. Exact values (numbers,
|
(5) the report-file path and report contract; (6) the plan's binding
|
||||||
magic strings, signatures, test cases) appear only in the brief. Never
|
constraint values — any Global Constraint that mandates an exact
|
||||||
make a subagent read the whole plan file.
|
mechanical form (commit-message rules, naming rules, fixed literals) —
|
||||||
|
pasted verbatim. Task-specific exact values (numbers, magic strings,
|
||||||
|
signatures, test cases) appear only in the brief; binding constraint
|
||||||
|
values are the one exception — they ride in EVERY dispatch, because a
|
||||||
|
subagent that must recall a constraint from memory will reconstruct it
|
||||||
|
from its own priors instead. Never make a subagent read the whole plan
|
||||||
|
file.
|
||||||
- **Report file:** name the implementer's report file after the brief
|
- **Report file:** name the implementer's report file after the brief
|
||||||
(brief `…/task-N-brief.md` → report `…/task-N-report.md`) and put it in
|
(brief `…/task-N-brief.md` → report `…/task-N-report.md`) and put it in
|
||||||
the dispatch prompt. The implementer writes the full report there and
|
the dispatch prompt. The implementer writes the full report there and
|
||||||
@@ -223,12 +229,6 @@ and fix-round diffs need it.
|
|||||||
later dispatches — a real session's dispatch hit 42k chars of which 99%
|
later dispatches — a real session's dispatch hit 42k chars of which 99%
|
||||||
was pasted history. A fresh subagent needs its task, the interfaces it
|
was pasted history. A fresh subagent needs its task, the interfaces it
|
||||||
touches, and the global constraints. Nothing else.
|
touches, and the global constraints. Nothing else.
|
||||||
- The dispatch carries the no-subagents contract (it is in the
|
|
||||||
implementer template): the implementer never dispatches subagents —
|
|
||||||
not helpers, and never a reviewer. Review arrives from you, after the
|
|
||||||
report. In real sessions, every reviewer a worker spawned duplicated
|
|
||||||
the task review the controller dispatched anyway — a full extra
|
|
||||||
review seat per task.
|
|
||||||
- If an earlier task parked a finding in the area this task touches, carry
|
- If an earlier task parked a finding in the area this task touches, carry
|
||||||
a pointer to that ledger entry in the dispatch.
|
a pointer to that ledger entry in the dispatch.
|
||||||
- Record the implementer's agent identity from the dispatch result —
|
- Record the implementer's agent identity from the dispatch result —
|
||||||
@@ -279,6 +279,10 @@ needed.
|
|||||||
- **Reviewer inputs:** the task reviewer gets three paths — the same brief
|
- **Reviewer inputs:** the task reviewer gets three paths — the same brief
|
||||||
file, the report file, and the review package — plus the global
|
file, the report file, and the review package — plus the global
|
||||||
constraints that bind the task.
|
constraints that bind the task.
|
||||||
|
- **Persist the verdict:** when the review returns, write its full text to
|
||||||
|
`<workspace>/task-<N>-review.md` before acting on it. The file is the
|
||||||
|
gate: completion checks for the artifact, not for your memory of a
|
||||||
|
verdict.
|
||||||
- The global-constraints block you hand the reviewer is its attention
|
- The global-constraints block you hand the reviewer is its attention
|
||||||
lens. Copy the binding requirements verbatim from the plan's Global
|
lens. Copy the binding requirements verbatim from the plan's Global
|
||||||
Constraints section or the spec: exact values, exact formats, and the
|
Constraints section or the spec: exact values, exact formats, and the
|
||||||
@@ -329,22 +333,26 @@ scoped re-review. Five rounds maximum per task:
|
|||||||
verbatim. Its context is intact: it knows the task, the code, and its own
|
verbatim. Its context is intact: it knows the task, the code, and its own
|
||||||
choices. If your harness cannot send another message to a live subagent,
|
choices. If your harness cannot send another message to a live subagent,
|
||||||
dispatch a fresh implementer carrying the brief path, the report-file path,
|
dispatch a fresh implementer carrying the brief path, the report-file path,
|
||||||
and the findings — the report file is the persistent memory either way.
|
the findings, and the binding constraint values verbatim — the report file
|
||||||
|
is the persistent memory either way.
|
||||||
|
|
||||||
**Rounds 4-5 — dispatch a fresh implementer on a more capable model** (per
|
**Rounds 4-5 — dispatch a fresh implementer on a more capable model** (per
|
||||||
Model Selection), with the brief path, the report-file path, the open
|
Model Selection), with the brief path, the report-file path, the open
|
||||||
findings, and this framing: "A prior implementer attempted this task
|
findings, the binding constraint values verbatim, and this framing: "A
|
||||||
[N] times; you own it now. Read the report file for what was tried." A loop
|
prior implementer attempted this task [N] times; you own it now. Read the
|
||||||
that survives three resumes usually means the implementer cannot see its
|
report file for what was tried." A loop that survives three resumes usually
|
||||||
own problem — fresh eyes and a capability bump in one move.
|
means the implementer cannot see its own problem — fresh eyes and a
|
||||||
|
capability bump in one move.
|
||||||
|
|
||||||
**Every round, either way:** the implementer fixes, re-runs the tests
|
**Every round, either way:** the implementer fixes, re-runs the tests
|
||||||
covering the amended code, appends its fix report to the same report file,
|
covering the amended code, appends its fix report to the same report file,
|
||||||
and returns the short contract. Before re-dispatching the reviewer, confirm
|
and returns the short contract. Before re-dispatching the reviewer, confirm
|
||||||
the fix report contains the covering tests, the command run, and the
|
the fix report contains the covering tests, the command run, and the output;
|
||||||
output; dispatch the re-review once all three are present. Name the
|
dispatch the re-review once all three are present. Name the covering test
|
||||||
covering test files in the fix message — a one-line fix does not need the
|
files in the fix message — a one-line fix does not need the whole suite.
|
||||||
whole suite.
|
Append the re-review's returned text to `<workspace>/task-<N>-review.md` as
|
||||||
|
well — the artifact accumulates every verdict, and the file's last entry is
|
||||||
|
the one completion relies on.
|
||||||
|
|
||||||
**The re-review is scoped.** Run `scripts/review-package PLAN_FILE FIX_BASE HEAD`
|
**The re-review is scoped.** Run `scripts/review-package PLAN_FILE FIX_BASE HEAD`
|
||||||
where FIX_BASE is the head the previous review saw, and dispatch
|
where FIX_BASE is the head the previous review saw, and dispatch
|
||||||
@@ -389,10 +397,20 @@ message as your other bookkeeping:
|
|||||||
- `Task <N>: complete (commits <base7>..<head7>, review clean)`
|
- `Task <N>: complete (commits <base7>..<head7>, review clean)`
|
||||||
- `Task <N>: complete (commits <base7>..<head7>, <K> parked)` after a
|
- `Task <N>: complete (commits <base7>..<head7>, <K> parked)` after a
|
||||||
tripped breaker
|
tripped breaker
|
||||||
|
- `Task <N>: complete (commits <base7>..<head7>, deviation parked: <rule>)`
|
||||||
|
when a landed commit violates a mechanical constraint that nothing
|
||||||
|
downstream builds on. Record the ruling in the ledger. A green build with
|
||||||
|
a parked, recorded deviation is complete — do not fail the task, and do
|
||||||
|
not rewrite landed history to chase cosmetics. A load-bearing violation
|
||||||
|
is different: that is a BLOCKED, not a deviation. This valve is not the
|
||||||
|
breaker: it needs no exhausted fix rounds — a mechanical deviation
|
||||||
|
discovered at completion parks here directly, with its ruling in the ledger.
|
||||||
|
|
||||||
Then mark the todo complete and move on. Never move to the next task while
|
Then mark the todo complete and move on — but only once
|
||||||
the review has open Critical/Important issues that are neither fixed nor
|
`<workspace>/task-<N>-review.md` exists; a completion line without its review
|
||||||
parked-with-ruling at the cap.
|
artifact is invalid, whatever you remember about the review. Never move to
|
||||||
|
the next task while the review has open Critical/Important issues that are
|
||||||
|
neither fixed nor parked-with-ruling at the cap.
|
||||||
|
|
||||||
## Final Review
|
## Final Review
|
||||||
|
|
||||||
@@ -405,17 +423,22 @@ on the most capable available model (see Model Selection), using
|
|||||||
superpowers:requesting-code-review's
|
superpowers:requesting-code-review's
|
||||||
[code-reviewer.md](../requesting-code-review/code-reviewer.md). Point it at
|
[code-reviewer.md](../requesting-code-review/code-reviewer.md). Point it at
|
||||||
the ledger's deferred-minor and parked lines so it can triage which must be
|
the ledger's deferred-minor and parked lines so it can triage which must be
|
||||||
fixed before merge.
|
fixed before merge. Write the returned review to `<workspace>/final-review.md`
|
||||||
|
before dispatching any fix wave — the merge decision cites the artifact, not a
|
||||||
|
recollection.
|
||||||
|
|
||||||
If the final whole-branch review returns findings, dispatch ONE fix subagent
|
If the final whole-branch review returns findings, dispatch ONE fix subagent
|
||||||
with the complete findings list — not one fixer per finding.
|
with the complete findings list and the binding constraint values
|
||||||
|
verbatim — not one fixer per finding.
|
||||||
Per-finding fixers each rebuild context and re-run suites; a real
|
Per-finding fixers each rebuild context and re-run suites; a real
|
||||||
session's final-review fix wave cost more than all its tasks combined.
|
session's final-review fix wave cost more than all its tasks combined.
|
||||||
Then run exactly one scoped re-review of the fix wave
|
Then run exactly one scoped re-review of the fix wave
|
||||||
(`scripts/review-package PLAN_FILE FIX_BASE HEAD` over the fix range,
|
(`scripts/review-package PLAN_FILE FIX_BASE HEAD` over the fix range,
|
||||||
[re-review-prompt.md](re-review-prompt.md)).
|
[re-review-prompt.md](re-review-prompt.md)).
|
||||||
Adjudicate any residual findings as in the task loop's breaker: park with
|
Adjudicate any residual findings as in the task loop's breaker: park with
|
||||||
rulings, or stop on load-bearing ones. There is no second fix wave —
|
rulings, or stop on load-bearing ones. The same valve applies to
|
||||||
|
mechanical-constraint misses discovered at the end: non-load-bearing means
|
||||||
|
parked with a ruling, not a failed branch. There is no second fix wave —
|
||||||
residual load-bearing findings surface to your human partner when
|
residual load-bearing findings surface to your human partner when
|
||||||
finishing-a-development-branch presents the options.
|
finishing-a-development-branch presents the options.
|
||||||
|
|
||||||
@@ -440,7 +463,6 @@ Use superpowers:finishing-a-development-branch.
|
|||||||
| "The fix was small, skip the re-review" | Unreviewed fixes are how regressions land. Every round ends with a scoped re-review. |
|
| "The fix was small, skip the re-review" | Unreviewed fixes are how regressions land. Every round ends with a scoped re-review. |
|
||||||
| "Reviews slow the loop down" | The loop without reviews is just unverified churn. Reviews are the loop's brakes and steering. |
|
| "Reviews slow the loop down" | The loop without reviews is just unverified churn. Reviews are the loop's brakes and steering. |
|
||||||
| "Ledger bookkeeping is overhead" | The ledger is what survives compaction. Controllers without one have re-dispatched entire completed task sequences. |
|
| "Ledger bookkeeping is overhead" | The ledger is what survives compaction. Controllers without one have re-dispatched entire completed task sequences. |
|
||||||
| "The implementer spawned its own reviewer — free extra assurance" | It's a duplicate seat reviewing the same diff; the task review is the gate. A worker-spawned reviewer is a defect to flag, not rigor. |
|
|
||||||
|
|
||||||
## Example Workflow
|
## Example Workflow
|
||||||
|
|
||||||
|
|||||||
@@ -15,6 +15,12 @@ Subagent (general-purpose):
|
|||||||
Read your task brief first: [BRIEF_FILE]
|
Read your task brief first: [BRIEF_FILE]
|
||||||
It contains the full task text from the plan.
|
It contains the full task text from the plan.
|
||||||
|
|
||||||
|
## Binding Constraint Values
|
||||||
|
|
||||||
|
[CONSTRAINT_VALUES — the plan's mechanical constraints, pasted verbatim
|
||||||
|
by the dispatcher. If a rule here mandates an exact form (commit-message
|
||||||
|
text, naming, fixed literals), reproduce it exactly — never from memory.]
|
||||||
|
|
||||||
## Context
|
## Context
|
||||||
|
|
||||||
[Scene-setting: where this fits, dependencies, architectural context]
|
[Scene-setting: where this fits, dependencies, architectural context]
|
||||||
@@ -36,8 +42,12 @@ Subagent (general-purpose):
|
|||||||
2. Write tests (following TDD if task says to)
|
2. Write tests (following TDD if task says to)
|
||||||
3. Verify implementation works
|
3. Verify implementation works
|
||||||
4. Commit your work
|
4. Commit your work
|
||||||
5. Self-review (see below)
|
5. Immediately after each commit, verify it against the Binding Constraint
|
||||||
6. Report back
|
Values above (commit-message rules, naming rules, fixed literals) while
|
||||||
|
history is still local. A miss is cheap now — amend or forward-fix at
|
||||||
|
once — and expensive after your work is delivered.
|
||||||
|
6. Self-review (see below)
|
||||||
|
7. Report back
|
||||||
|
|
||||||
Work from: [directory]
|
Work from: [directory]
|
||||||
|
|
||||||
@@ -47,18 +57,6 @@ Subagent (general-purpose):
|
|||||||
While iterating, run the focused test for what you're changing; run the
|
While iterating, run the focused test for what you're changing; run the
|
||||||
full suite once before committing, not after every edit.
|
full suite once before committing, not after every edit.
|
||||||
|
|
||||||
## You Do Not Dispatch Subagents
|
|
||||||
|
|
||||||
Do all of this task's work yourself. Never spawn a subagent to
|
|
||||||
implement part of the task, and above all never spawn a reviewer to
|
|
||||||
check your work. Self-review (below) means reading your own diff.
|
|
||||||
Review is the controller's job: after you report, it dispatches a
|
|
||||||
fresh reviewer against your diff. A reviewer you spawn duplicates
|
|
||||||
that review at full cost, and its approval counts for nothing in
|
|
||||||
the process. If you catch yourself thinking "an independent review
|
|
||||||
would strengthen my report" — that review is already scheduled.
|
|
||||||
Report instead.
|
|
||||||
|
|
||||||
## Code Organization
|
## Code Organization
|
||||||
|
|
||||||
You reason best about code you can hold in context at once, and your edits are more
|
You reason best about code you can hold in context at once, and your edits are more
|
||||||
@@ -108,6 +106,10 @@ Subagent (general-purpose):
|
|||||||
- Did I only build what was requested?
|
- Did I only build what was requested?
|
||||||
- Did I follow existing patterns in the codebase?
|
- Did I follow existing patterns in the codebase?
|
||||||
|
|
||||||
|
**Constraints:**
|
||||||
|
- Does every commit message satisfy the Binding Constraint Values exactly?
|
||||||
|
- Did I reproduce mandated literals from the constraint text, not from memory?
|
||||||
|
|
||||||
**Testing:**
|
**Testing:**
|
||||||
- Do tests actually verify behavior (not just mock behavior)?
|
- Do tests actually verify behavior (not just mock behavior)?
|
||||||
- Did I follow TDD if required?
|
- Did I follow TDD if required?
|
||||||
@@ -116,6 +118,12 @@ Subagent (general-purpose):
|
|||||||
|
|
||||||
If you find issues during self-review, fix them now before reporting.
|
If you find issues during self-review, fix them now before reporting.
|
||||||
|
|
||||||
|
If a constraint violation is already in a landed commit you cannot safely
|
||||||
|
amend, forward-fix it in a new commit when possible; when it is not, report
|
||||||
|
the deviation explicitly with Status DONE_WITH_CONCERNS — never report the
|
||||||
|
task incomplete solely for a cosmetic miss on an otherwise green build.
|
||||||
|
Whether the deviation parks or blocks is the dispatching controller's call.
|
||||||
|
|
||||||
## After Review Findings
|
## After Review Findings
|
||||||
|
|
||||||
If the task review finds issues, you will be resumed with the findings.
|
If the task review finds issues, you will be resumed with the findings.
|
||||||
@@ -148,7 +156,8 @@ Subagent (general-purpose):
|
|||||||
If BLOCKED or NEEDS_CONTEXT, put the specifics in the final message
|
If BLOCKED or NEEDS_CONTEXT, put the specifics in the final message
|
||||||
itself — the controller acts on it directly.
|
itself — the controller acts on it directly.
|
||||||
|
|
||||||
Use DONE_WITH_CONCERNS if you completed the work but have doubts about correctness.
|
Use DONE_WITH_CONCERNS if you completed the work but have doubts about correctness, or
|
||||||
|
when you are reporting a known deviation you could not safely fix.
|
||||||
Use BLOCKED if you cannot complete the task. Use NEEDS_CONTEXT if you need
|
Use BLOCKED if you cannot complete the task. Use NEEDS_CONTEXT if you need
|
||||||
information that wasn't provided. Never silently produce work you're unsure about.
|
information that wasn't provided. Never silently produce work you're unsure about.
|
||||||
```
|
```
|
||||||
|
|||||||
@@ -43,15 +43,6 @@ Subagent (general-purpose):
|
|||||||
Your review is read-only on this checkout. Do not mutate the working
|
Your review is read-only on this checkout. Do not mutate the working
|
||||||
tree, the index, HEAD, or branch state in any way.
|
tree, the index, HEAD, or branch state in any way.
|
||||||
|
|
||||||
## You Do Not Dispatch Subagents
|
|
||||||
|
|
||||||
Do all of this review yourself. Never spawn a subagent to review part
|
|
||||||
of the diff, and never spawn another reviewer for a second opinion.
|
|
||||||
This process already provides every review seat the work gets; a
|
|
||||||
reviewer you spawn duplicates one of them at full cost, and its
|
|
||||||
verdict counts for nothing. If the diff feels too large for one
|
|
||||||
pass, review it in passes yourself and say so in your report.
|
|
||||||
|
|
||||||
## Scope
|
## Scope
|
||||||
|
|
||||||
Your scope is the findings list and the fix diff. Verdict every finding.
|
Your scope is the findings list and the fix diff. Verdict every finding.
|
||||||
|
|||||||
@@ -52,15 +52,6 @@ Subagent (general-purpose):
|
|||||||
Your review is read-only on this checkout. Do not mutate the working
|
Your review is read-only on this checkout. Do not mutate the working
|
||||||
tree, the index, HEAD, or branch state in any way.
|
tree, the index, HEAD, or branch state in any way.
|
||||||
|
|
||||||
## You Do Not Dispatch Subagents
|
|
||||||
|
|
||||||
Do all of this review yourself. Never spawn a subagent to review part
|
|
||||||
of the diff, and never spawn another reviewer for a second opinion.
|
|
||||||
This process already provides every review seat the work gets; a
|
|
||||||
reviewer you spawn duplicates one of them at full cost, and its
|
|
||||||
verdict counts for nothing. If the diff feels too large for one
|
|
||||||
pass, review it in passes yourself and say so in your report.
|
|
||||||
|
|
||||||
## Do Not Trust the Report
|
## Do Not Trust the Report
|
||||||
|
|
||||||
Treat the implementer's report as unverified claims about the code. It
|
Treat the implementer's report as unverified claims about the code. It
|
||||||
|
|||||||
@@ -18,18 +18,9 @@ echo "🔍 Searching for test that creates: $POLLUTION_CHECK"
|
|||||||
echo "Test pattern: $TEST_PATTERN"
|
echo "Test pattern: $TEST_PATTERN"
|
||||||
echo ""
|
echo ""
|
||||||
|
|
||||||
# Get list of test files (find . emits ./-prefixed paths, so accept the
|
# Get list of test files
|
||||||
# pattern written with or without a leading ./)
|
TEST_FILES=$(find . -path "$TEST_PATTERN" | sort)
|
||||||
TEST_PATTERN="${TEST_PATTERN#./}"
|
TOTAL=$(echo "$TEST_FILES" | wc -l | tr -d ' ')
|
||||||
# find -path can't match '**/' against zero directory levels, so a pattern
|
|
||||||
# like src/**/*.test.ts would skip src/top.test.ts; also try the pattern
|
|
||||||
# with '**/' collapsed to cover files directly under the base directory.
|
|
||||||
TEST_FILES=$(find . \( -path "./$TEST_PATTERN" -o -path "./${TEST_PATTERN//\*\*\//}" \) | sort -u)
|
|
||||||
if [ -z "$TEST_FILES" ]; then
|
|
||||||
TOTAL=0
|
|
||||||
else
|
|
||||||
TOTAL=$(printf '%s\n' "$TEST_FILES" | wc -l | tr -d ' ')
|
|
||||||
fi
|
|
||||||
|
|
||||||
echo "Found $TOTAL test files"
|
echo "Found $TOTAL test files"
|
||||||
echo ""
|
echo ""
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ Skills speak in actions ("dispatch a subagent", "create a todo", "read a file").
|
|||||||
|
|
||||||
| Action skills request | Antigravity CLI equivalent |
|
| Action skills request | Antigravity CLI equivalent |
|
||||||
|----------------------|----------------------|
|
|----------------------|----------------------|
|
||||||
| Dispatch a subagent (`Subagent (general-purpose):` template) | `invoke_subagent` with a built-in `TypeName` — `self` for full-capability work, `research` for read-only |
|
| Dispatch a subagent (`Subagent (general-purpose):` template) | `invoke_subagent` with a built-in `TypeName` — `self` for full-capability work, `research` for read-only (see [Subagent support](#subagent-support)) |
|
||||||
| Task tracking ("create a todo", "mark complete") | a **task artifact** — `write_to_file` with `IsArtifact: true` and `ArtifactType: "task"` (see [Task tracking](#task-tracking)). **Not** `manage_task`, which manages background processes. |
|
| Task tracking ("create a todo", "mark complete") | a **task artifact** — `write_to_file` with `IsArtifact: true` and `ArtifactType: "task"` (see [Task tracking](#task-tracking)). **Not** `manage_task`, which manages background processes. |
|
||||||
|
|
||||||
## Task tracking
|
## Task tracking
|
||||||
|
|||||||
@@ -71,7 +71,11 @@ independently testable deliverable.
|
|||||||
[The spec's project-wide requirements — version floors, dependency limits,
|
[The spec's project-wide requirements — version floors, dependency limits,
|
||||||
naming and copy rules, platform requirements — one line each, with exact
|
naming and copy rules, platform requirements — one line each, with exact
|
||||||
values copied verbatim from the spec. Every task's requirements implicitly
|
values copied verbatim from the spec. Every task's requirements implicitly
|
||||||
include this section.]
|
include this section. Three things may never enter it: cosmetic absolutes
|
||||||
|
on every commit (a fixed trailer or byline the work does not need), your
|
||||||
|
own identity or model name promoted into a rule, and environment
|
||||||
|
constraints (versions, platforms, paths) you have not verified against the
|
||||||
|
environment the plan will execute in.]
|
||||||
|
|
||||||
---
|
---
|
||||||
```
|
```
|
||||||
@@ -125,6 +129,8 @@ git commit -m "feat: add specific feature"
|
|||||||
```
|
```
|
||||||
````
|
````
|
||||||
|
|
||||||
|
Commit messages describe the change. Never mandate session boilerplate — trailers, bylines, model names — as a per-commit rule; what your session stamps on its commits is not a requirement of the work.
|
||||||
|
|
||||||
## No Placeholders
|
## No Placeholders
|
||||||
|
|
||||||
Every step must contain the actual content an engineer needs. These are **plan failures** — never write them:
|
Every step must contain the actual content an engineer needs. These are **plan failures** — never write them:
|
||||||
@@ -145,6 +151,8 @@ After writing the complete plan, look at the spec with fresh eyes and check the
|
|||||||
|
|
||||||
**3. Type consistency:** Do the types, method signatures, and property names you used in later tasks match what you defined in earlier tasks? A function called `clearLayers()` in Task 3 but `clearFullLayers()` in Task 7 is a bug.
|
**3. Type consistency:** Do the types, method signatures, and property names you used in later tasks match what you defined in earlier tasks? A function called `clearLayers()` in Task 3 but `clearFullLayers()` in Task 7 is a bug.
|
||||||
|
|
||||||
|
**4. Constraint hygiene:** Does any Global Constraint mandate a per-commit cosmetic absolute, name the authoring model or session, or assert an environment fact (version floor, platform, path) you did not verify? Cut or verify it.
|
||||||
|
|
||||||
If you find issues, fix them inline. No need to re-review — just fix and move on. If you find a spec requirement with no task, add the task.
|
If you find issues, fix them inline. No need to re-review — just fix and move on. If you find a spec requirement with no task, add the task.
|
||||||
|
|
||||||
## Execution Handoff
|
## Execution Handoff
|
||||||
|
|||||||
@@ -1,90 +0,0 @@
|
|||||||
#!/usr/bin/env bash
|
|
||||||
set -euo pipefail
|
|
||||||
|
|
||||||
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
||||||
REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
|
|
||||||
SCRIPT_UNDER_TEST="$REPO_ROOT/skills/systematic-debugging/find-polluter.sh"
|
|
||||||
|
|
||||||
FAILURES=0
|
|
||||||
TEST_ROOT="$(mktemp -d)"
|
|
||||||
|
|
||||||
cleanup() {
|
|
||||||
rm -rf "$TEST_ROOT"
|
|
||||||
}
|
|
||||||
trap cleanup EXIT
|
|
||||||
|
|
||||||
pass() {
|
|
||||||
echo " [PASS] $1"
|
|
||||||
}
|
|
||||||
|
|
||||||
fail() {
|
|
||||||
echo " [FAIL] $1"
|
|
||||||
FAILURES=$((FAILURES + 1))
|
|
||||||
}
|
|
||||||
|
|
||||||
assert_contains() {
|
|
||||||
local haystack="$1"
|
|
||||||
local needle="$2"
|
|
||||||
local description="$3"
|
|
||||||
|
|
||||||
if printf '%s' "$haystack" | grep -Fq -- "$needle"; then
|
|
||||||
pass "$description"
|
|
||||||
else
|
|
||||||
fail "$description (expected output to contain: $needle)"
|
|
||||||
fi
|
|
||||||
}
|
|
||||||
|
|
||||||
# Toy project: one top-level test, one nested test. A stubbed `npm` on PATH
|
|
||||||
# creates the pollution marker whenever any test runs, so the first test file
|
|
||||||
# executed is always identified as the polluter.
|
|
||||||
setup_project() {
|
|
||||||
PROJECT="$TEST_ROOT/project"
|
|
||||||
rm -rf "$PROJECT"
|
|
||||||
mkdir -p "$PROJECT/src/feature" "$PROJECT/bin"
|
|
||||||
echo "test('top')" > "$PROJECT/src/top.test.ts"
|
|
||||||
echo "test('nested')" > "$PROJECT/src/feature/nested.test.ts"
|
|
||||||
cat > "$PROJECT/bin/npm" <<'EOF'
|
|
||||||
#!/usr/bin/env bash
|
|
||||||
touch pollution.marker
|
|
||||||
EOF
|
|
||||||
chmod +x "$PROJECT/bin/npm"
|
|
||||||
}
|
|
||||||
|
|
||||||
# run_polluter <pattern> — runs the script in the toy project with the stub
|
|
||||||
# npm first on PATH; captures combined output, never aborts on exit code.
|
|
||||||
run_polluter() {
|
|
||||||
local pattern="$1"
|
|
||||||
rm -f "$PROJECT/pollution.marker"
|
|
||||||
(
|
|
||||||
cd "$PROJECT"
|
|
||||||
PATH="$PROJECT/bin:$PATH" "$SCRIPT_UNDER_TEST" 'pollution.marker' "$pattern" 2>&1
|
|
||||||
) || true
|
|
||||||
}
|
|
||||||
|
|
||||||
echo "Test: documented pattern finds nested test files (issue #2008)"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "FOUND POLLUTER" "documented pattern runs tests and detects pollution"
|
|
||||||
|
|
||||||
echo "Test: documented pattern also finds top-level test files"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 2 test files" "src/**/*.test.ts matches src/top.test.ts and src/feature/nested.test.ts"
|
|
||||||
|
|
||||||
echo "Test: ./-prefixed pattern matches the same files"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter './src/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 2 test files" "leading ./ on the pattern is accepted"
|
|
||||||
|
|
||||||
echo "Test: non-matching pattern reports an honest zero"
|
|
||||||
setup_project
|
|
||||||
OUTPUT="$(run_polluter 'nomatch/**/*.test.ts')"
|
|
||||||
assert_contains "$OUTPUT" "Found 0 test files" "empty result counts as 0, not 1"
|
|
||||||
assert_contains "$OUTPUT" "No polluter found" "empty result exits via the clean path"
|
|
||||||
|
|
||||||
echo ""
|
|
||||||
if [ "$FAILURES" -gt 0 ]; then
|
|
||||||
echo "$FAILURES test(s) failed"
|
|
||||||
exit 1
|
|
||||||
fi
|
|
||||||
echo "All tests passed"
|
|
||||||
Reference in New Issue
Block a user