mirror of
https://github.com/obra/superpowers.git
synced 2026-08-04 05:08:46 +08:00
Compare commits
1 Commits
fix/x6a-sd
...
fix/x9a-sd
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
39f9602432 |
@@ -14,7 +14,21 @@ Execute plan by dispatching a fresh implementer subagent per task, a task review
|
|||||||
**Narration:** between tool calls, narrate at most one short line — the
|
**Narration:** between tool calls, narrate at most one short line — the
|
||||||
ledger and the tool results carry the record.
|
ledger and the tool results carry the record.
|
||||||
|
|
||||||
**Continuous execution:** Do not pause to check in with your human partner between tasks. Execute all tasks from the plan without stopping. The only reasons to stop are: BLOCKED status you cannot resolve, ambiguity that genuinely prevents progress, or all tasks complete. "Should I continue?" prompts and progress summaries waste their time — they asked you to execute the plan, so execute it.
|
**Continuous execution:** Do not pause to check in with your human partner between tasks. Execute all tasks from the plan without stopping. The only reasons to stop are the four named below, or all tasks complete. "Should I continue?" prompts and progress summaries waste their time — they asked you to execute the plan, so execute it.
|
||||||
|
|
||||||
|
**Rulings, not stalls.** A running plan does not wait on a human. Conflicts,
|
||||||
|
ambiguities, plan defects, a cap you would have asked to exceed — decide
|
||||||
|
them. The spec is the binding authority, the plan is its argument, and your
|
||||||
|
judgment settles what neither answers. Record every decision in the ledger as
|
||||||
|
`Ruling: <what you decided> — <why> — <what it costs if wrong>`, and keep
|
||||||
|
going. A wrong ruling costs rework your human partner can see and undo; a
|
||||||
|
session parked on a question costs their whole day and buys nothing.
|
||||||
|
|
||||||
|
Four things stop you, and only these: an irreversible or destructive
|
||||||
|
operation; a security-sensitive action; a side effect outside this worktree
|
||||||
|
that norms say you ask about first (a merge, a push to a shared branch, a
|
||||||
|
publish); and a plan so broken that every path forward is a guess. For those,
|
||||||
|
stop and ask.
|
||||||
|
|
||||||
## When to Use
|
## When to Use
|
||||||
|
|
||||||
@@ -57,14 +71,14 @@ digraph process {
|
|||||||
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" [shape=box];
|
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" [shape=box];
|
||||||
"Spec ✅ and quality approved?" [shape=diamond];
|
"Spec ✅ and quality approved?" [shape=diamond];
|
||||||
"Finding conflicts with plan text?" [shape=diamond];
|
"Finding conflicts with plan text?" [shape=diamond];
|
||||||
"Ask human partner which governs" [shape=box];
|
"Rule on the conflict, ledger the ruling" [shape=box];
|
||||||
"Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [shape=box];
|
"Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [shape=box];
|
||||||
"Dispatch scoped re-review (./re-review-prompt.md)" [shape=box];
|
"Dispatch scoped re-review (./re-review-prompt.md)" [shape=box];
|
||||||
"All findings addressed?" [shape=diamond];
|
"All findings addressed?" [shape=diamond];
|
||||||
"R = 5?" [shape=diamond];
|
"R = 5?" [shape=diamond];
|
||||||
"Adjudicate each open finding" [shape=box];
|
"Adjudicate each open finding" [shape=box];
|
||||||
"Any load-bearing finding?" [shape=diamond];
|
"Any load-bearing finding?" [shape=diamond];
|
||||||
"STOP: report BLOCKED to human partner" [shape=box];
|
"Rule and continue; stop only if every path forward is a guess" [shape=box];
|
||||||
"Park findings in ledger with rulings" [shape=box];
|
"Park findings in ledger with rulings" [shape=box];
|
||||||
"Append completion to ledger, mark todo complete" [shape=box];
|
"Append completion to ledger, mark todo complete" [shape=box];
|
||||||
}
|
}
|
||||||
@@ -85,8 +99,8 @@ digraph process {
|
|||||||
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" -> "Spec ✅ and quality approved?";
|
"Generate review package, dispatch task reviewer (./task-reviewer-prompt.md)" -> "Spec ✅ and quality approved?";
|
||||||
"Spec ✅ and quality approved?" -> "Append completion to ledger, mark todo complete" [label="yes"];
|
"Spec ✅ and quality approved?" -> "Append completion to ledger, mark todo complete" [label="yes"];
|
||||||
"Spec ✅ and quality approved?" -> "Finding conflicts with plan text?" [label="no"];
|
"Spec ✅ and quality approved?" -> "Finding conflicts with plan text?" [label="no"];
|
||||||
"Finding conflicts with plan text?" -> "Ask human partner which governs" [label="yes"];
|
"Finding conflicts with plan text?" -> "Rule on the conflict, ledger the ruling" [label="yes"];
|
||||||
"Ask human partner which governs" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model";
|
"Rule on the conflict, ledger the ruling" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model";
|
||||||
"Finding conflicts with plan text?" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [label="no"];
|
"Finding conflicts with plan text?" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [label="no"];
|
||||||
"Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" -> "Dispatch scoped re-review (./re-review-prompt.md)";
|
"Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" -> "Dispatch scoped re-review (./re-review-prompt.md)";
|
||||||
"Dispatch scoped re-review (./re-review-prompt.md)" -> "All findings addressed?";
|
"Dispatch scoped re-review (./re-review-prompt.md)" -> "All findings addressed?";
|
||||||
@@ -95,7 +109,7 @@ digraph process {
|
|||||||
"R = 5?" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [label="no - next round"];
|
"R = 5?" -> "Fix round R of 5: R≤3 resume implementer; R≥4 fresh implementer, more capable model" [label="no - next round"];
|
||||||
"R = 5?" -> "Adjudicate each open finding" [label="yes - breaker trips"];
|
"R = 5?" -> "Adjudicate each open finding" [label="yes - breaker trips"];
|
||||||
"Adjudicate each open finding" -> "Any load-bearing finding?";
|
"Adjudicate each open finding" -> "Any load-bearing finding?";
|
||||||
"Any load-bearing finding?" -> "STOP: report BLOCKED to human partner" [label="yes"];
|
"Any load-bearing finding?" -> "Rule and continue; stop only if every path forward is a guess" [label="yes"];
|
||||||
"Any load-bearing finding?" -> "Park findings in ledger with rulings" [label="no"];
|
"Any load-bearing finding?" -> "Park findings in ledger with rulings" [label="no"];
|
||||||
"Park findings in ledger with rulings" -> "Append completion to ledger, mark todo complete";
|
"Park findings in ledger with rulings" -> "Append completion to ledger, mark todo complete";
|
||||||
"Append completion to ledger, mark todo complete" -> "More tasks remain?";
|
"Append completion to ledger, mark todo complete" -> "More tasks remain?";
|
||||||
@@ -148,9 +162,8 @@ Before dispatching Task 1, scan the plan once for conflicts:
|
|||||||
- anything the plan explicitly mandates that the review rubric treats as a
|
- anything the plan explicitly mandates that the review rubric treats as a
|
||||||
defect (a test that asserts nothing, verbatim duplication of a logic block)
|
defect (a test that asserts nothing, verbatim duplication of a logic block)
|
||||||
|
|
||||||
Present everything you find to your human partner as one batched question —
|
Rule on everything you find before execution begins — each finding against
|
||||||
each finding beside the plan text that mandates it, asking which governs —
|
the plan text that mandates it — and record each ruling in the ledger. If the
|
||||||
before execution begins, not one interrupt per discovery mid-plan. If the
|
|
||||||
scan is clean, proceed without comment. The review loop remains the net for
|
scan is clean, proceed without comment. The review loop remains the net for
|
||||||
conflicts that only emerge from implementation.
|
conflicts that only emerge from implementation.
|
||||||
|
|
||||||
@@ -245,7 +258,7 @@ Implementer subagents report one of four statuses. Handle each appropriately:
|
|||||||
1. If it's a context problem, provide more context and re-dispatch with the same model
|
1. If it's a context problem, provide more context and re-dispatch with the same model
|
||||||
2. If the task requires more reasoning, re-dispatch with a more capable model
|
2. If the task requires more reasoning, re-dispatch with a more capable model
|
||||||
3. If the task is too large, break it into smaller pieces
|
3. If the task is too large, break it into smaller pieces
|
||||||
4. If the plan itself is wrong, escalate to the human
|
4. If the plan itself is wrong, rule on the correction, ledger it, and re-dispatch with the ruling carried in the dispatch
|
||||||
|
|
||||||
**Never** ignore an escalation or force the same model to retry without changes. If the implementer said it's stuck, something needs to change.
|
**Never** ignore an escalation or force the same model to retry without changes. If the implementer said it's stuck, something needs to change.
|
||||||
|
|
||||||
@@ -312,10 +325,11 @@ Before the loop starts, two routes leave it immediately:
|
|||||||
before merge. A roll-up nobody reads is a silent discard. Minor findings
|
before merge. A roll-up nobody reads is a silent discard. Minor findings
|
||||||
never enter the loop.
|
never enter the loop.
|
||||||
- A finding labeled plan-mandated — or any finding that conflicts with
|
- A finding labeled plan-mandated — or any finding that conflicts with
|
||||||
what the plan's text requires — is the human's decision, like any plan
|
what the plan's text requires — is yours to rule on: weigh the finding
|
||||||
contradiction: present the finding and the plan text, ask which governs.
|
against the plan text, decide with the spec as the binding authority, and
|
||||||
Do not dismiss the finding because the plan mandates it, and do not
|
ledger the ruling before you act on it. Do not dismiss the finding because
|
||||||
dispatch a fix that contradicts the plan without asking.
|
the plan mandates it, and do not dispatch a fix that contradicts the plan
|
||||||
|
without a recorded ruling.
|
||||||
Everything else enters the loop. A fix round is one fix dispatch plus one
|
Everything else enters the loop. A fix round is one fix dispatch plus one
|
||||||
scoped re-review. Five rounds maximum per task:
|
scoped re-review. Five rounds maximum per task:
|
||||||
|
|
||||||
@@ -365,10 +379,11 @@ the cross-task context the reviewer lacks:
|
|||||||
- **Real, but nothing downstream builds on it:** park it the same way, with
|
- **Real, but nothing downstream builds on it:** park it the same way, with
|
||||||
a ruling that says it's real and deferred.
|
a ruling that says it's real and deferred.
|
||||||
- **Real and load-bearing** — a later task builds on it, or it reveals a
|
- **Real and load-bearing** — a later task builds on it, or it reveals a
|
||||||
plan defect: STOP. Append `Task <N>: BLOCKED — <reason>` and report to
|
plan defect: rule on the smallest change that unblocks the dependent work,
|
||||||
your human partner with the finding, the plan text it collides with, and
|
ledger it as `Task <N>: ruling — <finding> — <what you decided and why>`,
|
||||||
the fix history. Parking a structural failure lets every dependent task
|
and carry it into the next task's dispatch. Parking a structural failure
|
||||||
build on it and hands the final review a problem it cannot fix either.
|
silently lets every dependent task build on it. Stop only when the defect
|
||||||
|
leaves every path forward a guess.
|
||||||
|
|
||||||
Adjudicate only at the cap. Adjudicating earlier to end a loop is
|
Adjudicate only at the cap. Adjudicating earlier to end a loop is
|
||||||
pre-judging with a different name. Every adjudication is a ledger entry —
|
pre-judging with a different name. Every adjudication is a ledger entry —
|
||||||
@@ -409,12 +424,20 @@ Then run exactly one scoped re-review of the fix wave
|
|||||||
(`scripts/review-package PLAN_FILE FIX_BASE HEAD` over the fix range,
|
(`scripts/review-package PLAN_FILE FIX_BASE HEAD` over the fix range,
|
||||||
[re-review-prompt.md](re-review-prompt.md)).
|
[re-review-prompt.md](re-review-prompt.md)).
|
||||||
Adjudicate any residual findings as in the task loop's breaker: park with
|
Adjudicate any residual findings as in the task loop's breaker: park with
|
||||||
rulings, or stop on load-bearing ones. There is no second fix wave —
|
rulings, or rule on the load-bearing ones and ledger what you decided. Only
|
||||||
|
the four classes above stop you here. There is no second fix wave —
|
||||||
residual load-bearing findings surface to your human partner when
|
residual load-bearing findings surface to your human partner when
|
||||||
finishing-a-development-branch presents the options.
|
finishing-a-development-branch presents the options.
|
||||||
|
|
||||||
## Finish
|
## Finish
|
||||||
|
|
||||||
|
Before you delete anything, collect every `Ruling:` line from the ledger into
|
||||||
|
your final message under "Rulings I made", in the order you made them, each
|
||||||
|
with what it costs if wrong. That list is the only place the decisions you
|
||||||
|
took on your human partner's behalf reach them — they read it and rework
|
||||||
|
whatever you got wrong. A ruling that dies with the workspace was a decision
|
||||||
|
made in secret.
|
||||||
|
|
||||||
When the final whole-branch review is clean and its fixes are merged,
|
When the final whole-branch review is clean and its fixes are merged,
|
||||||
delete this plan's workspace (`rm -rf <workspace>`) — the git history is
|
delete this plan's workspace (`rm -rf <workspace>`) — the git history is
|
||||||
the record now. Sibling directories belong to other plans; leave them
|
the record now. Sibling directories belong to other plans; leave them
|
||||||
|
|||||||
Reference in New Issue
Block a user