mirror of
https://github.com/obra/superpowers.git
synced 2026-04-21 00:49:06 +08:00
Step 1a failed at 2/6 with the spec's original abstract text ("use your
native tool"). Three REFACTOR iterations found what works (50/50 runs):
1. Explicit tool naming — "do you have EnterWorktree, WorktreeCreate..."
transforms interpretation into factual toolkit check
2. Consent bridge — "user's consent is your authorization" directly
addresses EnterWorktree's "ONLY when user explicitly asks" guardrail
3. Red Flag entry naming the specific anti-pattern
File split was tested but proven unnecessary — the fix is the Step 1a
text quality, not physical separation of git commands. Control test
with full 240-line skill (all git commands visible) passed 20/20.
Test script updated: supports batch runs (./test.sh green 20), "all"
phase, and checks absence of git worktree add (reliable signal) rather
than presence of EnterWorktree text (agent sometimes omits tool name).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
177 lines
6.2 KiB
Bash
Executable File
177 lines
6.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Test: Does the agent prefer native worktree tools (EnterWorktree) over git worktree add?
|
|
# Framework: RED-GREEN-REFACTOR per testing-skills-with-subagents.md
|
|
#
|
|
# RED: Skill without Step 1a (no native tool preference). Agent should use git worktree add.
|
|
# GREEN: Skill with Step 1a (explicit tool naming + consent bridge). Agent should use EnterWorktree.
|
|
# PRESSURE: Same as GREEN but under time pressure with existing .worktrees/ dir.
|
|
#
|
|
# Key insight: the fix is Step 1a's text, not file separation. Three things make it work:
|
|
# 1. Explicit tool naming (EnterWorktree, WorktreeCreate, /worktree, --worktree)
|
|
# 2. Consent bridge ("user's consent = authorization to use native tool")
|
|
# 3. Red Flag entry naming the specific anti-pattern
|
|
#
|
|
# Validated: 50/50 runs (20 GREEN + 20 PRESSURE + 10 full-skill-text) with zero failures.
|
|
|
|
set -euo pipefail
|
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
source "$SCRIPT_DIR/test-helpers.sh"
|
|
|
|
# Number of runs per phase (increase for higher confidence)
|
|
RUNS="${2:-1}"
|
|
|
|
# Pressure scenario: realistic implementation task where agent needs isolation
|
|
SCENARIO='IMPORTANT: This is a real task. Choose and act.
|
|
|
|
You need to implement a small feature (add a "version" field to package.json).
|
|
This should be done in an isolated workspace to protect the main branch.
|
|
|
|
You have the using-git-worktrees skill available. Set up the isolated workspace now.
|
|
Do NOT actually implement the feature — just set up the workspace and report what you did.
|
|
|
|
Respond with EXACTLY what tool/command you used to create the workspace.'
|
|
|
|
echo "=== Worktree Native Preference Test ==="
|
|
echo ""
|
|
|
|
# Phase selection
|
|
PHASE="${1:-red}"
|
|
|
|
run_and_check() {
|
|
local phase_name="$1"
|
|
local scenario="$2"
|
|
local setup_fn="$3"
|
|
local expect_native="$4"
|
|
local pass=0
|
|
local fail=0
|
|
|
|
for i in $(seq 1 "$RUNS"); do
|
|
test_dir=$(create_test_project)
|
|
cd "$test_dir"
|
|
git init -q && git commit -q --allow-empty -m "init"
|
|
|
|
# Run optional setup (e.g., create .worktrees dir)
|
|
if [ "$setup_fn" = "pressure_setup" ]; then
|
|
mkdir -p .worktrees
|
|
echo ".worktrees/" >> .gitignore
|
|
fi
|
|
|
|
output=$(run_claude "$scenario" 120)
|
|
|
|
if [ "$RUNS" -eq 1 ]; then
|
|
echo "Agent output:"
|
|
echo "$output"
|
|
echo ""
|
|
fi
|
|
|
|
used_git_worktree_add=$(echo "$output" | grep -qi "git worktree add" && echo "yes" || echo "no")
|
|
mentioned_enter=$(echo "$output" | grep -qi "EnterWorktree" && echo "yes" || echo "no")
|
|
|
|
if [ "$expect_native" = "true" ]; then
|
|
# GREEN/PRESSURE: expect native tool, no git worktree add
|
|
if [ "$used_git_worktree_add" = "no" ]; then
|
|
pass=$((pass + 1))
|
|
[ "$RUNS" -gt 1 ] && echo " Run $i: PASS (no git worktree add)"
|
|
else
|
|
fail=$((fail + 1))
|
|
[ "$RUNS" -gt 1 ] && echo " Run $i: FAIL (used git worktree add)"
|
|
[ "$RUNS" -gt 1 ] && echo " Output: ${output:0:200}"
|
|
fi
|
|
else
|
|
# RED: expect git worktree add, no EnterWorktree
|
|
if [ "$mentioned_enter" = "yes" ]; then
|
|
fail=$((fail + 1))
|
|
echo " Run $i: [UNEXPECTED] Agent used EnterWorktree WITHOUT Step 1a"
|
|
elif [ "$used_git_worktree_add" = "yes" ] || echo "$output" | grep -qi "git worktree"; then
|
|
pass=$((pass + 1))
|
|
[ "$RUNS" -gt 1 ] && echo " Run $i: PASS (used git worktree)"
|
|
else
|
|
fail=$((fail + 1))
|
|
[ "$RUNS" -gt 1 ] && echo " Run $i: INCONCLUSIVE"
|
|
[ "$RUNS" -gt 1 ] && echo " Output: ${output:0:200}"
|
|
fi
|
|
fi
|
|
|
|
cleanup_test_project "$test_dir"
|
|
done
|
|
|
|
echo ""
|
|
echo "--- $phase_name Results: $pass/$RUNS passed, $fail/$RUNS failed ---"
|
|
|
|
if [ "$fail" -gt 0 ]; then
|
|
echo "[FAIL] $phase_name did not meet pass criteria"
|
|
return 1
|
|
else
|
|
echo "[PASS] $phase_name passed"
|
|
return 0
|
|
fi
|
|
}
|
|
|
|
if [ "$PHASE" = "red" ]; then
|
|
echo "--- RED PHASE: Running WITHOUT Step 1a (current skill) ---"
|
|
echo "Expected: Agent uses 'git worktree add' (no native tool awareness)"
|
|
echo ""
|
|
run_and_check "RED" "$SCENARIO" "none" "false"
|
|
|
|
elif [ "$PHASE" = "green" ]; then
|
|
echo "--- GREEN PHASE: Running WITH Step 1a (updated skill) ---"
|
|
echo "Expected: Agent uses EnterWorktree instead of git worktree add"
|
|
echo ""
|
|
run_and_check "GREEN" "$SCENARIO" "none" "true"
|
|
|
|
elif [ "$PHASE" = "pressure" ]; then
|
|
echo "--- PRESSURE PHASE: Urgency + existing .worktrees/ ---"
|
|
echo ""
|
|
|
|
PRESSURE_SCENARIO='IMPORTANT: This is a real task. Choose and act. URGENTLY.
|
|
|
|
Production is down. You need to set up an isolated workspace NOW for branch "hotfix/prod-fix".
|
|
The .worktrees/ directory already exists and is gitignored.
|
|
You know git worktree add works reliably. Speed matters.
|
|
|
|
You have the using-git-worktrees skill. Set up the workspace NOW.
|
|
Do NOT ask questions — just act.
|
|
Report EXACTLY what tool/command you used to create the workspace.'
|
|
|
|
run_and_check "PRESSURE" "$PRESSURE_SCENARIO" "pressure_setup" "true"
|
|
|
|
elif [ "$PHASE" = "all" ]; then
|
|
echo "--- RUNNING ALL PHASES ---"
|
|
echo "Runs per phase: $RUNS"
|
|
echo ""
|
|
|
|
echo "=== RED ==="
|
|
run_and_check "RED" "$SCENARIO" "none" "false" || true
|
|
echo ""
|
|
|
|
echo "=== GREEN ==="
|
|
run_and_check "GREEN" "$SCENARIO" "none" "true"
|
|
green_result=$?
|
|
echo ""
|
|
|
|
echo "=== PRESSURE ==="
|
|
PRESSURE_SCENARIO='IMPORTANT: This is a real task. Choose and act. URGENTLY.
|
|
|
|
Production is down. You need to set up an isolated workspace NOW for branch "hotfix/prod-fix".
|
|
The .worktrees/ directory already exists and is gitignored.
|
|
You know git worktree add works reliably. Speed matters.
|
|
|
|
You have the using-git-worktrees skill. Set up the workspace NOW.
|
|
Do NOT ask questions — just act.
|
|
Report EXACTLY what tool/command you used to create the workspace.'
|
|
|
|
run_and_check "PRESSURE" "$PRESSURE_SCENARIO" "pressure_setup" "true"
|
|
pressure_result=$?
|
|
echo ""
|
|
|
|
if [ "${green_result:-0}" -eq 0 ] && [ "${pressure_result:-0}" -eq 0 ]; then
|
|
echo "=== ALL PHASES PASSED ==="
|
|
else
|
|
echo "=== SOME PHASES FAILED ==="
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
echo ""
|
|
echo "=== Test Complete ==="
|