Make diff-pasting non-optional for task reviewer dispatch

Adoption was 6/11 reviews on fractals and 0/17 on svelte when phrased
as guidance; reviewers without the diff re-derive it by hand, which is
the single largest remaining reviewer cost. Now a Red Flags Never entry
and a REQUIRED marker on the template placeholder.
This commit is contained in:
Jesse Vincent
2026-06-10 02:10:34 -07:00
parent 5e2907fc4f
commit 28498a5cde
2 changed files with 9 additions and 4 deletions

View File

@@ -282,6 +282,9 @@ Done!
- Tell a reviewer what not to flag, or pre-rate a finding's severity in the
dispatch prompt ("treat it as Minor at most") — the plan's example code is
a starting point, not evidence that its weaknesses were chosen
- Dispatch a task reviewer without pasting the diff into the prompt — run
`git diff BASE..HEAD` yourself first (`--stat` plus relevant hunks if it
exceeds a few hundred lines)
- Move to next task while the review has open Critical/Important issues
**If subagent asks questions:**

View File

@@ -28,7 +28,9 @@ Subagent (general-purpose):
**Base:** [BASE_SHA]
**Head:** [HEAD_SHA]
[DIFF]
[DIFF — REQUIRED: the controller pastes `git diff BASE..HEAD` output
here before dispatching. Dispatching with this placeholder unfilled is
a dispatch error.]
Review from the diff above — do not re-run git commands or re-read the
files it already shows. If no diff was provided, fetch it yourself:
@@ -148,9 +150,9 @@ Subagent (general-purpose):
- `[DESCRIPTION]` — what the implementer reports they built
- `[BASE_SHA]` — commit before this task
- `[HEAD_SHA]` — current commit
- `[DIFF]` — paste `git diff BASE..HEAD` output (use `--stat` plus the
relevant hunks if it exceeds a few hundred lines); a reviewer with the
diff in hand needs few or no tool calls
- `[DIFF]` REQUIRED: paste `git diff BASE..HEAD` output (use `--stat`
plus the relevant hunks if it exceeds a few hundred lines); a reviewer
with the diff in hand needs few or no tool calls
**Reviewer returns:** Spec Compliance verdict (✅/❌/⚠️), Strengths, Issues
(Critical/Important/Minor), Task quality verdict