Red Flags: never tell a reviewer what not to flag or pre-rate severity

Second observed instance: with the Constructing Reviewer Prompts rule
already live, a controller still wrote 'do not treat that duplication as
a defect to fix — the plan chose it; you may note it as a Minor
observation at most' into a quality reviewer dispatch, fabricating plan
intent from the plan's example snippet. Promote the rule to the Red
Flags Never list and name the rationalization.
This commit is contained in:
Jesse Vincent
2026-06-09 21:47:41 -07:00
parent c7900f1698
commit 83d54f7ddd

View File

@@ -281,6 +281,9 @@ Done!
- Accept "close enough" on spec compliance (spec reviewer found issues = not done)
- Skip review loops (reviewer found issues = implementer fixes = review again)
- Let implementer self-review replace actual review (both are needed)
- Tell a reviewer what not to flag, or pre-rate a finding's severity in the
dispatch prompt ("treat it as Minor at most") — the plan's example code is
a starting point, not evidence that its weaknesses were chosen
- **Start code quality review before spec compliance is ✅** (wrong order)
- Move to next task while either review has open issues